Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760396AbXIXQwn (ORCPT ); Mon, 24 Sep 2007 12:52:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755110AbXIXQwe (ORCPT ); Mon, 24 Sep 2007 12:52:34 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:48399 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754358AbXIXQwd (ORCPT ); Mon, 24 Sep 2007 12:52:33 -0400 Date: Mon, 24 Sep 2007 12:52:23 -0400 From: Jeff Dike To: lepton Cc: lkm Subject: Re: [PATCH] 2.6.22.6 user-mode linux: fix error in check_sysemu Message-ID: <20070924165223.GC23078@c2.user-mode-linux.org> References: <20070923122653.GA17386@router.lepton.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070923122653.GA17386@router.lepton.home> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 21 On Sun, Sep 23, 2007 at 08:26:53PM +0800, lepton wrote: > it is a error do count++ here, it will let the following compare > (after 8 lines) " if (!count)" always be false. I take back what I said. It looks like it's checking for some non-zero number of traps, which would be for the instructions leading up to the next system call, followed by the system call. It bails out if the system call is the first thing it sees. Given this, I think your patch is correct. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/