Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 13:49:52 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH v2 0/3] Some fixes and cleanup for maple tree.
Message-ID: <20230405174952.n3fqigyhrv4l3sg4@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
References: <20230314124203.91572-1-zhangpeng.00@bytedance.com>
 <20230404132702.9240f3a77d0c00fca4b9bf55@linux-foundation.org>
 <1d3b071f-ead7-4431-c9f8-c712e7c8bdc6@bytedance.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1d3b071f-ead7-4431-c9f8-c712e7c8bdc6@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek56aTZyeTVHeE5IUm8wclNmVGdPT3ZMYnFXSW90K3gwQi9KYnJGT0NhazZZ?=
 =?utf-8?B?REVRdkNsZHp4TVI3SjFIR3JFSW9BNWRVSXhPdXIxZDJKS0wwLzVvRG55REla?=
 =?utf-8?B?TmhnRDVwWHdnUS9NdEwzaTNOVUtQQk9QQzZHclo1SmNqS05xblZsaElxVnNB?=
 =?utf-8?B?V1oxT1hVNktkN3IyZzd1TEZHYWRGUzgzUklhN2RuRTJPY1N2QVNPMWVkM3Zm?=
 =?utf-8?B?Wnl1TWV5TkNJN2xjY3MrQ2dWZ0NOb2FhTElDNnZ5ZjV3MSttVUw1Zi91Wnc0?=
 =?utf-8?B?S3NoUzFydWtRNmxxMlZ4MmZveE5OTHNlUXNZcWpWdHpCMmRaR0V1TFpmVzlK?=
 =?utf-8?B?N1IvUVJUK3N4UHR3d0hRTUt4Tkhvek16UXFnTVVobFpsL09CM1JDZ28wdnBx?=
 =?utf-8?B?ZFVQQmJXQlo1eDgxNWJkTy9RbFdabCtaZndXMDh1M0RCaklVQXNhUEd0RTlY?=
 =?utf-8?B?MjZxNU1XSXdlZGt0OEhCb2J6bHprSWZEVWhwdjlQbzVQQncxSEtMQnJzVzFC?=
 =?utf-8?B?VXhkRUtocm00cnBGUGpOWG8zT0NLR3RjTzZycUI3aDZhRTY5S21wTjNsWlZ0?=
 =?utf-8?B?WVZRRnFPL0tTTnYwYkpHYlV3bStWRjhHZUlCSS9zNHU1NGVPMEl1d0czaDBP?=
 =?utf-8?B?VlZNN2Y1T0ZQMzdnOWUzQm92R1U0Qmh2NVJTcW1wbU9pOWx6RXN0bEtJVUFs?=
 =?utf-8?B?ZkUrU2xkdDRteklwajZ1ZyttMzVSck1rbFhMZmZSa0IyNzhjQVh3N253Z2VF?=
 =?utf-8?B?dHFFQkJXeE1WN0pKcXVWRzZzNjZyRUFScWdiS2crMllqenl5WlFDTzVMNTM3?=
 =?utf-8?B?WVQyZ1p6WmRFUGViY25nZmtQbjB6NHA4L3pGUTBpdHltUW5qT2ZKU3ZzQ29u?=
 =?utf-8?B?Y1lVRGZ2UncyRU9GNG5JZ1lCMFBjeXVVOVY0TXRoM29VNGU1YmJGRXBZeFh3?=
 =?utf-8?B?WDNsTjdNaGRORXdGRnFxelN5WDVWNHI1Nzg5LzJYMlFabXYxN3psZC9YRmpD?=
 =?utf-8?B?RjZ0MXo3OW8rbVB5VjFhQVkwREhMcHVOK0pvMjduNVNVbHRWdzlBeFlFenl5?=
 =?utf-8?B?M2xKekRuZjloQnkwSUtzZDF5QS9PMlVWUTVrQnFqNWxEZ0RqTU8rOUtSVTIz?=
 =?utf-8?B?cDVLdDVGamZBT3FSVUJlQm5hN2drTlJWQW1WcTBjWkgyaGRDOS83RHd1dTdZ?=
 =?utf-8?B?Y1RPK25qRXNCZ1dETHE2RERjRWtmWmJBdkE1UXdsTWp5a2RuUyt2bFFGYUtp?=
 =?utf-8?B?MGUrbThXMGNUZTRUbXBHeGpJb290aXJ1UWRmZ0VEMkhyUklDalJLaGxGSVRE?=
 =?utf-8?B?amZZVG9YUzNhMmZuenh1cjdWbzU4allRUGVMbFAwdHZybTBuWHBZT1IrYnF3?=
 =?utf-8?B?amZMbmlZYzRFRTV4WlpHQXllY2xMYktELy9rdGpqTlp0elh3THBiM3RFNEd5?=
 =?utf-8?B?NCszbnM2dGt4b3hLeWtzUm15UFd5N3o0MThJNE9rLzVVVTNCWDY5TXBoTlFh?=
 =?utf-8?B?eEVMZitYZXRYUXErc0Q5OUNSa2tQUW1oaEtrTXQ1emJ3ZityRFRCZVZ5NWF1?=
 =?utf-8?B?azFaVGFEYzMwOUVzbnZDL0psSjA1c2pxUFVwVlNUK2tWWExwVE5LaC9nN0gv?=
 =?utf-8?B?RVE1dTI3Q0ttd3h2enVzYmtEbXBvaFVXNzFjd2pkeDhqeXprdEx4a25zdXpv?=
 =?utf-8?B?b1czakxhOUpZM24rU3kyaTg3czVXMmF6Z240MjVLRk5sTjdFbGcvRjJXZjFF?=
 =?utf-8?B?SXRNSERPM2ozVHd1UmxqSkl2WjNLdnBzK05QTzkyMXZmNmpkQmZyRGhoelMy?=
 =?utf-8?B?R2E1TGlpZmJXRkxnaGZveFNsWCtnMDRBNUFYaE9mL1diMHhEZkpaV3NnN1hB?=
 =?utf-8?B?SjF0bWx6ejBXRzFneEQ5cStiNUd1YVh2VFBKaHM2bGgzL08rWU1lWVA3c1FE?=
 =?utf-8?B?aWNaQitSQzlRcXF0VVlXNVhIMkh0amVMWkRiME5MRGJRY2FpUWNSbTZEcG9H?=
 =?utf-8?B?Vm9ya3FLRktZL0NrbEVYSUp2UFZFL1dMQmVva0ZKWm9BWGRPdEh0d2xVVkdy?=
 =?utf-8?B?dGkvVUtqU2hDSWNCUTJtNGlpOSsxUlowMFFHejJ5ZDN3TjN5WXJucnVRcHZz?=
 =?utf-8?Q?dwIQnalPqsGgkmjP3+B0sh/4z?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RWluTVZoTGloNk5nbmwxNmVGRWM5bmQvVDMrR3ZKYkZ2amN4N3ptdWdMSzE3?=
 =?utf-8?B?UE00blg5RkZLSzUycmZ6WjFLR1FNeVIzdUxHd3dXM1lkSEdTQmdGdm1aNnBt?=
 =?utf-8?B?aEpVL0RydnZpZTB1emZFRURzeTJOeHc3Z2ZDT2JLeFg1aXlwenNEQVJyb013?=
 =?utf-8?B?V1l4aW5NWi9xZFFseWNKQVEwK2VLTi9ybW9OSnhMc1FEQnFDWElZUHVwQ3VC?=
 =?utf-8?B?d1lKMEVCWTNLZTRLbzFwWFVFTG5xUGcxa29GMFIvYkpOZ0R5VnhVcGsyZVhv?=
 =?utf-8?B?N0FzcVFnYktNVW00WmtVakR0cHlNTWs5eS82Y25JQkQ0TzBlT09lV0pXNFpo?=
 =?utf-8?B?K01XN05IbjJKRjBJdGhIOUg5RjNpQWVDZUFhSjdtSmQyQkRwdkVHdExRTWxZ?=
 =?utf-8?B?dERZK3dqODhUVVB0WUxtN05rUzZmaGlDOEc3NmFnL0JpUHJCQWFoeTFwMzZj?=
 =?utf-8?B?ZDN4NEFWMHVKTmVFb2xLMWVqUDdITXdjcktCQ0h2cUtRcnBzZnpjandXbitW?=
 =?utf-8?B?b2N3RWVuN3kxU0JKTmd3UzBBemFjRWRaVVpJbmx2YjVtRUxEK0dFVU80TWJU?=
 =?utf-8?B?M1R2UDhkVjNsN295dU1iNng3Y1lTTUZnaEZzalJZbzlDVVZEcjF0bUlJcXZP?=
 =?utf-8?B?QkdjRUpWSnp1d1IvVngrdHp0ZkFLTE1kelZVWE9pWmhvUHRBenhsS2dVem94?=
 =?utf-8?B?U200WEhDQ082Vm1KRjJUQ3VwZWIxRlNDeW9GUVFoVjg2Z0FkS0lrbWVxWk9M?=
 =?utf-8?B?UHFBNU9sdXBUTHJJSEptNkpDWCtMc2RtTjlubG9xZnpHQUZUaS92VmowMkpa?=
 =?utf-8?B?TnFKaVk3SGF6RzFyQjRUUUIvUVd1QVV5RjFUdFdHQ1BWSml1UlM0RjJVT3Uw?=
 =?utf-8?B?WWpJeGFYM0ZFV3lxV3Znb1RQM0dEbXpXaE1KWUJ0N1dGWHFtWThFTGpLaTMv?=
 =?utf-8?B?eXhTdmhyQit0L1RkdWdHTldkbDZEVm4ySU9Ga2FUdGtaVmZFMzAxMGMvY0Fw?=
 =?utf-8?B?bURxS2M5ZFJwZnplSk0yZmxNbTVONXNVMHNRWklVNEd0MkRIcG5aN0xNQjJs?=
 =?utf-8?B?YzZjN1JLbDl5MTBxUzVoV1VmVmQ3bDJWZUxqSndkOWNTK3ppY3gxd081U1pv?=
 =?utf-8?B?MjBMb3ZYejg4dlNLTTRQN2JBSXBhOHd1bzJoRTBvRmU1TjlhSVAwOHI1YTJa?=
 =?utf-8?B?SnhJZUFNQzE3NjMrYU80dVJHUDUybHovdmlTMkV2clBGRDhHQUt1c3pPZU9m?=
 =?utf-8?Q?TVRfTDkCxMcx80O?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c133c80c-d803-46de-2486-08db35fe2a32
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 17:49:55.0075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CVAhSNlzEj+6+6w+3Np6kYMvFMsSdVg+/5oNj843Z0zpThD3ID++TPBay5QekGzB2WqTAMh+puZEcc+AoO9nWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7052
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-05_12,2023-04-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=836 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304050160
X-Proofpoint-GUID: vVvBNJeb4ZXvngsSKWowcYcoExyaTROb
X-Proofpoint-ORIG-GUID: vVvBNJeb4ZXvngsSKWowcYcoExyaTROb
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230405 05:53]:
>=20
> =E5=9C=A8 2023/4/5 04:27, Andrew Morton =E5=86=99=E9=81=93:
>=20
> > On Tue, 14 Mar 2023 20:42:00 +0800 Peng Zhang <zhangpeng.00@bytedance.c=
om> wrote:
> >=20
> > > Some fixes and clean up for maple tree.
> > >=20
> > > The bug fixed by [PATCH v2 1/3] does not seem to be triggered due to =
some
> > > coincidences, because now the implementation of mtree_lookup_walk() s=
cans
> > > pivots one by one and exits the loop early. The test cases for the bu=
gs fixed by
> > > [PATCH v2 3/3] are difficult to write. If I think of how to write the=
m later,
> > > I will send them out. So I send out the second edition first.
> > Do we feel that any of these should be backported into -stable kernels?
> > [3/3] looks to be a candidate for this?
>=20
> Both [1/3] and [3/3] can be sent to the stable kernel, do I need to do an=
ything?
>=20

Usually any bug fixes should have a commit message with:

Link: <any discussion>
Reported-by: <if necessary>
Fixes: <upstream commit>
Cc: <stable@vger.kernel.org>
and the usual S-O-B, reviewed-by