Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05c682d7-bddc-d990-37fb-cd1779f7e604@amd.com>
Date:   Wed, 5 Apr 2023 14:32:41 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Cc:     yazen.ghannam@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/amd_nb: Check for invalid SMN reads
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20230403164244.471141-1-yazen.ghannam@amd.com>
 <20230403193245.GCZCsp3RjNZFSE5f9s@fat_crate.local>
 <abc57738-6ab9-50e6-6c05-5059299d19d1@amd.com>
 <20230403203623.GDZCs4x5yVReaPVOaS@fat_crate.local>
 <a8826972-376a-5af6-8e61-d74520e355df@amd.com>
 <20230405180648.GEZC24uJ+GSMZxczaW@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230405180648.GEZC24uJ+GSMZxczaW@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3o5aUVZcGU0dWRFVE9KWUhyNVE0VDFBRFpHa3owVjhaYTM2aE5kT2dtNlNP?=
 =?utf-8?B?c09obTB0a0Y3U1BvYnluTnpIQnQzcnlSRnRwT3NBSkdGTldXWDhoYjVEWSt1?=
 =?utf-8?B?eHZtQmFCZld6NW8xeUtjaVl0NHdVS2VabGlpcDIrWjBFSGphQjd2Zjg1TnNp?=
 =?utf-8?B?OFF4TFZva2ZiRkNHS1d2YjZDZERGT1RLUnI0eXRid3E3dkNzOTQ3N3p0aUk5?=
 =?utf-8?B?aG41OVhGRFRITFB6Sjc4bzJ5SEsvczQ1cEg5UGo0ZThOYjkvcjVQVUJmYmhv?=
 =?utf-8?B?Zk9QK3dmeUZmeFdEbXRvc3ZXVmlnbmZqN2JJQTltL2xPVVBObEVZaHRZQUE2?=
 =?utf-8?B?bFlVNXpsQlFUUUhZQTlGUEllTlEwaG1ydlg1em55TW9SbjZBK0JlR0VwZWlI?=
 =?utf-8?B?cDNCU3BkMlFtZXpRMDU4T0JjTlF5OURER1ZPRlZteHdkUXNGb1RPeDJ6UlIx?=
 =?utf-8?B?TGpwMjlYaE1jSEdHdmhGQ3A1Q0p1K1RFbXF2MWIwVXIyREdRV0pWbWkxL3dO?=
 =?utf-8?B?RTNLRWQyQ1F3ei84UHBJYld2QVdIQzk2bnl1UnpzR0ZObHRDTWxlSm43UXdl?=
 =?utf-8?B?eUFtdjNpWUlRRlA1RG9JRU80L1p4VVpZRWRHZHVvR0JnQzFGRkhCcWs4cnBs?=
 =?utf-8?B?YmZpSGVyM05jYmx0QnpOTUU0d1AzNFVPUGZVdWNCbk91RGVYMmtSSlJzWWx3?=
 =?utf-8?B?QkpYeDdBaUJ1dkhyODNzY0d0ZlBNdzF1WnhLTktNeVFnNUViajFBcWR3enhr?=
 =?utf-8?B?a0Ewei8vbFpzYkQ4dEF0dlpSdEVCc1NoeW15NjQyazI1N25SOHJ0RDkxdExJ?=
 =?utf-8?B?Z2loSklFZVZ5YjFNRXc0dTZoRTFYT3pVOGU4UUdBQnhOTFZPTW53bkJpWjAw?=
 =?utf-8?B?SzliRHdwUEloQXpxKy91OTZLSy9GYXZZa1ZSVW5KZmo3ZkVnSmhvZU9YMUxI?=
 =?utf-8?B?aWwrZXl0QUZyS2tWeHNCcUpXMEs3cUlRR2RwNDV4UDdmNEl0d0xZOWM1WW5z?=
 =?utf-8?B?cmV0bnNXNElzdzhaSmVRQ0hKRXp4eFhaL2NDZUVDKzJycW9naFZGZFhzdHI3?=
 =?utf-8?B?RVE1dkJJZE1BNldZcUdQQjFZVUppOHJjUEtIVnV1am1SNXZYdFo5ZjMwbHFP?=
 =?utf-8?B?OWdhM1hGcll0aGNxK09Hdk01Z21mSnBHWVN1eWk1b1lWMWpWbjRvMXJ1NVRq?=
 =?utf-8?B?MWVGcjhJbk80cWsyY0lGTmRTZlJLd09IQTRrZ2FjT2FMVEtHekxEcTkrOEls?=
 =?utf-8?B?RDZGNjU1U1JlSThjcFhqdUdDTUdSNEZ6bkxneUZ6ZXl4eVEwZGhCWFZxWXkz?=
 =?utf-8?B?VGtzWXRUZithVWI3VFpjOWx3S1VjUHN0WjRLOTJNdTVwRWtHVkZleFNpbUNG?=
 =?utf-8?B?QkxjVkl5NzMzRTNuL1Q0WFo1dTdTaVFJVzh5S01XSkdHaU1BM2QyUXhuWGNJ?=
 =?utf-8?B?cUVIOWdZSE93dVhOMzA3STd1bEswNWFXNjRYS2NjYkxpaW4zR3liRmVHUjVY?=
 =?utf-8?B?T1hydXN5RlRVcUlMYXM5M045Rjd1NXlnZFdyMWJNYkdqVHNmRDY5UE1LMFdo?=
 =?utf-8?B?ditYRjhWc1ZPZDFUY1piZ2xqQXd1OVVtWExzS2k3Q0ZIQW5EQmtJUytKcVY4?=
 =?utf-8?B?eG5FaHhQaXoyNWlZYUIvcEExdFluWm12Y0E3d2VoakhYWnRTc1ZKMzByN2cv?=
 =?utf-8?B?QllFRzh1MTl5WEhzcDJBOEJDWStCdDArRExjaVRiVVV2dEVFUEUxek9WK0ll?=
 =?utf-8?B?OVlSS1JnRGZ6aEZZbzlMOVh6RGY1WGxTZkZCSllqZzF2OHVNdUNDRFI1K3VU?=
 =?utf-8?B?a2VOcEh6OHVKYngzSnBqSE56eCtlUEFLdVY2L1d0UFdoUEtqYnNQelRMTThR?=
 =?utf-8?B?TER0OTVnd0J3RVQzZ2NNSjM5WmJTRXNuanEzVFRmb0Y3RUxHNjZyeWxlbEM1?=
 =?utf-8?B?RUpKcnhrYjUzdzF6UlpLdE1WQUNOYXQ4U0NDVmxVUHVPN05wdklUbEFaL0VL?=
 =?utf-8?B?NUxRVWN0cFZweDA1TTNxWURsTmI2WHNTWCtNMUJNcnRheVdqUHh3YkpDY3pw?=
 =?utf-8?B?ZnRUNmQ5R3RjR2w0bHA2dGVTL0o5WnFYMDRFL2JzK2JsWE9leUN5QWp3bkdS?=
 =?utf-8?Q?WnaIwOCEULKtWnTisqeZWoKgB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c15fd60-2f46-4b1b-1b8e-08db36043dc8
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 18:33:24.8890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NEVOejf51L5cyW0+qBZwWKDo9DlYshMKtU2cjbstrqsijkHrvyf9fVgcHLPOosccbtDH0Yy10Y08Kmzp7y4P5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5180
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/5/23 14:06, Borislav Petkov wrote:
> On Mon, Apr 03, 2023 at 05:36:40PM -0400, Yazen Ghannam wrote:
>> Yes, that's fine. Should I send another revision?
> 
> On a second thought, I think we should do what you said in the write
> function too. Because the write can fail too. So if it can, we need to
> handle that potential error too.
> 
> Care to send a new version which does this check in the read and in the
> write function? Basically what you had initially but with the write side
> check added too to amd_smn_write.
> 

Sure thing. I don't have a real test for the write path. But I'll test by
faking it.

Thanks,
Yazen