Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230405163602.1939400-1-trix@redhat.com> <20230405164635.GA31303@cmpxchg.org>
In-Reply-To: <20230405164635.GA31303@cmpxchg.org>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Wed, 5 Apr 2023 11:38:16 -0700
Message-ID: <CAJuCfpF33qHhfxtUC1_A4DVAueUnMYG07QJr3cJouCCvxZF_PA@mail.gmail.com>
Subject: Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled
 storage-class-specifier to static
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Tom Rix <trix@redhat.com>, mingo@redhat.com, peterz@infradead.org,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 5, 2023 at 9:46=E2=80=AFAM Johannes Weiner <hannes@cmpxchg.org>=
 wrote:
>
> On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> > smatch reports
> > kernel/sched/psi.c:143:1: warning: symbol
> >   'psi_cgroups_enabled' was not declared. Should it be static?
> >
> > This variable is only used in one file so should be static.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Suren Baghdasaryan <surenb@google.com>