Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52a15482-b23c-e772-4a56-0f4a09f3af17@intel.com>
Date:   Wed, 5 Apr 2023 11:40:22 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [PATCH 3/4] mfd: intel-m10-bmc: Move m10bmc_sys_read() away from
 header
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
        <linux-fpga@vger.kernel.org>, Lee Jones <lee@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230405080152.6732-1-ilpo.jarvinen@linux.intel.com>
 <20230405080152.6732-4-ilpo.jarvinen@linux.intel.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20230405080152.6732-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXNXSVFkSlNaRFNKMjQ4aGxzNFJpU01DNGZ3T0gzV3lUYmpqMVJ0N1ZmQVZa?=
 =?utf-8?B?YmxFYmlCejJLZWNOL0VOd0xDeXJ3S25vMHFsUGpIZUVRU0l1bUhvSnJZcnNm?=
 =?utf-8?B?VDBIdU5ObDRDR0xiZ3pkVUNqNHYrLzl3TkplM0NQTVJVRHh6TDROUko0WkRa?=
 =?utf-8?B?M25jdk5hYkxCVFYwUCtJRlBESUprb0oyeTBBT2Vqd1FyRlZ1NHZxdWVjM01v?=
 =?utf-8?B?Si9URnRlNzREcHh2MnowQXZxVGRNci9uM1d1SnV3anpTNGZLNVU0R1pHcHJJ?=
 =?utf-8?B?MDVlTnNPL3YxSVZyZGp3aWFQU0pweVM4a1h4RWVwb3BWeEpLWjBqaTMxaHRX?=
 =?utf-8?B?Z2hxc05oR2htSkxpNmJXN3NyRitQSy9PNFpMWm9UWUdvTmtrM3o1b3hhN0hz?=
 =?utf-8?B?VkNGZCtKWkcvNjVzcUFyUDRsbnBDMGJsYUVaWkZMK1U3VGtkN3NRQ1hkeVpQ?=
 =?utf-8?B?c1Nqa3lXNmlReUhJTUtoMDREN1ZoVmI0aFovUXZwN2MzOE1vMEdkRnNlcWhj?=
 =?utf-8?B?alVSRTAyMFJIZUVENTIzRlZoZGFUclZVVlhjM1hmSmVPV3hFYWdtM2FkcVYy?=
 =?utf-8?B?RXBHekVKRHd3alNXYXhZWDlxcERRT0kvVmZiZDlYZmRxWDRVSlozNjRMMmlP?=
 =?utf-8?B?ODdlajBzZkRRZi9IZmpLaXk1VFlrSkt5WWEwQ1piVE9PcFRZcXREYXdXZFk2?=
 =?utf-8?B?c2tQYlQxNFJFdzcvR1NINXZ5Y3BMR3hTMmdmY0tCRytTZHU5QndnWHZNUFVE?=
 =?utf-8?B?SFBXNWkrNVp0ZnFKSkdjZk5VdCtaNjlCL0FCSWhUZ1hKdWx1UU9QcmtJWDRS?=
 =?utf-8?B?dHVTcTBySlVkRTRoaktNVE1ZQUZ5S0ZRdzBET3JSOUlJd29KbG5Nb3FGTWh4?=
 =?utf-8?B?QS9lVDJ0cXhiOG5uU04vejlMWnFTbVlkblA3Y3lLUHZWcXp2NTFpbUJqaE50?=
 =?utf-8?B?UFVDQlZHK1RLSExaYkQwVkZXTFNRaS9mOW5PQ3A5TXJEekhENUlsN1dGcFBt?=
 =?utf-8?B?d3p2Nk9hbHY1MUtiMTJDb0RJUFRTdmtmY1MxT1M0V0JNSDBtVE5pZFFpR1hV?=
 =?utf-8?B?Qmk3c0NsTTM3QmdLNFJKQ3dDdjdoK3UxOWF2UTBQbnNhb1phUjFuUUFBNms2?=
 =?utf-8?B?WXE5Z3ExRkVXaVpYdVZLMDZLOHplWlREVzJHak1wVzZUcmpHV2JkS1RiTGFK?=
 =?utf-8?B?ZjdCYnMxc2VjWURUMGMzbkQ0VkNXSklHVXVUcFpwakxwZERTVXFhY3FGcnVi?=
 =?utf-8?B?d21KZkJhVWM2M2FhZU1rczR3U3RoWXUwdXd0K3dwTDJGMThGN0oyMFhtUUNT?=
 =?utf-8?B?bHhqb2RLV25tcjh1RkJhbkpLcEE1WnB6ci9aWXJiMXFOV083QUcrNjBaTjJz?=
 =?utf-8?B?ZDJjREZsVUVuNDVrVDUrcHVFQzc5STZDR2l6ZjMzY0Fzc1NMaWd1Yjhia1oy?=
 =?utf-8?B?ZlJTWFJwNldhbTlpYU5ITk1yMDB0cXp1WnpYQk1IOHBNWmVZUElVcmlNTmRE?=
 =?utf-8?B?R3ZzTUx0RU1MYTlYOEdrczZFZit6Nng0Y3VLaHZTQkkzYjJ1VmlSak9YWndV?=
 =?utf-8?B?VkliTTdNcEF3UEJyS1VHWk8vSFFWUnQ4RWlFQ2JYL0lWOGwvVUFKS1M4YzAz?=
 =?utf-8?B?d1gyT2lPY3lIT3ZjMTlDdmtZZVJ4ckVsSkoxaDV1UW1BWG8rSXF0NDFsejRX?=
 =?utf-8?B?Zld2TkpOZFBDeUNpV3Q2L0pFcWNLMDA5S25Sa0tFUi8rNDVOWlY1TjFzclZ4?=
 =?utf-8?B?UDAzTGVJT3N1bWJqYVBCME5FbFZ5Y3dWeTJZMy9ZNXpJdTQ2RFNMMDF1Z1ND?=
 =?utf-8?B?bVNYK0ExRFQxZmtlcG9VaVRqUkpOK0N5Y0ZmUitxNGJsR3VGZzlSZ0Z5b0Rk?=
 =?utf-8?B?RmZSSHNkMlVlWDBNeUVFMWI3OHQyeGNpK0ZoblR1YU9nVjNIUzl6M0ZOczM3?=
 =?utf-8?B?QnRQNkdvNmpnajV4NzV1WnhjV1pyMXh3aEtycjRqWEYrSllhNXFWbFFFdDNr?=
 =?utf-8?B?ZmtYYnZEOGVkRWpiUTMyb2xRSnhBQ3NwVUJaVFpZK291cGVEWW5hTURWUnYx?=
 =?utf-8?B?Qm9hanI1cmd5eFA5cmYvS01zQ1dNYmd4Tk8zR241d3N4YXQ3dlZnN2YrRzZP?=
 =?utf-8?B?Tlc3UkhPYWxpVmxjRFpFMitmQWFES2FSdGVxSWhnQ2hEa3pnWWNscFYzVGNn?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad9f34c1-2288-4e56-da4b-08db3605385b
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6763.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 18:40:25.3169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ESoCvMH5EjWKUT2+vu4pUnnVe1wBdqSK/U74YlGUHNfk587ZTOAlyo4pxfcElrpiIiqjcbSJSUZtJ+2WS92e+htycfw20cOdrQscJ/Us5rU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7672
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/5/23 01:01, Ilpo Järvinen wrote:
> Move m10bmc_sys_read() out from the header to prepare it for adding
> more code into the function which would make it too large to be a
> static inline any more.
>
> While at it, replace the vague wording in function comment with more
> precise statements.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/hwmon/intel-m10-bmc-hwmon.c |  1 +
>  drivers/mfd/intel-m10-bmc-core.c    | 14 ++++++++++++++
>  include/linux/mfd/intel-m10-bmc.h   | 17 +----------------
>  3 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/hwmon/intel-m10-bmc-hwmon.c b/drivers/hwmon/intel-m10-bmc-hwmon.c
> index 2f0323c14bab..92900ce7986b 100644
> --- a/drivers/hwmon/intel-m10-bmc-hwmon.c
> +++ b/drivers/hwmon/intel-m10-bmc-hwmon.c
> @@ -794,3 +794,4 @@ MODULE_DEVICE_TABLE(platform, intel_m10bmc_hwmon_ids);
>  MODULE_AUTHOR("Intel Corporation");
>  MODULE_DESCRIPTION("Intel MAX 10 BMC hardware monitor");
>  MODULE_LICENSE("GPL");
> +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE);
> diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c
> index 879d98b9b14d..4a1bfe135293 100644
> --- a/drivers/mfd/intel-m10-bmc-core.c
> +++ b/drivers/mfd/intel-m10-bmc-core.c
> @@ -12,6 +12,20 @@
>  #include <linux/mfd/intel-m10-bmc.h>
>  #include <linux/module.h>
>  
> +/*
> + * This function helps to simplify the accessing of the system registers.
> + *
> + * The base of the system registers is configured through the struct
> + * csr_map.
> + */
> +int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int *val)
> +{
> +	const struct m10bmc_csr_map *csr_map = m10bmc->info->csr_map;
> +
> +	return m10bmc_raw_read(m10bmc, csr_map->base + offset, val);
> +}
> +EXPORT_SYMBOL_NS_GPL(m10bmc_sys_read, INTEL_M10_BMC_CORE);
> +
>  int m10bmc_sys_update_bits(struct intel_m10bmc *m10bmc, unsigned int offset,
>  			   unsigned int msk, unsigned int val)
>  {
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index 5418f7279ed0..252644fa61be 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -267,22 +267,7 @@ m10bmc_raw_read(struct intel_m10bmc *m10bmc, unsigned int addr,
>  	return ret;
>  }
>  
> -/*
> - * The base of the system registers could be configured by HW developers, and
> - * in HW SPEC, the base is not added to the addresses of the system registers.
> - *
> - * This function helps to simplify the accessing of the system registers. And if
> - * the base is reconfigured in HW, SW developers could simply change the
> - * csr_map's base accordingly.
> - */
> -static inline int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset,
> -				  unsigned int *val)
> -{
> -	const struct m10bmc_csr_map *csr_map = m10bmc->info->csr_map;
> -
> -	return m10bmc_raw_read(m10bmc, csr_map->base + offset, val);
> -}
> -
> +int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int *val);
>  int m10bmc_sys_update_bits(struct intel_m10bmc *m10bmc, unsigned int offset,
>  			   unsigned int msk, unsigned int val);
>