Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f539e49e-d831-2ab1-6344-f37f909895ea@kernel.dk>
Date:   Wed, 5 Apr 2023 13:54:56 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [RESEND PATCH v2] eventfd: use
 wait_event_interruptible_locked_irq() helper
Content-Language: en-US
To:     Wen Yang <wenyang.linux@foxmail.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>
Cc:     Eric Biggers <ebiggers@google.com>, Christoph Hellwig <hch@lst.de>,
        Dylan Yudaken <dylany@fb.com>,
        David Woodhouse <dwmw@amazon.co.uk>, Fu Wei <wefu@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Michal Nazarewicz <m.nazarewicz@samsung.com>,
        Matthew Wilcox <willy@infradead.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christian Brauner <brauner@kernel.org>
References: <tencent_16F9553E8354D950D704214D6EA407315F0A@qq.com>
 <43fd324c-585c-d85b-230c-5b086e1aaa2c@kernel.dk>
 <tencent_1A9532B54AD0FB644D7A28B39C5FF9B34506@qq.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <tencent_1A9532B54AD0FB644D7A28B39C5FF9B34506@qq.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/5/23 1:40 PM, Wen Yang wrote:
> 
> 在 2023/4/6 03:26, Jens Axboe 写道:
>> On 4/5/23 1:20 PM, wenyang.linux@foxmail.com wrote:
>>> From: Wen Yang <wenyang.linux@foxmail.com>
>>>
>>> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
>>> ("wait_event_interruptible_locked() interface"), but older code such as
>>> eventfd_{write,read} still uses the open code implementation.
>>> Inspired by commit 8120a8aadb20
>>> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
>>> patch replaces the open code implementation with a single macro call.
>>>
>>> No functional change intended.
>> Looks pretty reasonable to me. How did you test it?
>>
> Thanks.
> 
> We have verified it in some local testing environments, and the intel-lab-lkp has also tested it more than a month, as follows:
> 
> https://github.com/intel-lab-lkp/linux/tree/wenyang-linux-foxmail-com/eventfd-use-wait_event_interruptible_locked_irq-helper/20230217-023039

Nice, you can add my:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

to it as well. Adding Christian as well, as I guess this should go
through his/al/vfs tree.

-- 
Jens Axboe