Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43a469322f1557feb252a08bd4a42f03.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230329075104.165176-3-mmyangfl@gmail.com>
References: <20230329075104.165176-1-mmyangfl@gmail.com> <20230329075104.165176-3-mmyangfl@gmail.com>
Subject: Re: [PATCH v2 2/4] clk: hisilicon: Use helper functions
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     David Yang <mmyangfl@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-kernel@vger.kernel.org,
        Conor Dooley <conor.dooley@microchip.com>,
        Nick Alcock <nick.alcock@oracle.com>
To:     David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org
Date:   Wed, 05 Apr 2023 14:06:49 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting David Yang (2023-03-29 00:50:51)
> Remove redundant codes.
>=20
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
>  drivers/clk/hisilicon/clk-hi3519.c      | 134 ++----------
>  drivers/clk/hisilicon/clk-hi3559a.c     | 228 +++-----------------
>  drivers/clk/hisilicon/clk-hi3660.c      | 207 ++++++------------
>  drivers/clk/hisilicon/clk-hi3670.c      | 270 +++++++++---------------
>  drivers/clk/hisilicon/crg-hi3516cv300.c | 177 ++--------------
>  drivers/clk/hisilicon/crg-hi3798cv200.c | 206 +++---------------

Maybe you can do this file by file in a different patch? And the commit
text can say that you're migrating to the new way of registering clks
with a device pointer?

>  drivers/clk/hisilicon/crg.h             |   6 -
>  7 files changed, 260 insertions(+), 968 deletions(-)
>=20
> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/c=
lk-hi3519.c
> index ad0c7f350cf0..199d1b8c3140 100644
> --- a/drivers/clk/hisilicon/clk-hi3519.c
> +++ b/drivers/clk/hisilicon/clk-hi3519.c
> @@ -6,11 +6,13 @@
>   */
> =20
>  #include <dt-bindings/clock/hi3519-clock.h>
> -#include <linux/clk-provider.h>

It's still a clk provider. Keep this include.

> +
> +#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/platform_device.h>

Also still a platform driver. Keep this include.

> +#include <linux/of_device.h>

Not sure what this include is for.

> +
>  #include "clk.h"
> -#include "reset.h"
> +#include "crg.h"