Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <nobuhiro1.iwamatsu@toshiba.co.jp>
To:     <gregkh@linuxfoundation.org>
CC:     <mathias.nyman@intel.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: host: xhci-plat: Use dev_is_pci() helper
Thread-Topic: [PATCH] usb: host: xhci-plat: Use dev_is_pci() helper
Thread-Index: AQHZZ4yszw2Uu6nch0evsEAfagPfg68cT50AgAD1WeA=
Date:   Wed, 5 Apr 2023 22:01:16 +0000
Message-ID: <TYWPR01MB94208A9EDA57A18757715DCE92909@TYWPR01MB9420.jpnprd01.prod.outlook.com>
References: <20230405070141.2028455-1-nobuhiro1.iwamatsu@toshiba.co.jp>
 <2023040503-catatonic-gazing-9830@gregkh>
In-Reply-To: <2023040503-catatonic-gazing-9830@gregkh>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?TGF5UHlJd01ZU2NTcVVBNHRxdjhjWHFJY3JFN3RpSndJUUxIRVdoekNS?=
 =?iso-2022-jp?B?b2NuNGxLSWttYUZFd0pRVjVpa3E3SmhBNzlYYzBDU3puY2ZGVkJSSGh1?=
 =?iso-2022-jp?B?M3oxR1pJRVlrWE8wQ21OdklpR0lkZlpoQ09zb0xWbVliNEVRRlZ1UzVD?=
 =?iso-2022-jp?B?YVk3ZnMySlBXc2VPYmo4ZDZXNEl0emxSVEdnU2tJbTNwcjkwVmQwMzZK?=
 =?iso-2022-jp?B?STZSc3BwK3VndWVYeEtVM3hlRFJPM0pacHZXdjFBbE1sQWlmd0hWZ0t1?=
 =?iso-2022-jp?B?bzBHRkJnWUd1TFR4Z1FMK1JZeDdkazRWalhBZ3N6UE8vRm04U0ozZ2ZE?=
 =?iso-2022-jp?B?YXFQWnBKZ1lXSE9xK2o2elo5dWt1d1pMRUt0NWNxVzN6djJicXNIOVB4?=
 =?iso-2022-jp?B?Y2k4Z1c4Q1VKQ1l0T0JsbGVBa2FTUWN6R3lNVGZ0bkhyOFZEanJjOVJC?=
 =?iso-2022-jp?B?U2pvdFJGenFJYU5HL1kySVFuTjdaQlVNRllZVEpZc3BQZ2tueWkxWk40?=
 =?iso-2022-jp?B?eDdFVHBrTUU1cVM1eExFYWg4Q1dlL3VXTk1HSXNHbEYwOU9BNjhUamt4?=
 =?iso-2022-jp?B?YjZxZWlCMC9pZlBnRFFYTWdBN2wzY001QWVYVFBjdnZtSFNJakZ1d3hD?=
 =?iso-2022-jp?B?bTN1eEdmSUkzemhHbnFLTUxjRnZHTk9PNDRKTHZwM3hNK2J4azZVLzEw?=
 =?iso-2022-jp?B?YWJHalRERlorQlRIcDNabU5aYU5rajJ6bCtsRlRXUm9zVGtHaUpWTTFn?=
 =?iso-2022-jp?B?bW9CSUJSZDhta3p1NFR0V1BKcU16ek8vUlA4dkRuVHRDeC92T2JxbDZM?=
 =?iso-2022-jp?B?ckpMRGdSaHM5Wm51YTJaZmkvOTh4RmtVMkhKY3VpOU1jZlMzZXBka3Zq?=
 =?iso-2022-jp?B?UTR6RHIzWGxGQ2tqWVV5YWhscnpFZ1lGWkFwb2l3anU4ODc4NGp5a0Fp?=
 =?iso-2022-jp?B?c3hFSm9kS1pBTStnTUljZlFtVGphc0YvWXJ6cTlhMHdNM2wvYXU5TGlz?=
 =?iso-2022-jp?B?blpWYUtvME5tUWxEbkV3ZnBtQUcrcitBSitKeGIwR0RmajlINkpEK2Iz?=
 =?iso-2022-jp?B?MjZBZXpFaFZZWndGeFFOVnJtL0JDeUZwNHZoTHBYMmZseUVoNms0NmJN?=
 =?iso-2022-jp?B?ZHNlaEhRYXl4bG8xekh5a0dSY1JiK2FzWTFPa08zdWN5Y2x2MkpsNnhB?=
 =?iso-2022-jp?B?UHZONlZnbkh0SjluMnJEeS9ZdUtadUoyaytDeDZqVVozNitHUmQxU29W?=
 =?iso-2022-jp?B?cGNVSWJQbXJ1NHhJbUgrR2REYkorcnVjNlpFVTBRWWFHakJaVDlRU1o1?=
 =?iso-2022-jp?B?MVJreFdBMlk2QzdTZW5UZ1oxelBNcldiNEQ2U2w2d2VlaU9rOFozYk15?=
 =?iso-2022-jp?B?bm41dS90UUVzQ1NhWTB2NlFkVVJVWVZVRHozTGNUd2p1dWpOQjNMcWdK?=
 =?iso-2022-jp?B?bkpuajRqc1RIWW03VlA5S3dXUmdCY1g2WFRySmlKS3ZjUkpyMDB2b3lr?=
 =?iso-2022-jp?B?QnZWb2J5cTkvZ2VCMDdWcGEyMGVmRWNjNjBlYk1PckZhM0hhTGlua05X?=
 =?iso-2022-jp?B?VkV4NW5MVXR4MklLalg4RzZkK3NCcndWdGdhV2VvUGtTZUprZXg0STBY?=
 =?iso-2022-jp?B?M1ppUndUYldtTDR5NGtHOVB4OU9uMEpmQ08rOHlRVkJJNi9QdkFBUGIv?=
 =?iso-2022-jp?B?NXRaYVp4UmJEMitWdVNQbU1IOUR0aXE5NkZrYmQ1RksySGlVRno5Y3Fu?=
 =?iso-2022-jp?B?alZ2eTJYallMTWZXTFQ1ejBybDYveS90a0RVbWUzS2pNbUtHdSt6UURs?=
 =?iso-2022-jp?B?WUg5dk1xYysyTXNwL3NlNGRyVmt6TEdFTHpTMzV3ZTRWc095RHVwcmRv?=
 =?iso-2022-jp?B?L01zbWJ6enUxVWZSUEhUYnhBQS9zQm9RY1g0cXl1WmkrTEViS0tMYkpG?=
 =?iso-2022-jp?B?Wm5zUGNONFE5LzFBeWFURS9NVmdzMTNZZ0xvZVYrTWFZMjdsa0tYQVpU?=
 =?iso-2022-jp?B?UzdDdVlVUzIwRnJkUStRV2NRK05ZQlJuVHJLT2lBNEwwNkU5dis1MUgv?=
 =?iso-2022-jp?B?Z0V0OHAybGZwQ0g0Tzc0ZUkrdDA5dTRycFN3OFV2VFQ0YUY4bVhGZlIw?=
 =?iso-2022-jp?B?OVVpZ2dVcjFkVmdERE9IaGJSU28yUWRBRXlHWjE3czRUTkFBQ3Y3eE1H?=
 =?iso-2022-jp?B?TVk4em9tcUZHYkhnTmZNQ2FGNWpwMW41OVFFc2NBV3IzSnhVZDV6MnV0?=
 =?iso-2022-jp?B?aFJtWTJ1Q0xpeXVqSVg4RFBBUjNLeEtXWFRtTW5XOUpyOGZrQXVKejV6?=
 =?iso-2022-jp?B?c3JHZzdxVVNjOXBUR0EyWGEyZHV5dmorUWc9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYWPR01MB9420.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d7f755c-319c-4169-4d90-08db36214785
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2023 22:01:16.4630
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LLNzOkaGiaIwjr8B+daUh7e8a1Pj1MOp8rExB3CoqCFii4QxKF5S8E19P7vIo9ZIm5iJGb3f6e4t0stJKUdk2pgfmczBCBTiSKv5bJmmGU3+juhtQDmxe0aAQfXgHdKk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB8782
X-OriginatorOrg: toshiba.co.jp
X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, April 5, 2023 4:22 PM
> To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: mathias.nyman@intel.com; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] usb: host: xhci-plat: Use dev_is_pci() helper
> 
> On Wed, Apr 05, 2023 at 04:01:41PM +0900, Nobuhiro Iwamatsu wrote:
> > Use common dev_is_pci() helper for checking PCI devices.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> >  drivers/usb/host/xhci-plat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c
> > b/drivers/usb/host/xhci-plat.c index b9f9625467d61e..2c95189424fa6e
> > 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -363,7 +363,7 @@ static int xhci_generic_plat_probe(struct
> platform_device *pdev)
> >  			is_acpi_device_node(sysdev->fwnode))
> >  			break;
> >  #ifdef CONFIG_PCI
> > -		else if (sysdev->bus == &pci_bus_type)
> > +		else if (dev_is_pci(sysdev))
> 
> With that change, you can also get rid of the #ifdef lines too, right?

Yes, that's right. I will send v2 patch with it.

Best regards,
  Nobuhiro