Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5b8bbe752ce03cc690441cf4b6f6fe0f608a1e54.camel@linux.intel.com>
Subject: Re: [PATCH] sched: rt: Optimization function 'pick_next_rt_entity'
From:   Tim Chen <tim.c.chen@linux.intel.com>
To:     Li zeming <zeming@nfschina.com>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com
Cc:     linux-kernel@vger.kernel.org
Date:   Wed, 05 Apr 2023 16:04:38 -0700
In-Reply-To: <20230405232900.4019-1-zeming@nfschina.com>
References: <20230405232900.4019-1-zeming@nfschina.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-04-06 at 07:29 +0800, Li zeming wrote:
> The moral of this function is to obtain the next RT scheduling entity
> object,while 'list_entry' Implementation function of  'container_of'
> returns the next RT scheduling entity object (no new code should be
> added afterwards), directly returning 'list_entry' The execution result
> is sufficient.

Suggest changing the subject from "Optimization function 'pick_next_rt_enti=
ty'
to "Simplify pick_next_rt_entity()"

Suggest simplifying the comment:

Remove useless intermediate variable "next" and its initialization.  Direct=
ly return the
next RT scheduling entity obtained from list_entry().

Otherwise the patch itself looks fine.

Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/sched/rt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 0a11f44adee5..e9b1c08c20a7 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1769,7 +1769,6 @@ static inline void set_next_task_rt(struct rq *rq, =
struct task_struct *p, bool f
>  static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
>  {
>  	struct rt_prio_array *array =3D &rt_rq->active;
> -	struct sched_rt_entity *next =3D NULL;
>  	struct list_head *queue;
>  	int idx;
> =20
> @@ -1779,9 +1778,8 @@ static struct sched_rt_entity *pick_next_rt_entity(=
struct rt_rq *rt_rq)
>  	queue =3D array->queue + idx;
>  	if (SCHED_WARN_ON(list_empty(queue)))
>  		return NULL;
> -	next =3D list_entry(queue->next, struct sched_rt_entity, run_list);
> =20
> -	return next;
> +	return list_entry(queue->next, struct sched_rt_entity, run_list);
>  }
> =20
>  static struct task_struct *_pick_next_task_rt(struct rq *rq)