Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 16:11:47 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>,
        Kees Cook <kees@outflux.net>,
        Dan Williams <dan.j.williams@intel.com>
Subject: RE: [PATCH 22/32] ACPICA: actbl2: Replace 1-element arrays with
 flexible arrays
Message-ID: <642e00331b335_29cc294b0@dwillia2-xfh.jf.intel.com.notmuch>
References: <4845957.31r3eYUQgx@kreacher>
 <14903668.tv2OnDr8pf@kreacher>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <14903668.tv2OnDr8pf@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KpoKEPQhUdd2PSZtmQc/saJvRLpnT7q6r6u21Rz1zl1CHLSTNS05Z+LFEHZh?=
 =?us-ascii?Q?CputbenY+jhTb6W37LCDQrcz0VbJj3I+Bv/H6hFKIHpkTykxOfPBSCUSQ24g?=
 =?us-ascii?Q?K5BctoGUsVRFXUodfpTA264Jyx6qZeSUo6abMyWai6Chs916OE02ke09/ma6?=
 =?us-ascii?Q?x98prq9UqNeQrrA4wcN50yPfMk0iGU2vgql2XaEEbmaLwvIhgM7PgP5piUWw?=
 =?us-ascii?Q?/qMSsN7T2n5N1BYoZX/CP5dilHKhZ6gr6+K5Jrrj+YMNQq2ZK3mJ/M1W6Vh1?=
 =?us-ascii?Q?xeO2pmmfNU7dZdu0Dwx4/ao7SerO01CJic9pRwFuBS5thUVhwAVFy6Unbx0p?=
 =?us-ascii?Q?Ud1g2r3RMpgx58yyvqw68aePYTHxWHt/+X6ZDfHidp5Mq2dUagiWZ5Iz9xy/?=
 =?us-ascii?Q?peYluhlQXIDjCPq2WW7z4SOvsWB7TeYrKys6gh7LtO8fCCDwDvY2DWrRSzid?=
 =?us-ascii?Q?P8YkTrveDGL8O+KeEItJ+alu8G+jJek94SfycqlzhE0sPI4PuaoybSWKOmQj?=
 =?us-ascii?Q?My9KfYCpEelGpkR9QWrIBe4WjJE4r5Musjy6Jg7oGw+EirNFrlpXNCWxyAoX?=
 =?us-ascii?Q?4M8Ex3RPd0wHXc2WmjOk792Rvkd7RCo6bW5s16il/gd4OXBJ+FWlGqK61ixH?=
 =?us-ascii?Q?8xj67xqe3FI3J1WJz+IQCgTsOLVaKZYbuq4J3czA0K7yOOhQiTB37lXxWLwf?=
 =?us-ascii?Q?cdzvqRipZgXLPCaYzhILjJyVSkSKxeFjQ6+/kd37Kr7rW6wF5NNjw9QXLNJU?=
 =?us-ascii?Q?QmrYfQ3g9y564gBFu9V0z5N4lf2igsrL51xjZRTDegscA4OQZfy26roel8kC?=
 =?us-ascii?Q?3l0SRfw189weMb7aSI0W8TsCoPnQ9xllY0mX9P+J/6mOGQzcp0Q+piVlVbIu?=
 =?us-ascii?Q?EwcW2kBp5lQGtH3PKvRNLmdbZ6uvv71yZvd094fF51GjLjFJ3qmgcuS439tF?=
 =?us-ascii?Q?+pYnCHPo1H2F6jKI8+EgczXhGxGvcn4yMCkpZAhr9adSurvFqSPiRNXxB8Vw?=
 =?us-ascii?Q?sj/FSo7L2gsfEed75Usq9aeSsd23WLhd7JOoC9g7TTwoP3m9gf6aBdWlzL6t?=
 =?us-ascii?Q?ERAj6eYprXPgo893s43jSuJILm0DAgU8250cuQZgfy6qzTGnyKkMxtiskmN6?=
 =?us-ascii?Q?A1QQU7uwVirh9Yb63Iqog9m6C+TKsTJRulZGmCBH7NtXntPikthZ2SQWv0xO?=
 =?us-ascii?Q?Fa0CopIxT00EJG0nHw0t+97VK0tWu+sVup4ZQrvR9EByV12bwvafJPl6qBil?=
 =?us-ascii?Q?yZVN2vyAbKWVbIBdtaRraD9Kk183qgCB7SxUh1Mrkbb41WaHkEpmavGWVKVz?=
 =?us-ascii?Q?MTSxOroHT98HOBBNmUovsUI3fkDtR3Juua5tsHgr8ozM5M425B0Nr6udz8lM?=
 =?us-ascii?Q?mmSChIZLDK5GcZKvOc6Z6t9zaXwurbiapXrF+CeofiJox+Es5aqCLV/GHM3x?=
 =?us-ascii?Q?lhltQhqURt63+2BAJFrp313LYPjB4O/0m7F3m0Yzl0AOrZXIqWGulflGKre6?=
 =?us-ascii?Q?Wo8MkuyM7ETbR/jCw8/ihKuI2ubjb14SlzHnzxZPtr3fVut5W51aGOXpSXxd?=
 =?us-ascii?Q?kn7ESxPU/7AGCDlyVXCbIaSdLjCLxhcwOyQUXsnQ6tpXdLALDaTtaypoNN/M?=
 =?us-ascii?Q?YQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0291a30f-2d77-4290-af4a-08db362b2258
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 23:11:49.2916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 37rQ2B+9l0MfmDSMo8whTyr0Pu0vfps56fm7KKs9Jzcr9xpmZCCpD+DO5XjGZ8+uGjpRayuz7I/tP4d9Ojtid5mE9NZHoQhu/xEeJORox0Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7671
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Rafael J. Wysocki wrote:
> From: Kees Cook <kees@outflux.net>
> 
> ACPICA commit 44f1af0664599e87bebc3a1260692baa27b2f264
> 
> Similar to "Replace one-element array with flexible-array", replace the
> 1-element array with a proper flexible array member as defined by C99.
> 
> This allows the code to operate without tripping compile-time and run-
> time bounds checkers (e.g. via __builtin_object_size(), -fsanitize=bounds,
> and/or -fstrict-flex-arrays=3).
> 
> The sizeof() uses with struct acpi_nfit_flush_address and struct
> acpi_nfit_smbios have been adjusted to drop the open-coded subtraction
> of the trailing single element. The result is no binary differences in
> .text nor .data sections.
> 
> Link: https://github.com/acpica/acpica/commit/44f1af06
> Signed-off-by: Bob Moore <robert.moore@intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>