Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1413033rwl; Wed, 5 Apr 2023 17:14:23 -0700 (PDT) X-Google-Smtp-Source: AKy350Z2q8LkozHrSeb8ysP748bw5LmRZvHQnbUnTIbLqLwlQ0WSkX8qYKFJT0vmhktM4dkhXWc+ X-Received: by 2002:a17:906:4714:b0:931:d644:b9d3 with SMTP id y20-20020a170906471400b00931d644b9d3mr4487824ejq.59.1680740063477; Wed, 05 Apr 2023 17:14:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680740063; cv=none; d=google.com; s=arc-20160816; b=SFjS0rjHtrgUPkiSazGmTWvPlxHnI2UgV/o+38P/41MBdd4onXEuvzGI/6WCMB1y10 TIFxRW7gj/vJqH588BgsEhaHz2NOU1WTgop6f5W59Xy+3PGsdeYLZjPdy+f3VRTteTtj Tujn4meOK4nOKoEvGL5w+NIcu0WflL8QOyG/SzJ3MrYG5raP96iunWKsrWqJKf55jmn1 yjLRkMJs/b/pEBPxq3U6tSkuHIN10ZXP0B6Wk30XiKlMZrvRqWZaCZkhzKhKAxGYl1J7 YcdEtgQyCh4P58bjde4E62SLv7YAa/oC8pfyPNefaLNAPGEmU1AGepiH1HCM8LiLvYxe 2Etw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=T4OZm66D1iuYjWvpX8km2uh3RDDcdiQCrxjSQ3ETEMI=; b=FP13IgYnuE/f9j+0nTBB8kNCUVfSaktRkkgkt1JhANvUOpRdqQMbypGNpwVSPJjD3S 7OzcCghCLAHBuj5oB19dV0sz9whCnjYWIln6ZSce32jkd/GithnS7KwdKu+9V3E3qdf3 sSsigWpzL2njh4TLbK12oI7pGHtyuAv8o+GJ6WfTuZCEYPbMz5/z8Dw1o2PvQmfY2V97 IrNNvi5h7Kf8o75OVUHD6wMqz2kgZkV4+SEThAY0ZeDA+S7rDC6AB6ocu8y2dfxWWKdA oxpTkip3QgtdcdO1j/0Q2bFoNw7vJvr1H3vevUQCQw48WvHNpknBguD5kEN7AtjMzmhZ WPiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dectris.com header.s=google header.b=qbyNmQue; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dectris.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga8-20020a1709070c0800b009485b3ac6acsi92033ejc.342.2023.04.05.17.13.59; Wed, 05 Apr 2023 17:14:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@dectris.com header.s=google header.b=qbyNmQue; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dectris.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234244AbjDFAHc (ORCPT + 99 others); Wed, 5 Apr 2023 20:07:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbjDFAHb (ORCPT ); Wed, 5 Apr 2023 20:07:31 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1134711D for ; Wed, 5 Apr 2023 17:07:30 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id eg48so145188874edb.13 for ; Wed, 05 Apr 2023 17:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dectris.com; s=google; t=1680739648; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T4OZm66D1iuYjWvpX8km2uh3RDDcdiQCrxjSQ3ETEMI=; b=qbyNmQueWRkeUpg8SW/U23pk8mPAl9x0WkQmuIK2YiW6eA34PTitc9sbjcUzL5dVvJ nQW5jLdWOowiQvhdvWqZFpZMjg/a1G01bwMSEe34alyrNNLhSPX31NBFfPR6jgBxoLMm bUQnZpITHIEjwvKDEqfr9xTklKbGXqkkHqr/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680739648; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T4OZm66D1iuYjWvpX8km2uh3RDDcdiQCrxjSQ3ETEMI=; b=Q+K0LnDJoxSOM0EwRE+bmaEABrWDA5YOEAI7KDwNGv/G6XwOyODkS+yFpIpx2/pbEz qdWqydoesF1ouW1wfxu3RkxH/eiQmq6/R6JNzXzbXBYJwLkwMktjU+sEeOt/WA8GIlu4 Xav3bzLQ426/GE+N4az/B+5NHtOqt/SyiIOy+ufvlsJLAEm5x37a5gl37NCjExaFc3Km nhZlOtZxRUnowKGHUlnX9AyH385YcT9iXC/fHCL37hVkzH1BAZlF/Vv8/pEm6hv7+4oR zeP4iwdl6PkrxXAwRxxAZnz3GbvwWgn1moMzAfr2xvnk+K0DJu0GEwR+REecgkr0EVAR /prg== X-Gm-Message-State: AAQBX9exJljS/Gt0795K3WlP66aMElNqmept09PPhmZxom7C3RO9pc2H Qq7fnNMIK7dwftIbQFEN50LpiuJYM0RX4Zp3Jolg7w== X-Received: by 2002:a17:907:c607:b0:932:e546:b8bb with SMTP id ud7-20020a170907c60700b00932e546b8bbmr2816057ejc.0.1680739648606; Wed, 05 Apr 2023 17:07:28 -0700 (PDT) MIME-Version: 1.0 References: <20230403143601.32168-1-kal.conley@dectris.com> In-Reply-To: From: Kal Cutter Conley Date: Thu, 6 Apr 2023 02:12:07 +0200 Message-ID: Subject: Re: [PATCH bpf] xsk: Fix unaligned descriptor validation To: Martin KaFai Lau Cc: Magnus Karlsson , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Maxim Mikityanskiy , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Since you already have a test case, it is better to submit them together such > that this case can be covered earlier than later. > > Other xskxceiver fixes have already landed to bpf-next. imo, I think for this > particular case, bpf-next for both the fix and the test is fine. Done. See: https://lore.kernel.org/all/20230405235920.7305-1-kal.conley@dectris.com/