Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 17:22:55 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>,
        Kees Cook <kees@outflux.net>,
        Dan Williams <dan.j.williams@intel.com>
Subject: RE: [PATCH 22/32] ACPICA: actbl2: Replace 1-element arrays with
 flexible arrays
Message-ID: <642e10dfc46d8_21a829451@dwillia2-xfh.jf.intel.com.notmuch>
References: <4845957.31r3eYUQgx@kreacher>
 <14903668.tv2OnDr8pf@kreacher>
 <642e00331b335_29cc294b0@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <642e00331b335_29cc294b0@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Ph6iTX+Q63rrjspLKwMaRDOjQwAi8Qp68LZqZu81z9LTbthXqWQ5Bvm0IRp?=
 =?us-ascii?Q?cF8zyEj7m2aqWxZXTVojMTlk0B8gBLe7BflT1eYYXBHPYSYuPKlzEJo7SiVm?=
 =?us-ascii?Q?Eig4h2nV3uf5cEDwBijNv0ni0fgU5ApjFSlE6pgDJbIkdvvaDJ/Fs8hLkfaK?=
 =?us-ascii?Q?vQ0JgyHY52DpSXSPCCJ3+VHXhTWqwgRkML/CQ4vTGFlvWFm7mlpz6HkdrAIk?=
 =?us-ascii?Q?ATJrqeIkT5NQn2zbyzSEImSkq+v7PI5folqXu61+Xnnewl5FI7RFvUfZlO6Q?=
 =?us-ascii?Q?knWTjL4j19NUUlUFq1WdxfAPNBPW/o73iIZ3XdP5K2meAX3Lf+WELs7riZIJ?=
 =?us-ascii?Q?8U+SM/aKaVgofgdbbo648elmPNSG6PDxies3LLYookhP+0T6CRisen7cBOZX?=
 =?us-ascii?Q?wyLVlsrP3V41Idk7an7od6NBSQMgSmY0CzZS6l4PJX9U8h3lMkolTYhdnyS2?=
 =?us-ascii?Q?/Vxu0S2+zxdjiTeui4d/yC9ynHeF+DMEFfacTMaujhp9ZVITJemlawETXBVN?=
 =?us-ascii?Q?PZvI2MXsFXtk7b0t6MLVORYZdg2WGh5fcQ/AayOqbJOt1l2sukp5BnxDncob?=
 =?us-ascii?Q?xoFJw/7attq4nTreLXpreT9oY2lBtE5PzOFbxddCJNASt1y52vdU6iGUAHo+?=
 =?us-ascii?Q?ZjRky7RDNlK6pvlctCLS8OuZ6ub0BYYFm7qVShv1D/LmPiBJGlhX12ftx5+F?=
 =?us-ascii?Q?t7IK8aZZibHz71S3COPiJxO0znXHJBPWN/2lQZbihGNapJJEKduC9jkhjvgd?=
 =?us-ascii?Q?hMcg66KcO/ocDtmrmpL1wYYIzMN2U9chUEtdEAO1/jqdcn+eOY9oFeQcGw7D?=
 =?us-ascii?Q?RjXGLANQ7cgNH2LxX4BMm0tX5VYqrOaabBCJ3gnXIAbwdtEc8x++PAF2vqLE?=
 =?us-ascii?Q?2+7mdb4Kg6yjBiuikYucnUKgnmV4uaRc4P86vr12PhietYRlfkK68h3wVLq4?=
 =?us-ascii?Q?EgORomffFL1tyL/VCSb+WRuEvap+cM9XyKMDW3vBPSE5LiQBtOfzQy0rku7M?=
 =?us-ascii?Q?8OvF1F6SqNKUUg9pW4BTAhtbOvPbVYTaX2BCEEVnLQj9KN9/YrggASZ42wzg?=
 =?us-ascii?Q?Am2XhrAeUOp6BtXrx2k4Y/ghGy8TH/4F9Zw/HuoNJxWmP/b0wEYL3ESshX1a?=
 =?us-ascii?Q?AyPSVPGQBPUyUYwkKTVk7MoORLaal9AlfaJF5VSmZQsdNgkBFCAQr/3K66uk?=
 =?us-ascii?Q?fDTzgrrxu3BD4VhGusW69wVg5yxjdBZxMk4qM3RPPCrDVPwHwaLnx5QXYGuW?=
 =?us-ascii?Q?x/JQ2nANVNJG9ghr3FRY5UoTDfNTfvyaoAAPogVsPPq1yjWqBdysSvTj9k6J?=
 =?us-ascii?Q?q5fzq+P/yTDCneGDY17COxqzh1E0Kt6HEI7D9wykOqQeVq9Y76SaHB12PqRv?=
 =?us-ascii?Q?QjTyUybldpo6eKbUFvhIaLO9kBO/tPb40tR+rpEapzZbbWbJanZH1G6N5b6q?=
 =?us-ascii?Q?fTebZi9tQcY6FtEzDkdGcP8iD6GiCVtf2houVJNc4E0z655wwPbnmSGhOTku?=
 =?us-ascii?Q?kYU3xVp8DVluFUl0/xww0rzAqtZYslW/osfVcNHKvPtLFGso1JA61+xb6H/X?=
 =?us-ascii?Q?Zx7ML+fboJTBGoS6K/58Gw6MQDh7T/OFbyJ8wLM8sDNu5K+ywPpiYbTD58iM?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25710e71-feb2-47ce-fe06-08db363512d2
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 00:22:58.2021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LTouVSRdWLyPiFow98+stG8WxGo5brfL2mNU0rwAyIP4YvHRqKhQ/p/QcoMxM+adIDFo3k2BpnXbT0Cx6lvLRPhV5nM+dm4tpBE/VULCuLU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7883
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dan Williams wrote:
> Rafael J. Wysocki wrote:
> > From: Kees Cook <kees@outflux.net>
> > 
> > ACPICA commit 44f1af0664599e87bebc3a1260692baa27b2f264
> > 
> > Similar to "Replace one-element array with flexible-array", replace the
> > 1-element array with a proper flexible array member as defined by C99.
> > 
> > This allows the code to operate without tripping compile-time and run-
> > time bounds checkers (e.g. via __builtin_object_size(), -fsanitize=bounds,
> > and/or -fstrict-flex-arrays=3).
> > 
> > The sizeof() uses with struct acpi_nfit_flush_address and struct
> > acpi_nfit_smbios have been adjusted to drop the open-coded subtraction
> > of the trailing single element. The result is no binary differences in
> > .text nor .data sections.
> > 
> > Link: https://github.com/acpica/acpica/commit/44f1af06
> > Signed-off-by: Bob Moore <robert.moore@intel.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Unit tests say NAK, though.

This causes a regression, but I think I see where. Will send a fixed
patch in a bit.