Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 17:36:58 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>,
        Kees Cook <kees@outflux.net>,
        Dan Williams <dan.j.williams@intel.com>
Subject: RE: [PATCH 23/32] ACPICA: struct acpi_nfit_interleave: Replace
 1-element array with flexible array
Message-ID: <642e142a34d9f_21a82942d@dwillia2-xfh.jf.intel.com.notmuch>
References: <4845957.31r3eYUQgx@kreacher>
 <2652195.BddDVKsqQX@kreacher>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2652195.BddDVKsqQX@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pn0QnNJzsuxGoCmKVEDciBC6WdJZm5kdR6M3eF+FJlqKcb7cqiVCabs7FI6K?=
 =?us-ascii?Q?V2JtGplCe3ftvdcIvE/09kR8G9usxsYO5MwU9L7gA7OPNRGGEV6/bQtLSUnl?=
 =?us-ascii?Q?PBCw30CFQ9J/n4P6cMlJpYCi9RzqBjj0o8/iBm5p096MnsgOCYl5oMhVMRoZ?=
 =?us-ascii?Q?YqYjL1jBsWMC3fHDvC+OMOjaGYW27mU0RmztPF0CY+VKzalQuEnP+rMwhRpP?=
 =?us-ascii?Q?GHQeM9lJLMsrMD7/OtT4c+241SojRZ4y3bVfiUcXBuj5/GCuaNPXjJHRKxGP?=
 =?us-ascii?Q?RmBgXX2A8TpAjluA2pPXJ/DaiYv3wxHP4JpVq1qY6bbIUhDNIyDTr/hz4KKF?=
 =?us-ascii?Q?TIHmIVHviQId1Q92zqbES7YW/8uQ37dwNvUSbr3ejUueRY1EupqjkEWEJrGu?=
 =?us-ascii?Q?cMABwRrXOsZXJO3jJ5u5csaeCuEaBsoDYuC2Zd9KkTNWkibQx9faVbC1p1Ea?=
 =?us-ascii?Q?b1mfAftwKNeQy7gXy7ko/xfggDbgmgwIkkhudrdjYDUFnYD1FkEDu+1hWO3w?=
 =?us-ascii?Q?6GyuWZwecs8JVwC93+CvhaRXv1lw+pguEuFlZZq3dqtSI9sjv9VwfFPLMbFP?=
 =?us-ascii?Q?kyfVPUYqILlB0Ro+pfebTcPQqyXdAdPzLwPftPxa2hwaNSIcV9vLuvRojyDw?=
 =?us-ascii?Q?vyO8E/iBN7LJBJ8CRkI3ip3YKbrTMYpWUdIauSwxsmkTm6/Lrj7j75NfgML1?=
 =?us-ascii?Q?t2PHQgocsWc010HU4xYV/Vsq3xnyp2AuZn5ubl5g7nz9lj9e0btuPiHJT8Pe?=
 =?us-ascii?Q?/wcz/fE10gZ59CDCYNOcB4YePw5v0AzhnGXgkMJC2vXf2P11sEOjjunlNZGU?=
 =?us-ascii?Q?E1x/xqMeTwBRvw1wlT/kqkwqicPW8q+z/kD2lvK7xU7d/9SOquvaoQkp2tR6?=
 =?us-ascii?Q?edTtEiaKPjFvP30d28m2f+oNB7WErYQVfG0+S3CJnA+8t42mzJgrcYRJizIA?=
 =?us-ascii?Q?TZAt9RnA3N2ah1c6u7K1Jmu4Zg0+zLT2yqTlYNV9IwxE1h3WUUOPwDUC1az7?=
 =?us-ascii?Q?cbky6Yknh99Eu046GROr+bTgvNjZOd/HS95LsBEo3+8Jf/5OsT6mGKiBHlI2?=
 =?us-ascii?Q?Wwx9/FGtdOUHJBFxCgSW6S9xayj9geVYVE8/qkFddfBKnoirZNt8OGuxsrmX?=
 =?us-ascii?Q?FbjsNiafIK3SpJLyw+eUKXmuyIs+dFDI/mZfnKhzh6IC3pmI5YVczyIZdXoc?=
 =?us-ascii?Q?Sx2oG1zwpsgvs2/eMrFk3qDJXQilcmPWFSHbL6wOBJMJGufyBARTpTpxcC40?=
 =?us-ascii?Q?O+/muRjjxapJXpU7sZQxGnm5hJxVa2bxhc1iaxTGlJ+5BxImb0R+KhRdO9GI?=
 =?us-ascii?Q?VVUdO39nJSZ+Y6qF91KQF8FW9305QXCsWgNAn+iPAwj+cDvD22eM58Z9RF3B?=
 =?us-ascii?Q?Ql66DSUWcsPvYLo2r34nIVUupE5mBZHZK8Q6/WoOMwnB8KiB4tVyXCNGzpK6?=
 =?us-ascii?Q?GTthwU9Ir8hq9Isht7lNJnT9+ccENgV8+YodbR0ONuVvvktuyshuqaktLpUm?=
 =?us-ascii?Q?VAUE3OHoqHj+NtDsftdMtBl2If+N7bgqg6Jlf9fVcHuQ5+dZjX9mbz0Lir36?=
 =?us-ascii?Q?vjB/d5ZNKpydKX2ShVnMx7FqtLermw/7KgekdUn1KA3TojM6B4BB5jh1LDqY?=
 =?us-ascii?Q?PQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9713fc16-3a7e-4c69-e4e8-08db363708b7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 00:37:00.2024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fL2S9c8alRhJsACUkVeW8SPGaV6SkyRhP2YkW3ksZOZq3icoo1+ZTv7NxO/FdbvFmAN1IxwyLS49y/kGy1lKHVDKqWBtDzoQOs2et2eCp3s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5466
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Rafael J. Wysocki wrote:
> From: Kees Cook <kees@outflux.net>
> 
> ACPICA commit e66decc6fca36b59194b0947d87d6a9bec078bc3
> 
> Similar to "Replace one-element array with flexible-array", replace the
> 1-element array with a proper flexible array member as defined by C99.
> 
> This allows the code to operate without tripping compile-time and run-
> time bounds checkers (e.g. via __builtin_object_size(), -fsanitize=bounds,
> and/or -fstrict-flex-arrays=3).
> 
> Unlike struct acpi_nfit_flush_address and struct acpi_nfit_smbios, which
> had their sizeof() uses adjusted in code, struct acpi_nfit_interleave did
> not. This appears to have been a bug. After this change, there is a binary
> difference in acpi_dm_dump_nfit() since the size of the structure now has
> the correct size, as the prior result was including the trailing U32:
> 
> -       mov    $0x14,%ebp
> +       mov    $0x10,%ebp
> 
> Link: https://github.com/acpica/acpica/commit/e66decc6
> Signed-off-by: Bob Moore <robert.moore@intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Dan Williams <dan.j.williams@intel.com>