Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 17:43:13 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Kees Cook <kees@outflux.net>,
        Dan Williams <dan.j.williams@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>
Subject: RE: [PATCH 22/32] ACPICA: actbl2: Replace 1-element arrays with
 flexible arrays
Message-ID: <642e15a1ce95b_21a8294cb@dwillia2-xfh.jf.intel.com.notmuch>
References: <4845957.31r3eYUQgx@kreacher>
 <14903668.tv2OnDr8pf@kreacher>
 <642e00331b335_29cc294b0@dwillia2-xfh.jf.intel.com.notmuch>
 <642e10dfc46d8_21a829451@dwillia2-xfh.jf.intel.com.notmuch>
 <F03AC35F-764F-45AC-A18E-F9BBBF172D4A@outflux.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <F03AC35F-764F-45AC-A18E-F9BBBF172D4A@outflux.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PqqAKhKtbn9BVZugLNy8AjJDl42hm8kqrBV+QcrXUr0FnNNh6x2rkJWj8Ban?=
 =?us-ascii?Q?MldhMnXej23sbcGiswEnisNCo3QTSDo+g7wEiQSN3e+F4abjA180BM39pe29?=
 =?us-ascii?Q?KfO+guDevDscoUIRMgqtrDEjLZ4ZNFAhKkz6ww5uS5y9FCtcjGOGhZ664bvd?=
 =?us-ascii?Q?fENaF/yFW9qgZO9EP0eGpMhHWAW8kPbfzuk5NZlO9lc7cbQF88xoEG2aCEFu?=
 =?us-ascii?Q?FVGsRYs6oJW/c1MuMyQg5ZDx3ZE//thl4ozMlq2B0I6SlZqJsUW/cY3KXmjN?=
 =?us-ascii?Q?rru2IGa6B1kgzaF865r0RGTBktX0gy3owO35K4QDkNTV215AglW3TKhKXwju?=
 =?us-ascii?Q?lmJQ0iqpvWWyU04g/OlW/Qirdk6IlPEXX+htUaSnkdQamsJa0dt5lRM1Ah2A?=
 =?us-ascii?Q?kp8uEQr7wk4aC6aDmHDof+BOr/GR8VOcRbi2JIK++tGKYusrcwAkmBsvf4NH?=
 =?us-ascii?Q?SsbtqfRjgdQ7cM5sApkRky4l4YXhcVsAMlBy/vdbRyk9Bbj1z7Aq5wlebtTH?=
 =?us-ascii?Q?BVc/NR9uAytAOQRM+pu5MTXJtXvp120DzUWjyIOdsGTKR5sHYXfybD4JmsHD?=
 =?us-ascii?Q?bxS/erLHh6kj/b0cFuq2kYw4dEubAGts52Jt9ZdenHCSkeG7qOz9Wo5LLGXk?=
 =?us-ascii?Q?IAcX+73pcLBAjXoyMEsVQUwCcxmhubpXUbyoEfbOTCvMm9/H+/oYZzIWlXcX?=
 =?us-ascii?Q?WywdrO9f8AUHPob6qtoMCgFH7JwvVsqOd8Ipj1YdZB94DzaCB4rmeBJlbL+J?=
 =?us-ascii?Q?1m+TLB7DN0d8mT5SDHTJX12B5NCnUy55taLabxT913dZT3QmLC4fTZYmO8vN?=
 =?us-ascii?Q?l+yJZUq+gSe3LfRaoKkAid5QkLdZ7YDiQcHv3bJk66w6oatb0Fx8HUgAc094?=
 =?us-ascii?Q?vjGmonbEgcXcNK0EH3A0sa5fyaH1VRaVdqoq5C4sb9/hTTl+eyDpwMg3jtvG?=
 =?us-ascii?Q?jiHxccLibfFWa296PTK8iSqOSyJIihu59pmBHd3nezBsrW0j7SvN62/3+CDR?=
 =?us-ascii?Q?kzrrx+TrbFeTgBVnghLv8sbblo+MXr5GE2ti/e6MmFKgHyY3IGpNfnIQ6Jqg?=
 =?us-ascii?Q?zM3uP13G3C46wGe+LNEsmwPuHxRdqHPL1ZivkndEQw9UGQFCahGsI3EDv2qq?=
 =?us-ascii?Q?iEzioUecdS32Uip3mKK06Appn0DsAEH16vaeGp/vNekqPVDYFKC9qJcSJYzm?=
 =?us-ascii?Q?0b8XQ71sisc88penXoWqbTaPnTRpg5bvy3I+R7zSKuniKuqUm31xhgyvJHb2?=
 =?us-ascii?Q?ZaMfZpo6RDjuWVI8EYXB8pgOpi+SnUHAVzQDvsyCn4pehqStHk1kNYg/ylJN?=
 =?us-ascii?Q?QeZ0hb0bkRc9WDSWIPT6GSV4kjOIaiCEGeKuT3Y+LjyFNnPpzCQOVtxPB/cF?=
 =?us-ascii?Q?xLLFiIgAeVCmybxX/O/oRuxyfZcZAoiH9Lg2pOUxKHquq/ibVtlqqzz+JqJi?=
 =?us-ascii?Q?DerZc32S1AqgI4lux3K+epDksP9CoZnAmmIa1GMa6cGTOWXLkxdG6udGJJD8?=
 =?us-ascii?Q?5chc+2YF7grhgZR4Rz0cNSbKTSKWFwS1DcRiSB7Pr6bLBoVwzYdwWo8y0xe/?=
 =?us-ascii?Q?3SeKcODH6iJIjNMpW02S08K86Dtxk1vhfReCd2kDPsB9qOiIPZT50VxvJPX1?=
 =?us-ascii?Q?WQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 72e5697e-ab35-4b77-4c6a-08db3637e8c3
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 00:43:16.1001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QBTp0yCppnq4hBGn3PxE2IoqNL6qLBNSrZPHnvXnKLTFOFvN9VjpQFNPssxzJpCcFGE34zIPbfYeUzXlWFMFGAsqAjldK0SUj9bFgb93ERA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6388
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Kees Cook wrote:
> 
> 
> On April 5, 2023 5:22:55 PM PDT, Dan Williams <dan.j.williams@intel.com> wrote:
> >Dan Williams wrote:
> >> Rafael J. Wysocki wrote:
> >> > From: Kees Cook <kees@outflux.net>
> >> > 
> >> > ACPICA commit 44f1af0664599e87bebc3a1260692baa27b2f264
> >> > 
> >> > Similar to "Replace one-element array with flexible-array", replace the
> >> > 1-element array with a proper flexible array member as defined by C99.
> >> > 
> >> > This allows the code to operate without tripping compile-time and run-
> >> > time bounds checkers (e.g. via __builtin_object_size(), -fsanitize=bounds,
> >> > and/or -fstrict-flex-arrays=3).
> >> > 
> >> > The sizeof() uses with struct acpi_nfit_flush_address and struct
> >> > acpi_nfit_smbios have been adjusted to drop the open-coded subtraction
> >> > of the trailing single element. The result is no binary differences in
> >> > .text nor .data sections.
> >> > 
> >> > Link: https://github.com/acpica/acpica/commit/44f1af06
> >> > Signed-off-by: Bob Moore <robert.moore@intel.com>
> >> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >> 
> >> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> >
> >Unit tests say NAK, though.
> >
> >This causes a regression, but I think I see where. Will send a fixed
> >patch in a bit.
> 
> Ah, which tests? I must have missed something!

You're doubly forgiven for not running them because 1/ they typically
require setting up a VM, and 2/ they've been broken since v6.3-rc1 due
to where the test modules moved.