Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 05 Apr 2023 17:37:01 -0700
From:   Kees Cook <kees@outflux.net>
To:     Dan Williams <dan.j.williams@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Bob Moore <robert.moore@intel.com>
Subject: =?US-ASCII?Q?RE=3A_=5BPATCH_22/32=5D_ACPICA=3A_actbl2=3A_Repla?= =?US-ASCII?Q?ce_1-element_arrays_with_flexible_arrays?=
User-Agent: K-9 Mail for Android
In-Reply-To: <642e10dfc46d8_21a829451@dwillia2-xfh.jf.intel.com.notmuch>
References: <4845957.31r3eYUQgx@kreacher> <14903668.tv2OnDr8pf@kreacher> <642e00331b335_29cc294b0@dwillia2-xfh.jf.intel.com.notmuch> <642e10dfc46d8_21a829451@dwillia2-xfh.jf.intel.com.notmuch>
Message-ID: <F03AC35F-764F-45AC-A18E-F9BBBF172D4A@outflux.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Envelope-To: robert.moore@intel.com
Envelope-To: linux-kernel@vger.kernel.org
Envelope-To: linux-acpi@vger.kernel.org
Envelope-To: rjw@rjwysocki.net
Envelope-To: dan.j.williams@intel.com
Precedence: bulk


On April 5, 2023 5:22:55 PM PDT, Dan Williams <dan=2Ej=2Ewilliams@intel=2E=
com> wrote:
>Dan Williams wrote:
>> Rafael J=2E Wysocki wrote:
>> > From: Kees Cook <kees@outflux=2Enet>
>> >=20
>> > ACPICA commit 44f1af0664599e87bebc3a1260692baa27b2f264
>> >=20
>> > Similar to "Replace one-element array with flexible-array", replace t=
he
>> > 1-element array with a proper flexible array member as defined by C99=
=2E
>> >=20
>> > This allows the code to operate without tripping compile-time and run=
-
>> > time bounds checkers (e=2Eg=2E via __builtin_object_size(), -fsanitiz=
e=3Dbounds,
>> > and/or -fstrict-flex-arrays=3D3)=2E
>> >=20
>> > The sizeof() uses with struct acpi_nfit_flush_address and struct
>> > acpi_nfit_smbios have been adjusted to drop the open-coded subtractio=
n
>> > of the trailing single element=2E The result is no binary differences=
 in
>> > =2Etext nor =2Edata sections=2E
>> >=20
>> > Link: https://github=2Ecom/acpica/acpica/commit/44f1af06
>> > Signed-off-by: Bob Moore <robert=2Emoore@intel=2Ecom>
>> > Signed-off-by: Rafael J=2E Wysocki <rafael=2Ej=2Ewysocki@intel=2Ecom>
>>=20
>> Reviewed-by: Dan Williams <dan=2Ej=2Ewilliams@intel=2Ecom>
>
>Unit tests say NAK, though=2E
>
>This causes a regression, but I think I see where=2E Will send a fixed
>patch in a bit=2E

Ah, which tests? I must have missed something!

Thanks for digging in=2E

-Kees


--=20
Kees Cook