Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 3/8] ext4: fix wrong unit use in ext4_mb_new_inode_pa
To:     Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230321161220.418652-1-shikemeng@huaweicloud.com>
 <20230321161220.418652-4-shikemeng@huaweicloud.com>
 <ZC3LXYKjp5zwYfO1@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
From:   Kemeng Shi <shikemeng@huaweicloud.com>
Message-ID: <72df8e87-6798-20f0-2524-b6430f1b3846@huaweicloud.com>
Date:   Thu, 6 Apr 2023 09:36:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <ZC3LXYKjp5zwYfO1@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 7bit
Precedence: bulk


on 4/6/2023 3:26 AM, Ojaswin Mujoo wrote:
> On Wed, Mar 22, 2023 at 12:12:15AM +0800, Kemeng Shi wrote:
>> fe_logical and win are both in block unit. Remove wrong convertion for
>> win from block unit to cluster unit.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>>  fs/ext4/mballoc.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index 7f695830621a..86d978e1f7dc 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -4640,8 +4640,7 @@ ext4_mb_new_inode_pa(struct ext4_allocation_context *ac)
>>  		if (offs && offs < win)
>>  			win = offs;
>>  
>> -		ac->ac_b_ex.fe_logical = ac->ac_o_ex.fe_logical -
>> -			EXT4_NUM_B2C(sbi, win);
>> +		ac->ac_b_ex.fe_logical = ac->ac_o_ex.fe_logical - win;
>>  		BUG_ON(ac->ac_o_ex.fe_logical < ac->ac_b_ex.fe_logical);
>>  		BUG_ON(ac->ac_o_ex.fe_len > ac->ac_b_ex.fe_len);
> 
> So this bit of code is removed in the patchset I sent here [1]. My patchset
> is mostly ready to be merged and Ted did mention that he was going to
> pick that up soon. So would it be okay with you if we drop this particular patch?
Sure, I will drop this in next version.
>>  	}
>> -- 
>> 2.30.0
>>
> 

-- 
Best wishes
Kemeng Shi