Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1537994rwl; Wed, 5 Apr 2023 19:45:44 -0700 (PDT) X-Google-Smtp-Source: AKy350YR5LK3hyNVS+N4Em/C9WwiHScs/jJjjojwfu+YOMkb5TWiE2B1YRLdzRkajFwVUc+Tngkt X-Received: by 2002:a17:90b:2543:b0:230:b0e3:9cad with SMTP id nw3-20020a17090b254300b00230b0e39cadmr4535322pjb.23.1680749143813; Wed, 05 Apr 2023 19:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680749143; cv=none; d=google.com; s=arc-20160816; b=r54l0N8qfANolng5W/tBBFqN77dkpWlk6RlgTYVnoUUf0JEwayLfRLSRK5fOEmBTYC peDH3DBeJJkFJ0guMoDblxzKVsFonrOoHNcYVaB70IERZcyOBLA4ND+FvtOM+Uh++rxH Af2Jc0sYrBmDY3PCgT5+9vI+L/JyRWY9/zJi4wU9nLQh0RDINuQzZ2y3rq/7+VOfueRw CLPvpxgrDsk5pNJ5aWF3H4D+uAt+o8LWIM8BNFS16vihqJMJ4rwK0Pf9ZWWEpzRYIG5K HirOTQ/RgfO77d9IlgmBKzPUx6VzcordVxDqqqyF5BTtu8Y5L2HcXufAuHEyjHkitl9x G1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7ssWblcSDEtP5/IbtmhTlYPoFgkRPg3gz4Y2wx4xj5A=; b=ggioU3hocLWq+uY6HA51586WXATfNQNLyABAu2riwgFPRUgmvwDmvkkvx8kknu2WmO J7KNehU1sAosr2A6/ADxrJYUKkS9a/VHxTWds1vN0uctD590gvr1D8dgWg0oN245XNWf jtG+CtmF23F6Fh1JDl1EsXLAf+n+9+oWlylUx5W0v0Sf/ahhVZULAkRtySzUQuy/xBLx 5ERQH7xijyPlCmuP+tJaC6/5sP2wmwvlMGxyl/0dyQCgTcp78gpDpV9R1DPccOcdLfuD DKlXMIMtOwvGFWGAoKkmaI9evA6AWuJQAb5SYHxHdrq9R5gY3IxA6QxhC++LNeSpenoy g/Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a17090aba8b00b0023e4bc7272dsi2694862pjr.171.2023.04.05.19.45.31; Wed, 05 Apr 2023 19:45:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234949AbjDFCna (ORCPT + 99 others); Wed, 5 Apr 2023 22:43:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234867AbjDFCnY (ORCPT ); Wed, 5 Apr 2023 22:43:24 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F5FD86B6 for ; Wed, 5 Apr 2023 19:43:23 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=ziqin_l@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 3362g2eK004176-3362g2eL004176 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 6 Apr 2023 10:42:09 +0800 From: Ziqin Liu To: Matthias Brugger , AngeloGioacchino Del Regno Cc: Ziqin Liu , Dongliang Mu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] soc: mediatek: mtk-svs: change the function IS_ERR_OR_NULL() to IS_ERR() Date: Thu, 6 Apr 2023 10:42:00 +0800 Message-Id: <20230406024200.3126080-1-ziqin_l@hust.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: ziqin_l@hust.edu.cn X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nvmem_cell_get() will return an ERR_PTR() on error or a valid pointer to a struct nvmem_cell but won't return NULL, the check function should be IS_ERR() instead of IS_ERR_OR_NULL() Signed-off-by: Ziqin Liu Reviewed-by: Dongliang Mu --- drivers/soc/mediatek/mtk-svs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index a7eb019b5157..8127fb6d587b 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -1726,7 +1726,7 @@ static int svs_get_efuse_data(struct svs_platform *svsp, struct nvmem_cell *cell; cell = nvmem_cell_get(svsp->dev, nvmem_cell_name); - if (IS_ERR_OR_NULL(cell)) { + if (IS_ERR(cell)) { dev_err(svsp->dev, "no \"%s\"? %ld\n", nvmem_cell_name, PTR_ERR(cell)); return PTR_ERR(cell); -- 2.25.1