Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1594327rwl; Wed, 5 Apr 2023 20:58:32 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1DBQ7FNxvStgQSua2ZpFR9IweeScDsts3imOTkspicSO7fLv8HU3LUszZ+SCT4sp2NhSB X-Received: by 2002:a17:906:b317:b0:93a:6e9c:262e with SMTP id n23-20020a170906b31700b0093a6e9c262emr5174256ejz.23.1680753512183; Wed, 05 Apr 2023 20:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680753512; cv=none; d=google.com; s=arc-20160816; b=m+hdOZiDjSSjWnM6bhhHgGvKqCax0HmsEXlBA+EhOogSQ3tLBELIRD0eyEdNHNewpr 627+427EgiwUJLhWEF9+AOJ+vPLaKw0aUIwwL/iU/z2dg8G7OCqEFxEWABrUF0ib25hu Vf+CwqHx74FNsPEgVoZWJsUcXrlMKGeRc3NoQj1H6+OhyxocejqtRwKuhRzEIoMxn7Nk a0Evp/BKbQjx2cq8UXP5zpJQ/d6VlPxtXz/BwlT8Cdkf5kfXffVRHm5Uvj60gMoMquqg grmJOF50QBL1B8A6z4kXQmgr3D15lC+01l2KpKFSU809vRz1lKYgSZofVyQRhPXQLdye 3uEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:to:subject :cc; bh=f1xRpIDHNsj3wg4/vQXkPjbG2TgnxGchj1fU3PQ66ws=; b=ekp7Rl7yipI/MBAMFYhjiLsldT4h+bcuizD8MsLlJwn8PHZb7uNemD2cVWh8bqUXnR pC4ufRrt2/xtPMG3qXo3lGDw8htGMNyy/0c2bB0/uslCDoWXE1XSZ4BxEGft4put29zk li07i4zg+LxSe/wUfyWgg3N/TOWBKnniqcQumtDFI2c8kbMvN0GeyaO1OTLduoTzhIdf Hn8Sq8SCMeqz0OzHzKK29bLzHcfoETB/OtkjcvCMaSZTNPMQjyiYIJj6sZmrsIGBrARk RRbjVKTtf/xL+yw7/K3yLuqjTOQYB4gPErstX8YMXPuOujSs1DUzNCH6c53zGybeVpqX qXcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di22-20020a170906731600b009498810ba68si528441ejc.435.2023.04.05.20.58.07; Wed, 05 Apr 2023 20:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235031AbjDFDz7 (ORCPT + 99 others); Wed, 5 Apr 2023 23:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235030AbjDFDz4 (ORCPT ); Wed, 5 Apr 2023 23:55:56 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85242449A; Wed, 5 Apr 2023 20:55:55 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PsSJx5pCKzKx2D; Thu, 6 Apr 2023 11:53:21 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 6 Apr 2023 11:55:30 +0800 CC: , , Dan Williams , Shaokun Zhang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , , Suzuki K Poulose , Liang Kan Subject: Re: [PATCH 32/32] hwtracing: hisi_ptt: Assign parent for event_source device To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , , , References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-33-Jonathan.Cameron@huawei.com> From: Yicong Yang Message-ID: <066e107f-57a0-1277-e391-844e668b6d2a@huawei.com> Date: Thu, 6 Apr 2023 11:55:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20230404134225.13408-33-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-3.7 required=5.0 tests=NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/4 21:42, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the PCI device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Cc: Yicong Yang > Cc: Suzuki K Poulose > Signed-off-by: Jonathan Cameron Reviewed-by: Yicong Yang > --- > drivers/hwtracing/ptt/hisi_ptt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c > index 30f1525639b5..3868d43e9e3c 100644 > --- a/drivers/hwtracing/ptt/hisi_ptt.c > +++ b/drivers/hwtracing/ptt/hisi_ptt.c > @@ -871,6 +871,7 @@ static int hisi_ptt_register_pmu(struct hisi_ptt *hisi_ptt) > > hisi_ptt->hisi_ptt_pmu = (struct pmu) { > .module = THIS_MODULE, > + .parent = &hisi_ptt->pdev->dev, > .capabilities = PERF_PMU_CAP_EXCLUSIVE | PERF_PMU_CAP_ITRACE, > .task_ctx_nr = perf_sw_context, > .attr_groups = hisi_ptt_pmu_groups, >