Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1603319rwl; Wed, 5 Apr 2023 21:07:58 -0700 (PDT) X-Google-Smtp-Source: AKy350bEr+CC7Ki3IfDZOxJI8P5fM0w6m3yXBNpS+s37Dgb1o81XMf+xZCXYzZ22SYlJ0kq/zHno X-Received: by 2002:a17:906:8056:b0:884:3174:119d with SMTP id x22-20020a170906805600b008843174119dmr5978759ejw.14.1680754077826; Wed, 05 Apr 2023 21:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680754077; cv=none; d=google.com; s=arc-20160816; b=SvtbmsGBG+iMTBqbfr8BbBYbUjZvULSjkU3+HTvPlTSov0LtSvH9CH3evabfNnGIT4 Iecr8w01t4RpKrA9bQ2LFZ+SCaCDipaxKBUDJHxnM5/sSJoLUn63qnX7kQ0TRa/MWAYM KPo+W8P1WYdbFlXrGK/IxFrjsTzrzqYvL8n3lqtwvJ/Z7sxxqEUEUNFTaNBYKH62uy1r Wc8J5G5Apd7ipz9kX7GjV2ksLzyvq1QXcwryZOYv+xeBx7r7WLuDnvXOpu+A4aHCBhAk u65Un7Ttq/iicdn/QTvtZHyR2wayES9ef1f5/JmR/SVH1S4OkzCpPoFs91r53bjaZHED DG7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:to:subject :cc; bh=BaX6+moPXEqDEGrN+lh05cRWylNBg3YskHb/LTy7N14=; b=Jum4M62O0q6LowAUC8GILbAZGuczwMLbhQ7LLAGE0mi6rX1dQ/X46yYKT3LEflgHMx zneXB5kgznwJEJ/K3Nh0dV8vczRBWDNeE5RC9ATnFeMZ5mwq6tUSwY6pqcj9hPuDRW5l 71qvVGLwSy2yOdWH/AgHM6jogsYrHyy1CTCCk/zORyLsIJEFonNDrKdd4f4SRWtre6c6 YtwNOmKIi5cTDxh5crvKLMZkwNVzN8ofpH9jtU9cTBFj6RPHHptI0/oYvyZE4xfvGSV7 dXsLpZXrYTFEmY4RBCpkJuqJhdE75GjtFVRBnrq5n/98uGHzzsNWGhnwQ+Kt3nwbWliH 1Eyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020aa7c597000000b004fd298d2f99si281778edq.492.2023.04.05.21.07.30; Wed, 05 Apr 2023 21:07:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235130AbjDFD6F (ORCPT + 99 others); Wed, 5 Apr 2023 23:58:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235045AbjDFD6D (ORCPT ); Wed, 5 Apr 2023 23:58:03 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 565339760; Wed, 5 Apr 2023 20:58:02 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PsSKw0VcRzSqkp; Thu, 6 Apr 2023 11:54:12 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 6 Apr 2023 11:57:30 +0800 CC: , , Dan Williams , Shaokun Zhang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , , Suzuki K Poulose , Liang Kan Subject: Re: [PATCH 04/32] perf/hisi-uncore: Assign parents for event_source devices To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , , , References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-5-Jonathan.Cameron@huawei.com> From: Yicong Yang Message-ID: <233516c4-be85-ec0b-e586-bb1c5f78a9b5@huawei.com> Date: Thu, 6 Apr 2023 11:57:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20230404134225.13408-5-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-3.7 required=5.0 tests=NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/4 21:41, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the platform device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Signed-off-by: Jonathan Cameron Reviewed-by: Yicong Yang > --- > drivers/perf/hisilicon/hisi_uncore_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c > index f1b0f5e1a28f..b4350e5dc3fc 100644 > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c > @@ -538,6 +538,7 @@ void hisi_pmu_init(struct hisi_pmu *hisi_pmu, const char *name, > > pmu->name = name; > pmu->module = module; > + pmu->parent = hisi_pmu->dev; > pmu->task_ctx_nr = perf_invalid_context; > pmu->event_init = hisi_uncore_pmu_event_init; > pmu->pmu_enable = hisi_uncore_pmu_enable; >