Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 13:03:28 +0800
From:   Pengfei Xu <pengfei.xu@intel.com>
To:     John Fastabend <john.fastabend@gmail.com>
CC:     Eric Dumazet <edumazet@google.com>, <linux-kernel@vger.kernel.org>,
        <ast@kernel.org>, <heng.su@intel.com>, <lkp@intel.com>,
        <linux-gpio@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <yi1.lai@intel.com>
Subject: Re: [Syzkaller & bisect] There is WARNING: refcount bug in
 sock_map_free in v6.3-rc1
Message-ID: <ZC5SoIRIFJpSpivX@xpf.sh.intel.com>
References: <ZAdMB+eGT3TQEo7y@xpf.sh.intel.com>
 <ZAdVvximUvRXcGZZ@xpf.sh.intel.com>
 <ZCvusEIauvO8BLM5@xpf.sh.intel.com>
 <CANn89iJjqTyev28kzEwBjoNafn_4Ku3ZijJxQ_+Tc93TaG3D=g@mail.gmail.com>
 <ZCwujl7qJPvMsHKv@xpf.sh.intel.com>
 <642dea024554c_1ab91208f4@john.notmuch>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <642dea024554c_1ab91208f4@john.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmxJYzM0eGZUWXlQVkFDL0oweEpaRjN0NkhCZktSYjNSdi9ickltZkNJaSty?=
 =?utf-8?B?UVpSTEJHZXEyYUo4QWx3VDBjK0QxRWViNkI5NU9ad29BWmZvQlg0TXNPZGlV?=
 =?utf-8?B?WGcvMzl2UEViSExreVpGZzZKeGdUcURzbm5Ta1FpOVNTMjEvbWxpT0JBN0Vl?=
 =?utf-8?B?dy92WjFham9RNDBiZVJRemw5WHVsVk5SMnE2M21HQWxacHErRWU2c3VLZ21J?=
 =?utf-8?B?TVV5WUFSYnhGQWJ0c0pYak40ZGw1TVZxZWRWQmRzQ1lSRFpHOHRlazhBZkl1?=
 =?utf-8?B?TlVmckgvSERJcVBJejhuZnpLVDF1TFhUc3ZPQUUzT2gwTnlaWFdiNDBQVmg0?=
 =?utf-8?B?anNyZXVSWGtaNUJ1YnBFWWlXN0FEZVFPc3BOeXF1cC9xZTZDalN3U2ZTb0FX?=
 =?utf-8?B?RDJwQWJOR2dqMmVGOThmemhUKzF6SUNwRmJlaVVDdlFPbVY3b0xCMjlXTG9y?=
 =?utf-8?B?Mm9XOE51RDg1S21BUXo2Y29JLzUrVHpYQ0ZlV1JGRmVKVVZzOHF1ZHBRakk4?=
 =?utf-8?B?QngxRDV5QWdaOWNsZHh3YlI0eGNMeTJrVzRuU0pFMHl5SWM0M2VDSGhhcFhE?=
 =?utf-8?B?RWpOYmI4M2k5bUR6NFM4WmtXaVBRUVZ0RUp5TWUwL1NOSERrRitkRDBXUVBI?=
 =?utf-8?B?S045TEdBTlZiT1NQeXprZmtxQVAva0x6L2dMc1ovcXVHS0xoM1Rra2I3b0lN?=
 =?utf-8?B?ZXJNZitjSmorVU1QaHdVZzBEREtXa0wzU1M0T0dITGduUCtRaG92T3NCWmdh?=
 =?utf-8?B?ZU9TNldFazhJUGYxVHYzSG5EVnJpaEpOMDlaemVSYjBqVGNPc09Tdlo3b3lU?=
 =?utf-8?B?QmsvRkY1d2diQWFCSFUvVGJmNnRzWTUxMDVOY1gwTmlpbTg5bHZTWDk4WEQr?=
 =?utf-8?B?UG5iLzNhWlRpMm1JaFp5L3RPRjM0MWlpY1pJQ1p4NWc3ZDhjOEExbnArWENm?=
 =?utf-8?B?ejl2b21wK25hY2t3Q2szUm9uNWduVk5Yam5ncmQxSzhCQVlyamNDaEIvL256?=
 =?utf-8?B?cmdIMmI4Wk1adTZEMmpTWkc0aWNTOXEyRCtNd0pNR1RnSkZVNWc1ak5pMDN5?=
 =?utf-8?B?SzlieklUTG9aZWRodmVnVnNyL1BMMHFJck1qbzhONldpeTBYUTM1aDJPMmx4?=
 =?utf-8?B?elpNRjVxQ3BJYitPejVBYlovRXRobzRKVFlhZmg0eXQ1Uy9zeFVQZ0RhaFlv?=
 =?utf-8?B?aE4yM0llaDB2N0xvWFBZVnNLT3lQcUYyWW12cjFKcnRmNzNvZ2ZUVmUxTVNi?=
 =?utf-8?B?ajJKYklUNjF5bnMxY0lNZ25MZ0RRR2lpdk5EZmNLUnpyN2F1SXk0OWtGWVVj?=
 =?utf-8?B?c0lqamlaUkdEelZ4aW1kT0lLdG5zUWd2L0I1eCtJaFIwbEx2RHQzdXprcnN5?=
 =?utf-8?B?eFJOYmdsQlllVkpUQ2Y3dk9LRS9tS0hJeXFBelNlM1VXZ044cGJpTTZmSktw?=
 =?utf-8?B?WGk0UlVkT1U2NkRGbVNsdXVOYW53WVBPUmxLbE45NEdMWUh6YjFuRHV4eUg1?=
 =?utf-8?B?Z0ZUdzVISlVlT1VCSms0b1QxMHRFMUROUVhwZEU4a1htUnozbzBUeHZyOTFt?=
 =?utf-8?B?eEMvQWNzdHluOHYxeExVZWxkVmptWXN2RkxIbFIvbzgyRnZnTGFDYUFkUDBv?=
 =?utf-8?B?a0NlUGt0ZnV6VXBTNEtPUWg3RmNLTjNCN0crTGNJckxCVFRnaUFqYW4wdk1R?=
 =?utf-8?B?S3ZadmwycVVsR21YcVpXdm9NNG1GU2h3Tk5IdHNoaHFsWkRubGhPQjFwV0FO?=
 =?utf-8?B?Sk5IbEt5WVBwYkt6b0xmNkE0d3lISHo4OE4vWDBjT01jUzFCWGZRdGlQZkZI?=
 =?utf-8?B?Nk0wV2ZrMnpMa2crT2xzbHpCWnQ1RWoxYVlTUjlWc0FNZXg5N3ZzS1R1Smlr?=
 =?utf-8?B?eFRndFNiSU9CdGtya3dLelBXallObEZYRXRLNlR5Zk5Ea0R4R1AvQmZNVHJr?=
 =?utf-8?B?akNSRldvZi8yclZhSUhmd1VLRkl6Q3BBMG5zWE1TRHJJWUdQNENXWUx6MUVa?=
 =?utf-8?B?aWsvZGw0SUkwQVRVSzEvTzFSVUpqSzVtaGZ6VFV5UzFpU1NNeHNtV044OUhi?=
 =?utf-8?B?aHV1dDhkR3FJQlZtWFhTMGJQVXUwRGJLTDM0NFRvUXlETmdXNXpYQk1wbGpm?=
 =?utf-8?Q?4ahcu7dHlxMpnO2lyV61fAdqS?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb05afc-6487-4d0e-0736-08db365c09ef
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4839.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 05:01:53.6257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nKATZpC9BCmr9VAx6EtnFCecBnhDLnvqcI9PRiWw1KKCGRnIi/RYmLMbJz0sTqXIsmsFWxCytKgmn7v1K4fUFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7735
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi John,

On 2023-04-05 at 14:37:06 -0700, John Fastabend wrote:
> Pengfei Xu wrote:
> > On 2023-04-04 at 11:43:36 +0200, Eric Dumazet wrote:
> > > On Tue, Apr 4, 2023 at 11:31 AM Pengfei Xu <pengfei.xu@intel.com> wrote:
> > > >
> > > > ++ GPIO and kself-test mailing list.
> > > >
> > > > Hi kernel experts,
> > > >
> > > > It's a soft remind.
> > > >
> > > > My colleague Lai Yi found that similar "refcount_t: underflow; use-after-free"
> > > > issue still existed in v6.3-rc5 kernel on x86 platforms.
> > > >
> > > > We could reproduce issue from kself-test: gpio-mockup.sh easily:
> > > > kernel/tools/testing/selftests/gpio/gpio-mockup.sh:
> > > >
> > > > "
> > > > [ 5781.338917] -----------[ cut here ]-----------
> > > > [ 5781.344192] refcount_t: underflow; use-after-free.
> > > > [ 5781.349666] WARNING: CPU: 250 PID: 82496 at lib/refcount.c:25 refcount_warn_saturate+0xbe/0x110
> > > > [ 5781.359550] Modules linked in: gpio_mockup isst_if_mmio isst_if_mbox_pci intel_th_sth stm_core intel_th_pti intel_th_pci intel_th_gth pmt_telemetry pmt_class intel_vsec intel_rapl_msr intel_rapl_common nfsv3 rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs lockd grace bridge stp llc sunrpc intel_uncore_frequency intel_uncore_frequency_common i10nm_edac nfit x86_pkg_temp_thermal intel_powerclamp coretemp iTCO_wdt ofpart kvm_intel intel_pmc_bxt iTCO_vendor_support spi_nor mtd intel_sdsi kvm spdm irqbypass dax_hmem joydev asn1_encoder snd_pcm mei_me i2c_i801 spi_intel_pci isst_if_common idxd snd_timer intel_th i2c_smbus spi_intel mei i2c_ismt ipmi_ssif cxl_acpi ipmi_si cxl_core acpi_power_meter crc32c_intel i40e igb dca igc pinctrl_emmitsburg pinctrl_intel pwm_lpss fuse [last unloaded: isst_if_mmio]
> > > > [ 5781.438080] CPU: 250 PID: 82496 Comm: modprobe Not tainted 6.3.0-rc5 #1
> > > > [ 5781.449711] Hardware name: Intel Corporation, BIOS IFWI 03/12/2023
> > > > [ 5781.461615] RIP: 0010:refcount_warn_saturate+0xbe/0x110
> > > > [ 5781.467585] Code: 01 01 e8 75 56 8e ff 0f 0b c3 cc cc cc cc 80 3d 4c 67 ac 01 00 75 85 48 c7 c7 b0 31 cd a9 c6 05 3c 67 ac 01 01 e8 52 56 8e ff <0f> 0b c3 cc cc cc cc 80 3d 27 67 ac 01 00 0f 85 5e ff ff ff 48 c7
> > > > [ 5781.488761] RSP: 0018:ff45a7f44d39feb0 EFLAGS: 00010286
> > > > [ 5781.494745] RAX: 0000000000000000 RBX: ffffffffc0b36540 RCX: 0000000000000000
> > > > [ 5781.502871] RDX: 0000000000000002 RSI: ffffffffa9c065c8 RDI: 00000000ffffffff
> > > > [ 5781.510984] RBP: ff31c1afa78cb800 R08: 0000000000000001 R09: 0000000000000003
> > > > [ 5781.519100] R10: ff31c1b6fc000000 R11: ff31c1b6fc000000 R12: ff31c1afa78c4f40
> > > > [ 5781.527215] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> > > > [ 5781.535337] FS: 00007f9bc705a740(0000) GS:ff31c1b700280000(0000) knlGS:0000000000000000
> > > > [ 5781.544529] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > > [ 5781.551063] CR2: 00007f9bc5e50dc0 CR3: 000000093b36c003 CR4: 0000000000f71ee0
> > > > [ 5781.559180] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > > > [ 5781.567307] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400
> > > > [ 5781.575413] PKRU: 55555554
> > > > [ 5781.578551] Call Trace:
> > > > [ 5781.581394] <TASK>
> > > > [ 5781.583868] gpio_mockup_exit+0x33/0x420 [gpio_mockup]
> > > > [ 5781.589756] __do_sys_delete_module.constprop.0+0x180/0x270
> > > > [ 5781.596112] ? syscall_trace_enter.constprop.0+0x17f/0x1b0
> > > > [ 5781.602354] do_syscall_64+0x43/0x90
> > > 
> > > I hear you but this trace has nothing to do with the bpf/sockmap commit ?
> > > 
> >    I just saw the same WARNING from kself-test: gpio-mockup.sh, maybe
> >    it's different issue, sorry.
> > "
> > refcount_t: underflow; use-after-free.
> > [ 5781.349666] WARNING: CPU: 250 PID: 82496 at lib/refcount.c:25
> > "
> 
> The  ./gpio-mockup.sh thing doesn't use sockmap at all right? I can't see
> why the bisec to that patch would happen off-hand.
> 
  Indeed, I double checked the suspected commit, and even revert the commit
  on top of v6.3-rc5 kernel,  above ./gpio-mockup.sh still trigger the
  "refcount_t: underflow; use-after-free." problem.

  So "gpio-mockup.sh triggered issue" is a different issue, if I find some
  more clue, I will report the gpio kself-test issue with another email.
  Sorry for inconvenience.

  Thanks!
  BR.
> > 
> >   Thanks!
> >   BR.
> >   -Pengfei
> > 
> > > My change looks correct, so your bisection might simply trigger because
> > > of a wider window for another bug to surface.
> > > 
> > > John, do you have an idea of what is going on here ?
> 
> No idea here.