Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "peter.chen@kernel.org" <peter.chen@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: Fixes error: uninitialized symbol 'len'
Thread-Topic: [PATCH] usb: cdnsp: Fixes error: uninitialized symbol 'len'
Thread-Index: AQHZY7ATLLPsq7d+qU2aYOKDYjOe+q8c/2uAgADJgEA=
Date:   Thu, 6 Apr 2023 05:33:20 +0000
Message-ID: <BYAPR07MB5381895A02CE7B92E6396A2CDD919@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20230331090600.454674-1-pawell@cadence.com>
 <2023040514-outspoken-librarian-3cde@gregkh>
In-Reply-To: <2023040514-outspoken-librarian-3cde@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/i8YA2yOrjLN5eLfvSO5CmDxFfhLuwnMirGJeF6uVyFlmUa+IQsoXOlGTcng?=
 =?us-ascii?Q?mK95inxWXBc5t0RrQFIbsw49oFn9V/BPKSRmAVa8c610AbRVF3usNqXiIriI?=
 =?us-ascii?Q?CAsydHx1M0qe52hUGhiETkxg3d/66KabCNOuHDT3xn+7R2uid71DeBaSj97Z?=
 =?us-ascii?Q?m32WSuW0DuVp0Xx2BDCYnnKuSWmb+OnssZyWdWho26d+nSv6YUwMAOhSZJJN?=
 =?us-ascii?Q?8SREml/Pg3IWq64NBlv0EwW4tHa0DXGPfWCj3BCpzVaMORelTy5m8IIcI+z7?=
 =?us-ascii?Q?Df/a+e4XHcksg0+GYeHQRy43VSHB3ZEIPfpZRTaxbDYdpOmtVVC+gIZCvQlo?=
 =?us-ascii?Q?JjcqRnIwb2Rt7NmieDoDr/gWGISIpBCRX4gK1CKkB7cmxS1VExompEey2R9u?=
 =?us-ascii?Q?ipYagoW/WaTTR64a+KXUCUHHbXHjoLkCaMjo2y/s0UcLdx9MObzvwQIBQ9+c?=
 =?us-ascii?Q?XYG/lZ8q9eDZpaE+L/nuc43Ndikrj6FsMFlkKdEzkYPmHn3+tnqUp0PwsWLS?=
 =?us-ascii?Q?7B/bjLpT/k4ubI+eWZPLD4U9I+b4XWjJ/aGTwFMKrW97w2hFH46eEhimqYD4?=
 =?us-ascii?Q?sBPP2HOWAgi6U0Pgd1Ypy5LeE4ZG2ZLce/35ZFTY1+lj9nlPxy6IvkYwdLj2?=
 =?us-ascii?Q?mozOnUshYeBBembJuj3SeuT3b4rQMx0m3C/aNFUJ3QP3hU/a8RA77mq9Caqw?=
 =?us-ascii?Q?3fiaXYXwAbqto9JuLjBD5vSeALhYjNEj6FuXyEXrAQFI7LK4cxO9C/26h48w?=
 =?us-ascii?Q?556EPfKokIBIAHq1joRDk0VXg6X+u38jjYmaRgv/mPWQcPGwYpoiB7dZ8pwD?=
 =?us-ascii?Q?8q+Zw+pjmliIpAlLtqgCb8cQ0ry0dt5HY6n2gtTPq3IwuXeb1grxjKrSgzcX?=
 =?us-ascii?Q?i/uWDvI1F2VyFtrkyHjZTNf/ShC8fYtL3M7LAPywrDs4gMX8O8wo9ZXrsjst?=
 =?us-ascii?Q?uvnYGTCb4RX8Nd/iVk2752UT0E7qP7BcocHRyD7QsFoVbpUx67dyeE+GHx3K?=
 =?us-ascii?Q?GpsRF//4nTq+77xMmfydtsa6SXdi9jLgGrREftilPijGM1fY4Lkt60q42EnN?=
 =?us-ascii?Q?FRuKss5T5/AOY//WJChJ/3IixRWGmFWlb4pwPmvv1bmW1rmK5qDwzHuu6T/9?=
 =?us-ascii?Q?C8X4wA5B2dYVHQZfMl/et6WjHfBS21EW0roQf0QFN0MYsM4OfN3OqS+1TO9T?=
 =?us-ascii?Q?l2eYRvIN6V16FicQxFmDCZPT6sJfjEwmrXlGm4kFWLPYQNcEJm9HR2/dIUDI?=
 =?us-ascii?Q?OGGNvMLfeAjXfP+sFDJvowJ7ddR6IWFrCMOoXSZv5oSv86VTLf67edKW4n5t?=
 =?us-ascii?Q?uvyXm8HlurYxMXYmF3iMZbFcoBhy2jkTB5eHrZ9rFKJ4JKKJTjL4l1WH5b5h?=
 =?us-ascii?Q?+hs2kI2xrOIMuF2pYii5RyZZQuofS+ZUfZd1E7Ugz+Ccs2Siy8Jg0UdbhUYE?=
 =?us-ascii?Q?tjwZsJEY3anvpmsG6co6c/suEMKIQdNfg1quixI8lDuuqWte5RnayWIoRhDh?=
 =?us-ascii?Q?q/ZbnNNZNSJO5rnLEmNRyjPhN7gXOuNt/KJvlCJcVebkNcF4d9PyBC2UmuSm?=
 =?us-ascii?Q?MtcNvnRRm8J8nVUpv4M7kU/0+NfmDfuMYMiXbM4V?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa60ab3b-f80c-4dc8-66af-08db36606eb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2023 05:33:20.4774
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AMDocEV7H4Ngzm90uWwEldBKZYuolNB0AWmD7GRUBIppI7d2hKdhf4RjB+PVqxM9qGo8luDBcQLwTU8RzSrZ+iyuX62711zuWyp6QE8tbGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3504
X-Proofpoint-GUID: j4StLJ-ppRsoWmn9p-uFKhANpmcuTbwG
X-Proofpoint-ORIG-GUID: j4StLJ-ppRsoWmn9p-uFKhANpmcuTbwG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-06_01,2023-04-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 clxscore=1015
 lowpriorityscore=0 phishscore=0 mlxscore=0 priorityscore=1501 spamscore=0
 impostorscore=0 adultscore=0 suspectscore=0 mlxlogscore=819 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304060047
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>On Fri, Mar 31, 2023 at 05:06:00AM -0400, Pawel Laszczak wrote:
>> The patch 5bc38d33a5a1: "usb: cdnsp: Fixes issue with redundant Status
>> Stage" leads to the following Smatch static checker warning:
>>
>>   drivers/usb/cdns3/cdnsp-ep0.c:470 cdnsp_setup_analyze()
>>   error: uninitialized symbol 'len'.
>
>Are you sure this is correct?

Yes, I'm sure.=20

>
>>
>> cc: <stable@vger.kernel.org>
>> Fixes: 5bc38d33a5a1 ("usb: cdnsp: Fixes issue with redundant Status
>> Stage")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/cdnsp-ep0.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-ep0.c
>> b/drivers/usb/cdns3/cdnsp-ep0.c index d63d5d92f255..f317d3c84781
>> 100644
>> --- a/drivers/usb/cdns3/cdnsp-ep0.c
>> +++ b/drivers/usb/cdns3/cdnsp-ep0.c
>> @@ -414,7 +414,7 @@ static int cdnsp_ep0_std_request(struct
>> cdnsp_device *pdev,  void cdnsp_setup_analyze(struct cdnsp_device
>> *pdev)  {
>>  	struct usb_ctrlrequest *ctrl =3D &pdev->setup;
>> -	int ret =3D 0;
>> +	int ret =3D -EINVAL;
>>  	u16 len;
>>
>>  	trace_cdnsp_ctrl_req(ctrl);
>> @@ -424,7 +424,6 @@ void cdnsp_setup_analyze(struct cdnsp_device
>> *pdev)
>>
>>  	if (pdev->gadget.state =3D=3D USB_STATE_NOTATTACHED) {
>>  		dev_err(pdev->dev, "ERR: Setup detected in unattached
>state\n");
>> -		ret =3D -EINVAL;
>
>That's a nice change, but I don't see the original error here that you are=
 saying
>this change fixes.
>
>What am I missing?

The fixed patch is:
Commit:  5bc38d33a5a1209fd4de65101d1ae8255ea12c6e
And here you have the link to linux-next tree to this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git=
/commit/?id=3D5bc38d33a5a1209fd4de65101d1ae8255ea12c6e

I send this fix as v2 for patch "usb: cdnsp: Fixes issue with redundant Sta=
tus Stage" but it was to late and you recommended me  to send this as separ=
ate patch.

Thanks and Regards,
Pawel