Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67e08770-7f58-159d-437c-5d3432bf6847@kylinos.cn>
Date:   Thu, 6 Apr 2023 16:07:58 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [RESEND PATCH] kvm/selftests: Close opened file descriptor in
 stable_tsc_check_supported()
From:   Hao Ge <gehao@kylinos.cn>
To:     Sean Christopherson <seanjc@google.com>
Cc:     pbonzini@redhat.com, shuah@kernel.org, dmatlack@google.com,
        coltonlewis@google.com, vipinsh@google.com, kvm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        gehao618@163.com
References: <20230405101350.259000-1-gehao@kylinos.cn>
 <ZC2JrJwKM3KrgNgm@google.com>
 <c9db67ee-4a0b-dc62-f507-c4a654fc9656@kylinos.cn>
In-Reply-To: <c9db67ee-4a0b-dc62-f507-c4a654fc9656@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Sorry for bother yours, the computer has updated some configurations,

causing an issue with the email name,so correct it.


On 4/6/23 10:56, gehao@kylinos.cn wrote:
> 在 4/5/23 22:46, Sean Christopherson 写道:
>
>> This is not a RESEND, it is a new version.  From 
>> Documentation/process/submitting-patches.rst:
>>
>>    Don't add "RESEND" when you are submitting a modified version of your
>>    patch or patch series - "RESEND" only applies to resubmission of a
>>    patch or patch series which have not been modified in any way from 
>> the
>>    previous submission.
>>
>> And the "in any way" really does mean in _any_ way.  E.g. if a patch 
>> is rebased,
>> the version needs to be bumped.  RESEND should only ever be used when 
>> sending
>> literally the same patch/email file, e.g. if something went awry in 
>> the delivery
>> of the email, or you forgot to Cc the right people, tec.
>>
>> On Wed, Apr 05, 2023, Hao Ge wrote:
>>> Close the "current_clocksource" file descriptor before
>> Wrap closer to ~75 chars, wrapping at ~55 is too aggressive.
>>
>>> returning or exiting from stable_tsc_check_supported()
>>> in vmx_nested_tsc_scaling_test
>>
>> Vipin provided his Reviewed-by, that should have been captured here.  
>> Please read
>> through Documentation/process/submitting-patches.rst, guidance on 
>> "using" the
>> various tags is also provided there.  And if you have time, pretty 
>> much all of
>> Documentation/process/ is worth reading.
>>
>> No need to send a new version, all of this is easy to fixup when 
>> applying.
>
> Thank you for your guidance,this has been very helpful to me for 
> submitting
>
> patches.
>
>
Thanks

Best Regards

Hao