Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1815615rwl; Thu, 6 Apr 2023 01:22:26 -0700 (PDT) X-Google-Smtp-Source: AKy350aeDVvpyz7bAyXNh5eh/+r2h5lmfkKU5t9TVOLNT4t8CBJEtIeJ/IUOhn56clTRtfcE1zAo X-Received: by 2002:a17:906:e0d7:b0:932:7f5c:4bb2 with SMTP id gl23-20020a170906e0d700b009327f5c4bb2mr5191598ejb.75.1680769346372; Thu, 06 Apr 2023 01:22:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680769346; cv=none; d=google.com; s=arc-20160816; b=I4FmLvj9GMbTcrfr8NFtxW4ItEWJ+N49Tlb81xoKpRmwKEWxOBi12C9MNe5iM1B4aN H8vfW0Vj2ZSTZ9zHHciZMEThplAtOsE4f3hZemnoS5w3d5696xhHmNwH1n0fPpHsLGRQ FGXrIUtIMt0GfMx+UU2yvTGcqGF+mCiTVyii/ZzQe24uta8AtLP4111vKfhQQCLkr2cp iP0xRgQsR8TDcw/u3p3v0UB3r4aK0yPIxfYIfcpB9jne4EOgt2lOfk7Xpd0NvYcDnrPi JA4Z7iFqvnUGqGVU9mhjd5CYGjB09LcYw7Ac4LmzxvxJXPS9FjMf4fvnKWgM3kHDwXVq zZXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=s37AKX46druDkQMukFY2wjOtd4UDmaJrvLEgrvY9bU4=; b=aS/imKL2ne9AuuZyEiUL6DtU5MfIPIlaQbMkUTqXCmzKSFksXPtk81s1jGW7uso9TF 87og8n6c0L6T6JPyLVDg5GxRKYWGb/Rbpr0I7rl1gcbrHfmwlzmCTB+Vp7MmIvWsDtzO ohN/mRF9qfnCRpT0ohyx5znx9YHjswZGlpucH3v2WVNB8N4Wg5ZgLZZHVYCxeA6h5Otv SgyhHd3ksemSWDAPI1tVhm2k0ZJ5NCRK59x1GDArCtYAF3d9+NfsvhZS8tqswSjb2rBK ZbeNifzjgeL0UV9Zclia/RuibDPs7Yb0ImTr2L+wWy02vnQxI40NPTPXdfyEvLxSIPBn BnhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nrSafKY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a1709063e4a00b0093c8a229d78si767673eji.83.2023.04.06.01.21.57; Thu, 06 Apr 2023 01:22:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nrSafKY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235058AbjDFINS (ORCPT + 99 others); Thu, 6 Apr 2023 04:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbjDFINR (ORCPT ); Thu, 6 Apr 2023 04:13:17 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A00A5242 for ; Thu, 6 Apr 2023 01:13:16 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id u97so3215880ybi.10 for ; Thu, 06 Apr 2023 01:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680768795; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s37AKX46druDkQMukFY2wjOtd4UDmaJrvLEgrvY9bU4=; b=nrSafKY0nVFK23NtqSDbq36ZroC2qJOvKZrGvQr2QkYsGlKAjzqDUxSK5MFpX+pIom zm1tokTzkYyxjOP1ZxjGw6rzdAIxm5xhWmPy0olG7nzGFJm3f3kw20jT7Ew1Asewhkbx TasrqL/9bXj7AGVSol29rvvYUk/37XyVnVWapWliLJJNv6jr5gDjZzwoChW1SAgF9+GC 4UYPa37LhaCGR87mi5f1yVaQkjpm1l+5LCfn9IJPDPCKt/esnFUTB8gOdOHuVAaQs0S3 Z+ZTHEWJAERRXGMF2nctXeHg5TQJPs343YSTVvNa07CtvJuIS4MxLK7I5ZCOY07ceeZC 1Znw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680768795; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s37AKX46druDkQMukFY2wjOtd4UDmaJrvLEgrvY9bU4=; b=q75ogauYIjFYfBFv+HGHyeYWGKHMLvZ1bnY0el9dJhMK4i5ha9uhR0lPZTBjbHQNAg nfF4BJ+Ce5S70AgzxupuX9dEfXlVgih44+2LfoT1TNv2L9zWT+mpYkKtT7APGWKkgbKm GNNjgj0JS/Sm9xOuTT0p1tHU41SHoOYd0ay3PDbzo0scEZOBj9xNCA0H/BU/r45NlFPJ FXEmYmDtuec31zFkOk0x32XN3JVH/iWbFoAvyjkWzTErYfHoJ5I46es6a8tkwY1tFSRK 53OoN3ctYIQKbtUCQD1zr3rjmYXWCSNxrWWoHURC0piOfXOctRz/ag6RVDzwLMYSUFso QnZA== X-Gm-Message-State: AAQBX9ec3+tETx7uRhYYU1KtOYERRF3UTWjQPhC5RcdUGWs2sfiWf+XP 5odu9y7/NlR+USSMNWIzWPXt4WEIKv4O+vgJJl8BDw== X-Received: by 2002:a25:da46:0:b0:b09:6f3d:ea1f with SMTP id n67-20020a25da46000000b00b096f3dea1fmr1566211ybf.4.1680768795347; Thu, 06 Apr 2023 01:13:15 -0700 (PDT) MIME-Version: 1.0 References: <20230406063450.19572-1-yuehaibing@huawei.com> In-Reply-To: <20230406063450.19572-1-yuehaibing@huawei.com> From: Eric Dumazet Date: Thu, 6 Apr 2023 10:13:04 +0200 Message-ID: Subject: Re: [PATCH net] tcp: restrict net.ipv4.tcp_app_win To: YueHaibing Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, dsahern@kernel.org, kuniyu@amazon.com, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-15.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 6, 2023 at 8:35=E2=80=AFAM YueHaibing w= rote: > > > 'maxwin' is int, shifting int for 32 or more bits is undefined behaviour. > > Signed-off-by: YueHaibing > --- SGTM, thanks. Reviewed-by: Eric Dumazet