Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <180bd178-e3c0-85e3-785e-fc8a216cf65e@amd.com>
Date:   Thu, 6 Apr 2023 11:06:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] drm/scheduler: Fix UAF in
 drm_sched_fence_get_timeline_name
Content-Language: en-US
To:     Asahi Lina <lina@asahilina.net>,
        Luben Tuikov <luben.tuikov@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, asahi@lists.linux.dev
References: <20230406-scheduler-uaf-1-v1-1-8e5662269d25@asahilina.net>
 <6b3433ee-0712-f789-51ee-3047ead9bb79@amd.com>
 <cfbaceae-6d40-a8b3-e449-6473be234d2d@asahilina.net>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <cfbaceae-6d40-a8b3-e449-6473be234d2d@asahilina.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzBSUGtmTXlHbFE3SDFvK0JCSGpmWVJWTlVRTERyYmxLdXdaRUh5N001YkR4?=
 =?utf-8?B?T2lQdnhwZkdOWnV5RXFYQnVSK2kyQzFLd3pQVnVPMEZzcXV4cGZLOC9jc3Nz?=
 =?utf-8?B?Q0FUTTV4UGtWS2lkMTJhKzVuNG9TRUVNeUU3RVNyZ2JwcDF3OUVZTkU5U0M4?=
 =?utf-8?B?aE5lT0RrRWliQzBuWWltbWExaXVNRWNyM09wUnVVQ0xrc0U0NzBHRU5Ibkln?=
 =?utf-8?B?ZTJtN01vVGpwdzh5K0FMakp6LzYzbjNGMEhtak54Vng0OTVtbVJVWTRuVWlW?=
 =?utf-8?B?RUdscHJNbkNlZ1lYU0RwcnZwWlBENWprc3F1NGQyRmVqTGQyNjFKRFFMRGxM?=
 =?utf-8?B?RFFPVWtGckx5OVZ5YlpWWmFhdFVUVUt0d1QwVk1HdW9wY1U1YkRCQTBpWFFh?=
 =?utf-8?B?TXpyOG9Rb0lSWUtFKzEvRHYzR2ZVcWZ6VEZwUWllbEdTWFVndlM0aUpnMkpM?=
 =?utf-8?B?cGk4eEs2THBVYTRVUHh3aVlQdWZwMUJKRVAwZDFwTXVBcHFVQW80NExQMG0r?=
 =?utf-8?B?aFdndEdQM3BIQ0ZnblI3Y1dEV01XN2VSck9INEUwcTdNT0tVTlFlQmJXbHB1?=
 =?utf-8?B?SUFLY3VBTXFKYnNhYWZJMlZaZGFRbEVHNGhSdmEzNnhlYm8xM0syZUdwSENR?=
 =?utf-8?B?aWo1VEd0Y3B4dHBEWm1kUVRPSkEyYjM2NTBncXA0QTBrK1AxUy9ROTFjemxH?=
 =?utf-8?B?NEpYOGpEdFJtanBjaEJHZG9MUzh5YnJZS25YaWZpdEhLVGRUcWxTNHdyS01y?=
 =?utf-8?B?dW5pL1pKY3AxbE5iUGRoSVJnbkFZZU1jSmk3U1QyZDRrbnZFZk9OclRaNkMv?=
 =?utf-8?B?M1g4RGhxUTJEMVd3YnlLOUhMQnloYWpZaWc0TDRDVE9raHExOUxJYUk4MkdL?=
 =?utf-8?B?enhCU3g2d3dxekZ4bCszSGRCdzlMMC91Zk5IQWdZczRlbjRNZ3oxaHZoVXNW?=
 =?utf-8?B?UXVDMm9LbTc4ZjdiMjhwVGI2YXpUVmRUQWl4TEFVaXdNYmhoZFVIMHFmLy9k?=
 =?utf-8?B?eFFNTVVhL2J5OGwrUVRBTjNUdEc1NVlKTU1hVGRVNVM0N0NYTzlTb255RnA4?=
 =?utf-8?B?SVQ2QXg3RmlmSDAwSkV6ekpsTGlXU1FEMjcveXNCNG9RNXVpUmUzYVp2a0Yy?=
 =?utf-8?B?TlZOZFF2Y0s5ajBwbFZpdy9HUi9VbWhoSUcrdlRDNWRrVU0ySzI1YlBnRUtn?=
 =?utf-8?B?KzBFTDFxZjhzRE9laVFsMmdqaGVBT0hkV3dGcXUvdFIxT1BPR3hiZUlROGM2?=
 =?utf-8?B?MG8vTVk3V0I1OWlTME9sVm1BRFhaL2RjVGhRdlRrZkVSMGdBN3RGb1plY0RI?=
 =?utf-8?B?Smt1YzlQL3pmdUFrVVRDKzIrakVQd0xzeFBNc1MwL0RPNU1oQXl4Y2JNSzNU?=
 =?utf-8?B?V1B3YkN0NG5yUEJCMHpLNUJuVXlHMlVVWCtYWGxzaFpTNU1PaE1Kbm1laXI4?=
 =?utf-8?B?ankrbmRIV25Wci9NdXhSWDdsdk1EKzNlWGIrVFZqUzkvZlVxM3VFRHpVL242?=
 =?utf-8?B?SEp3SjJCTkM2bmNHRklTT2U4aDRON2hwMTNacVhSaFR0a0dyTHQxRWtEOGtz?=
 =?utf-8?B?c2IzVGowVi9tY3c2emg2dFlDaWo0QVVTRko1TnEwemZHZlJRdG05T0w3L0tV?=
 =?utf-8?B?c1R3ZnBHRG1JUUhkMFROQzI4Nm4zdVV5RWsza1dJWWY0Mm1UKzN0eDF1eXV3?=
 =?utf-8?B?SEhRc3hpUmZXeUNiTklVcFh3WXpUNmhaNnk3djhkYjkrY25Kc0tBbTBvdlpq?=
 =?utf-8?B?ZnJCOXR1Zk9CcFRiM0pSOFZvKzJWYmFFMG4zMHBmeFd4L0lXbkdBcUQ2b2V1?=
 =?utf-8?B?T05PVnd2Yld3eEh2TXJkZ3F5ZWViMXdrd1pmUFpvZDhWMmRWNFRLbWZ6T05m?=
 =?utf-8?B?OHZ5OVoyejltRW9hNWRyTS9uWVdzNU1DR24wcWV2bVZkS1gwUGZHVzV1dER3?=
 =?utf-8?B?cE1Fakk4UUxidjV1UmIrVnlZZ1FuaVBGa0V1WWZVUkJVWXJUTWMxWlF6Wk1Z?=
 =?utf-8?B?V2hrWFlMcDFISXJ3Ym8vQmdhdTN2MVRqLzhqS0xISWpCZVJyZExNbVNjUk1m?=
 =?utf-8?B?cWU1eTBkaDl1emV5TEtub0RmQjNEMGxYemhVQTYybGZhTnRMQWZZaTIvRmJQ?=
 =?utf-8?Q?CGKVV4cDTI/PIctXDuAgJYYMM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1faf12-aeb6-4717-5437-08db367e2c21
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:06:13.8438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M2gTGOwcUKhYIl+HGwoihHTcBhlAiqBYEMokM02MVO5dqhsYtbHl8aiRyl+gZ+of
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6689
X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 06.04.23 um 10:49 schrieb Asahi Lina:
> On 06/04/2023 17.29, Christian König wrote:
>> Am 05.04.23 um 18:34 schrieb Asahi Lina:
>>> A signaled scheduler fence can outlive its scheduler, since fences are
>>> independently reference counted.
>>
>> Well that is actually not correct. Schedulers are supposed to stay
>> around until the hw they have been driving is no longer present.
>
> But the fences can outlive that. You can GPU render into an imported 
> buffer, which attaches a fence to it. Then the GPU goes away but the 
> fence is still attached to the buffer. Then you oops when you cat that 
> debugfs file...

No, exactly that's the point you wouldn't ops.

>
> My use case does this way more often (since schedulers are tied to 
> UAPI objects), which is how I found this, but as far as I can tell 
> this is already broken for all drivers on unplug/unbind/anything else 
> that would destroy the schedulers with fences potentially referenced 
> on separate scanout devices or at any other DMA-BUF consumer.

Even if a GPU is hot plugged the data structures for it should only go 
away with the last reference, since the scheduler fence is referencing 
the hw fence and the hw fence in turn is referencing the driver this 
shouldn't happen.

>
>> E.g. the reference was scheduler_fence->hw_fence->driver->scheduler.
>
> It's up to drivers not to mess that up, since the HW fence has the 
> same requirements that it can outlive other driver objects, just like 
> any other fence. That's not something the scheduler has to be 
> concerned with, it's a driver correctness issue.
>
> Of course, in C you have to get it right yourself, while with correct 
> Rust abstractions will cause your code to fail to compile if you do it 
> wrong ^^
>
> In my particular case, the hw_fence is a very dumb object that has no 
> references to anything, only an ID and a pending op count. Jobs hold 
> references to it and decrement it until it signals, not the other way 
> around. So that object can live forever regardless of whether the rest 
> of the device is gone.

That is then certainly a bug. This won't work that way, and the timelime 
name is just the tip of the iceberg here.

The fence reference count needs to keep both the scheduler and driver 
alive. Otherwise you could for example unload the module and immediately 
ops because your fence_ops go away.

>
>> Your use case is now completely different to that and this won't work
>> any more.
>>
>> This here might just be the first case where that breaks.
>
> This bug already exists, it's just a lot rarer for existing use 
> cases... but either way Xe is doing the same thing I am, so I'm not 
> the only one here either.

No it doesn't. You just have implemented the references differently than 
they are supposed to be.

Fixing this one occasion here would mitigate that immediate ops, but 
doesn't fix the fundamental problem.

Regards,
Christian.

>
> ~~ Lina
>