Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com,
        jefflexu@linux.alibaba.com, damien.lemoal@opensource.wdc.com,
        naohiro.aota@wdc.com, jth@kernel.org, gregkh@linuxfoundation.org,
        rafael@kernel.org
Cc:     linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH 2/3] erofs: convert to use kobject_is_added()
Date:   Thu,  6 Apr 2023 17:30:55 +0800
Message-Id: <20230406093056.33916-2-frank.li@vivo.com>
In-Reply-To: <20230406093056.33916-1-frank.li@vivo.com>
References: <20230406093056.33916-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8xu4ODqKtAEl1g7E56zucgOxpsbcH9SlAcjmR8ueI2nrU8hvfWKC3AHqkiBe?=
 =?us-ascii?Q?V67C4dD7uK+b1EpisG7emocEAqwqOkrGRGD5N8H3UYCars6Kz5ILiLYlke5A?=
 =?us-ascii?Q?PEP9fSc1ej1k319glHbQS/vovIPPfWF5/3AUqSxIvJq8Ljgz6GedjIjiVWZu?=
 =?us-ascii?Q?X/84LGNjFbgraHdm8+P/pfi1CBnPXZ1ftpqIjb7v30uy0B1jefCiWV1yZD7y?=
 =?us-ascii?Q?5DOTNJ3hMfPIQk5hg1gZrtEj1mbTSYw0sXEq1DaKQDIdJyEOBOK/W/BHitV0?=
 =?us-ascii?Q?peWOghgs4M28bi8wbnXZqNIM54LENo90IRM6SXoCq5mwEpI/KplzQEf68eQu?=
 =?us-ascii?Q?gLQv3Su18mf9UVGAymh3dUlsbmrf4XoPAC6BXcvz8H841nTSBTZRLg3v7QTn?=
 =?us-ascii?Q?Vr6tLRXAvq1k0NXZ13E4Rp2bnTUpUrrAGMkdl+mZsDyEUkULyKI2YZtfHtca?=
 =?us-ascii?Q?27QQ/yTopMjWTjCT2rT9fDQ2NF7mnPXVyGtQdlAvWFoNTZMxCeJekwTAilDm?=
 =?us-ascii?Q?tDexjFpidJeB3xxS1AXDYxUD32UNnExBv2VKWe9ysWKxf7VB9qcnWaUZRnSo?=
 =?us-ascii?Q?x0BvwCPf4N2YKwJvAnsVEittK1kfvMaV9ijjszOrc3xz9PZ4otl9imyBp7ws?=
 =?us-ascii?Q?NtSEUwbza3NfHRLABBOET9FV783+hUqLPobHO5diyHn5xRmNMh1G1aS8+5x4?=
 =?us-ascii?Q?Z3HlxzS3fsDb6F+lP0Xoz5PSoSfW5yHB0NmbHN+GajicnJiSqJNUrW5C16T4?=
 =?us-ascii?Q?mhhpLSUl296x3F/jCiEnAasv8yR3rHhnWDRt/F+tCrFqCR8PgkfyjTTs1e/v?=
 =?us-ascii?Q?9qAiSVfMLyOBb14qzs4sk1DXH+6RdE/SjMyiBvWiwzwE7BYSl2hpF0zsETNW?=
 =?us-ascii?Q?EdT49MVuldHCGVocir5yi56wyRgorWwWnB/h8rChNKn+QXWUM7rIhcagONZy?=
 =?us-ascii?Q?hd4dRtLcddcYgnFOMgCeUJi8wTcUSQKdi+GwdaVUYnKCnET8jhChKqlI//HY?=
 =?us-ascii?Q?RI3Dz6IPEb3GQn6JdeDS9Plkd/zqj7lxsTBZf8UWoawKtubXZb0ZPiE4ICXr?=
 =?us-ascii?Q?5Q7vCoFuJtx1QKaAEe8uElrQSBxowB3L2QJ0g02bXXTzVDqGHRKjxQI00ti1?=
 =?us-ascii?Q?Xkiw4Z0kog876vt+pJKmXBneqUX01whm7i5uN1iFtJyGHnuv3RKwX8CU++ou?=
 =?us-ascii?Q?iEHJnOlKcWFdxT+x1THxJBxBrwydyLb1lfRzQB68j67HczBDfAFi3h13dljb?=
 =?us-ascii?Q?e5SBjrGBJZxfpJ6TztPePm4YxJQiBpNM1uFJ7R+yle6cxyQ6uJ2ax0/3IMVF?=
 =?us-ascii?Q?jLfeFTxKQ3BRGqyttJAN+wwbt66iaP9Ty43Zmd9dHeNc8CjG7PMtQ5vdHijA?=
 =?us-ascii?Q?vz8PwKU0on8e6VkL+ER8qNBuUGFyrHdJ2BdEsdjPoNGRAuzFWfex5/ru7cVV?=
 =?us-ascii?Q?JrSHYj466J3rB9CRKE3D7iojBp0w49acGWmj2V25IxI/2avkEKnkq841ss74?=
 =?us-ascii?Q?rT/JYHt4AAmLaaiV9GtVWpNX0g65lJ8UEaB/JS6W+AYoDSH6lyNY27RruuRw?=
 =?us-ascii?Q?/hKSYuaUaCuQv73mvJGt2pVomsdXh51cDBz+MM21?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8170c1d8-b98d-4372-ff9b-08db3681a912
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5275.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:31:12.0469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ucu/GWhOFtHHd9+lmAZP+zHCRhmy8WjLG6Owda8gfhS1ot0DwgzrvJF/ixbprPVuVtsZoo7q+Bl1MR1XyI38mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5772
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use kobject_is_added() instead of directly accessing the internal
variables of kobject. BTW kill kobject_del() directly, because
kobject_put() actually covers kobject removal automatically.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/erofs/sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c
index 435e515c0792..daac23e32026 100644
--- a/fs/erofs/sysfs.c
+++ b/fs/erofs/sysfs.c
@@ -240,8 +240,7 @@ void erofs_unregister_sysfs(struct super_block *sb)
 {
 	struct erofs_sb_info *sbi = EROFS_SB(sb);
 
-	if (sbi->s_kobj.state_in_sysfs) {
-		kobject_del(&sbi->s_kobj);
+	if (kobject_is_added(&sbi->s_kobj)) {
 		kobject_put(&sbi->s_kobj);
 		wait_for_completion(&sbi->s_kobj_unregister);
 	}
-- 
2.35.1