Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cbd9d71b-c91a-9354-96ee-e1e2c541bbc0@oracle.com>
Date:   Thu, 6 Apr 2023 10:33:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH next] scsi: scsi_debug: Fix missing error code in
 scsi_debug_init()
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, kernel-janitors@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNZeVhCZ0FrcEhoSnZsUktmVmxJU3N6eDdQc1JNNmg3RlYxeFI4U3Rjd0lv?=
 =?utf-8?B?b0tmdzhqMGdPT1lSSTkzb0lvV3k3cVEzOHFTb3RXdDFDK0M0VHhMbzhXTThZ?=
 =?utf-8?B?TEJWZ3hreDlYendzb3FPVERiT2Z6TXJPQzlTejVpN1B2bEEvVEJuM0poQWI0?=
 =?utf-8?B?N3dHa056djhrSnF3SmtlMVF4RVFQTE95ZDcrakRjRm9nS1VFMEovZGJ5VXhG?=
 =?utf-8?B?U3VHUkhncDRlejd6UmlJMFNEckt6RjhxL0ZZakR5NUEwSU9GY0tFcVQ4cTVq?=
 =?utf-8?B?bEdHcnVaVmh4NlJ1TThHVGROOVh1Z2d6aDVhS2dGV0Q3UU1rZzFKM0dBY2Zm?=
 =?utf-8?B?WEhteDJQNzU0K0paYjlLVmlxaUlGR0ZiS1l2MDZ2UXp2UUVLVkdhVmgrK211?=
 =?utf-8?B?R2haRDgrY1pqY3MxY2FOdGt2YmJGNEs1NmdDVzRwb3U0bVlpNE4xZSt6cWE4?=
 =?utf-8?B?OEJLd2ZkN3NxUVZFeWVwNmUvYTQyTjlUWmdkZkRteittUVVhRmpyOS9jNzV3?=
 =?utf-8?B?QjlhYjdPM3NRcFozSnBUeHJqYkdNN3ZjQnhyYjNLdFkrWHlOcEZlVXlqYUo0?=
 =?utf-8?B?K1RQdFRSeVJxQ3FYQWNvNGtSZlVlci9DVGdwWkg1SFVXNmN3UjdIKzU2b1ZN?=
 =?utf-8?B?NVpJMnFSY1k2MGxxNXQ3MXVyVDAybFZ0clFYZlp0QVhvMHlpRlg2aFNZRzdR?=
 =?utf-8?B?aytkUktHcDQ0a2RLSnNBVlVKRThWV1R1NkljRU85cmNsT0tIZXZDNzNGUHFR?=
 =?utf-8?B?N0ovV2lvYmN5YXJOamNEd01pWTB5aUpTQWgvMExMdXlJTEdWdW5UemhJbG0x?=
 =?utf-8?B?ZG9rVGZ2K2RuZ2M5aWpDcDFoenB0MzEyV1NNM2dBQWpIUHZVaTlIbjNBaDhw?=
 =?utf-8?B?cjRoRm9TSm5OL0tuMFY4VUE4c3JIVmJHRUtacDNxM2VzZ3poMWdXWnovUzFk?=
 =?utf-8?B?NVozTnJYWDRsbjA0R2oxbWxFUnpzNFVhcHBKUnN4bG14MmFZUFNQYm1Mdm5n?=
 =?utf-8?B?OHJLeGRrZVdTK1lVUjNCTVdtYjJCUUg2ampNaDJpUmFBbXZpcnRKOTB0bkZ0?=
 =?utf-8?B?YlZRUmxaNXJmS0swNlZoZUZkeUVOUXhuaXZxOFR6Lzl4MGtleUoyVUhHanlX?=
 =?utf-8?B?L24vaEhoTzNhSVFjWU0zekptL2JWN0lQUmVHaWEya2MxUllycjFhZUthM3VM?=
 =?utf-8?B?aytQSWlVZldhYUVLU1JDc09yc21CNDN0QTFTQlZDMGYzdnVXams2dFkrZEkr?=
 =?utf-8?B?LzNhUG4vN2NGTmlvaTBRMkE0S0NTWkpoOVQrVlRPNWlSZjlNTDJydVQyWE5R?=
 =?utf-8?B?QzFiendoRnRiK2ZBam10eUNBMHQ2Y3o0WktERzNXMGFCamE5Q2lMRGwzYjBQ?=
 =?utf-8?B?ZU51TEdOQTl5MXlJWXp4WXAzQml4dHMrL0hsUW9vQ2NnaldpdDY5d3loREk5?=
 =?utf-8?B?aFNJOWVLOXFlTDNYMDEyVVZ6S1NRbnRiWnZQWEE3TmNBQ0dDOFY3TDBzM3lS?=
 =?utf-8?B?REV2TndzZUMxSVNVVkVZeGk0YjdvOVBxU2c5QXBHb1JRMjVjUTB5TUd3SThz?=
 =?utf-8?B?YXI0RXVYczIvNFhkUERJUGc0SVNPOEl2ai9sbWVseGdyTnR5VlNBTzZvS0hR?=
 =?utf-8?B?YTI3NDl5Yzh2VThWRE9EM3FnMHp0ajF1dGF5VXhFdTcwK1RFN1k0SlluM2tN?=
 =?utf-8?B?bWNnQlJiRnN3U0FiSk1TWGNia2x1Q0hhNWtjNHZHWGJzSWR3Q0FwcFVyRmp0?=
 =?utf-8?B?SGVpL3VneXhPVUdoTVcxQzdFNUZhdTVXNXh1Y01Lcjd5bXRTdjhCN0pYalZQ?=
 =?utf-8?B?SForSncrUVVjakdXbWswV2VDYTlFUVJieHQzbHdXY2lQcDBxRkV4OVQ4NlpJ?=
 =?utf-8?B?NTZCcEtjbnJqOGFGUXVzdm16SWFOMlFzcEVYSkI1OHREWHQweFRXUEo0ZkhJ?=
 =?utf-8?B?eU9BT20rZjdjUzVhR212ZTh2Y2tPN3hiNk9oK0I3bjFuT0MxSE5qNHdLZXQ0?=
 =?utf-8?B?a3d5YzJsYml1Y1B5MHlrZUVhM05sZ0xqV2xCTzlSTytkS0RBcmtPRXJaTnhu?=
 =?utf-8?B?dEVXVWpnb2ROVjZKN3FTcTJKM1dDY0RUakYxSFBXNnlFV1Z4TlFQUDhBelFO?=
 =?utf-8?Q?7Oy5ozWjV494xRTkKCx2gHrij?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5BCnua2LtqrB0N8y6HjS+XxZ8blM8rwoIiJvOx08g9vkA2C0SjAIpi2hkqvbTiY2HWQx1UmAoyhRhbnNSKYILERV/DsCBMYKmRVd8P29IYZwWIWNmhSJPIy4WwVEHnasXxcM9nDHdwQt4pEB4n21y2j/6dui1lW3J4kg8lxMlgLDPgWgJi2d9GTkrVY76p5kdbSz7YPpaFZuXJQtuGPoqW+/HmkhcMYxLqGjOxLu7FohNerjmOGNIrh30jnpGpmvAzqI5YLGsYWvgAFX8PYypkfZjasqS85MB7uDTWH8bxrP7Cw/jVJVGP2/gJkkTSmLl2urOpCvIxjgCZ+USbxPJHOjPXRBmgFEWw8zlwSv2LxuqhIZV9xEABuUAHMmS/Uv98bx1eyfy8nmZkWXrVdCb9pYHgB/kechfIQAIZjvVl1QdQwh6KtXQKYaxyvEfhIcDgdnHmA+NsZXBALBAyQCIQ7hWPvTVJW5Hi5MzgvPT1xgyYSJqh8Ck8tYnovM3hyWOBrdppjrqLuTeL1SCNppD7QF05kSrn4poZdIrZ70d0RG5tDei/Ep8qCFo4HpZISBs0iCahY73I+YUIhMHR2xcrtVy+wVTpOjtlpiTBh52cK9uCik7fI3ws0KSM8iNABIcUG1gYYzjSdDuNWqv7Ie5CVxSLuolxIx90kNE96jsIrMCQs3nO6PEa4q9yKO3CHLArDj69cDzbX9lzLjFtFDDTwnk2wB8v8mwG9NyWfsPTgZIC6MZchDbxEzT3IZ8dAim7QD7PIIP9fn6xHULmc9sLpbJupM9Fh0ALt0W4Bp0ILHyhLKzFI0LYUuRA6t8+Yb
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91f06709-b593-4220-ad10-08db3681f372
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:33:16.9183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0kQ9xkOckdVO1OH85qj4Ezr0wOYwEB4u5/w0Bvfhw7itGP9Z9NgW/BipK9NnoaVksRev0beqtO0U9yIqxRRffA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5648
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-06_04,2023-04-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304060083
X-Proofpoint-GUID: AW3xENE-thug1X0ZvuljlJ8SSE9xz380
X-Proofpoint-ORIG-GUID: AW3xENE-thug1X0ZvuljlJ8SSE9xz380
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/04/2023 08:46, Harshit Mogalapalli wrote:
> Smatch reports: drivers/scsi/scsi_debug.c:6996
> 	scsi_debug_init() warn: missing error code 'ret'
> 
> Although it is unlikely that KMEM_CACHE might fail, but if
> it does then ret might be zero. So to fix this explicitly
> mark ret as "-ENOMEM" and then goto driver_unreg.
> 
> Fixes: 1107c7b24ee3 ("scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd")
> Signed-off-by: Harshit Mogalapalli<harshit.m.mogalapalli@oracle.com>
> ---

thanks
Reviewed-by: John Garry <john.g.garry@oracle.com>