Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     hsiangkao@linux.alibaba.com
Cc:     chao@kernel.org, frank.li@vivo.com, huyue2@coolpad.com,
        jefflexu@linux.alibaba.com, linux-erofs@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, xiang@kernel.org
Subject: Re: [PATCH 2/2] erofs: remove unnecessary kobject_del()
Date:   Thu,  6 Apr 2023 17:41:28 +0800
Message-Id: <20230406094128.36587-1-frank.li@vivo.com>
In-Reply-To: <028a1b56-72c9-75f6-fb68-1dc5181bf2e8@linux.alibaba.com>
References: <028a1b56-72c9-75f6-fb68-1dc5181bf2e8@linux.alibaba.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tgAa8Q7ZfribeyhC851VwSSO3umGNschdd3ceULEKdcRgy4K2k6/vUcuCOg1?=
 =?us-ascii?Q?WW0jAAdiS2Vnyb+j0uPNmUFBVen8zqGY9GJ8EYsXogrGVUvj1LSla6kIJ0cS?=
 =?us-ascii?Q?sPyGFyqRzmUzh2HsPyEXtCqf331qGBifBi2+aGaszvwdVXklie0iaB+EI7rr?=
 =?us-ascii?Q?5mm0OXsQ4cAVqtmHGuN/cdMljnyCDvxNcWLs5DrUB59JRmMYQ/8vDzllxqGt?=
 =?us-ascii?Q?K25q7Kp9GNsbs+QJoY1CUcLa4wJZMSa3GkY9C1/AhEKHv7aAB4BfgmJRirzy?=
 =?us-ascii?Q?mYDTh+5eKJ7TsvDYCk661PVX48Z65AaTPbgmFDlWlgnR9vpKhglEIpPTMs/w?=
 =?us-ascii?Q?hrR5S8rSA6aBfXNWacy2++ez5RPaSskZ8VVepJk73OChnuGJth/ao78aYlwD?=
 =?us-ascii?Q?f7SE1RRYBAK7DRz+xbLIiS2/z8PW9O8YHZCMuFsMNOAtbawjMzJpEMAx1ebB?=
 =?us-ascii?Q?Ql/MWthBBUeUOyEYGPchqpOYjE4JxVjXPZ/o39OZDuhX0QKvHn7sj5HnkW3w?=
 =?us-ascii?Q?Upo6iwlZXY7KtZ0sFU3/xzKvEICjorubFbMzselguJhohNMpTDVu6/biB00X?=
 =?us-ascii?Q?rNepZLN72sDZVmIfpfQ25r5tRfh6UTufNeGU8h4o39tnb5Q+haNsltq9VbFl?=
 =?us-ascii?Q?swGxCfKRHZGce9/CJ8mq/HdAmmIuBAUxoqSp4qCvQP5WGhjor5Eobb+Z926S?=
 =?us-ascii?Q?OcjW+fp6gTKpsBUsSyF8gavs8qWT2rUa9sTKF3mL7vQBxT5vAIq6rXTJAIaS?=
 =?us-ascii?Q?90Y7JP2asGV4/PYemTekdBGAZ8Kfz5lDaG/7E49Uts+9nvgWta0b2VHvoGjo?=
 =?us-ascii?Q?uptMvvf2zLRWG7Lcb3zAxQqz8l4rOPrfLJ3zeiL4lOrz+utRMxePSeWYzfKb?=
 =?us-ascii?Q?F43iwoyzbJLUiF2GUGz/s3JL/qXi8ncm+m6M84JOylXbpP5CMLt4jM+h9UDX?=
 =?us-ascii?Q?v7Qbas3I9TiD6orKl0OesS0RithWnQyzjT4z6O/XE4ShHcaYbiGPt3ZPuiW5?=
 =?us-ascii?Q?c5CX+a1ewyvY0cEGDd5Rcqo8kpqDO2/Txjtui7pfrj2+0UaKamkSG8h7KvEK?=
 =?us-ascii?Q?htCSg7bKJzZuS91OCC3WTHDLiVOl/WsNfN6vojiUSCGUHQx1wMLHlP17ywO/?=
 =?us-ascii?Q?0/rQmspY8j981jI2kd4z5MUK9KleyrhgkBRZI6VoiVt2GI1bnN6oem+fMXb3?=
 =?us-ascii?Q?mFmIEhDDI0wOxi9o3gHNAeYd7htblNfF05q7zn26mKKBNzFk00DmAHbOl740?=
 =?us-ascii?Q?5ccZzEdY1QXnCvL/SLuejzZrKpVFc7GtkLjbrvlQ2pZE78xhobNQCft0RJYg?=
 =?us-ascii?Q?9HeOR3b1iBkuczxinO84vQQhHzv0SCHUqtAAB8zRspVT3xr0gCE95gbRFIWc?=
 =?us-ascii?Q?X1WNhcBh2zBzaRNnmV4f++0xiCRs4v1z7n0qPfVDtmkTQILMLKAGqynTyx9Z?=
 =?us-ascii?Q?NVIAAz7557aS7oHau/3qXwqhFjiM7XfwPoxzD9D0KfOXcLNzeb9rGDkZQ+Vl?=
 =?us-ascii?Q?EFivXLoj3D5/3yCOVknwHzhEMkNIHRYrsSquozjdQK76OuxgmQ9ZjI4RnuCT?=
 =?us-ascii?Q?kI/eItVMMZQZYX6pEZ0riq7HQsfij6tEE/antH1p?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0df73d2e-f733-4f1f-4243-08db36831d33
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5275.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:41:36.4241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sV1zCuIxQK7O1WqrEGP4Ayko/Put4UMd04Mc1c39sEXtAu4ouUSXnIX9jzZSjw3IQmWegWjOE2zNJKp/Lb1hkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4610
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

HI Gao Xiang,

> Would you mind taking a look at
> commit a942da24abc5 ("fs: erofs: add sanity check for kobject in erofs_unregister_sysfs")
>
> , which could be "git-blame"ed (I'd suggest looking into these
> blame first), and the related discussion was:
>
> https://lore.kernel.org/r/CAD-N9QXNx=p3-QoWzk6pCznF32CZy8kM3vvo8mamfZZ9CpUKdw@mail.gmail.com
> https://lore.kernel.org/r/20220315075152.63789-1-dzm91@hust.edu.cn

> TL;DR: I guess it could be fixed as below if kobject_del() could
> : be killed safely:
>
> 	if (sbi->s_kobj.state_in_sysfs) {
> 		kobject_put(&sbi->s_kobj);
> 		wait_for_completion(&sbi->s_kobj_unregister);
> 	}

Thanks for your review and detailed explanation.

MBR,
Yangtao