Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1922183rwl; Thu, 6 Apr 2023 03:22:58 -0700 (PDT) X-Google-Smtp-Source: AKy350Y2ry2XOMJaEw9DzyPNuQFtphwVyAkrAoltxix8WgH/wK4pWYAF/NWfEglfFqqJkqPZImrS X-Received: by 2002:a05:6402:8d8:b0:502:7767:3c73 with SMTP id d24-20020a05640208d800b0050277673c73mr4771583edz.22.1680776578066; Thu, 06 Apr 2023 03:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680776578; cv=none; d=google.com; s=arc-20160816; b=MGET6NKaog/2sTbncuP5bU9b/QtpdEKujTqK4q+8sCe08pIvNr2yP/80o+GuwXpHNd 0ShmkkhmSRNraTdtIuJQon7wGzaFakGhSTkwk7lJcqHHVfdLNZIYYVbGLYh/rTXjzFeO rqKY7JWUmRG+TybAEDoDmx+CpwFqer9p1e9gKhUIbnAGhKKBuMUbzeVwacp25Kq1F1Fg 39QLiAMshdFKWJUngayay5mdK6x0zb4V0JekBBz515oiyJdMiOYrkC++mnxrxLxCWPAe YnsdbM5X9O/A4H/Fr5oc0eewYeudQOOCCAf2lHU+XkZP0daxaiRuVVGg9U7eLPRj4zas zIhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CkCmdI68hl7tqOYPVxzlTuZiemQmaaXkA5K7G5Zo23g=; b=mnwMga3+Xdza7wfTNRbevaZ+AecUz4DCWnfkvjaC/EdklPibuJcM+y3FWnAl02bcmj 3sb6X4pVdymHbH/0+2wd7UseT5KuaUv6/db16bcGm+u1bl5HW2EbDAd7k3KRsF5u0TUn HsKB559tdyhezWCagRmEOkjF0jo+O+gwlTFSVrsrFKUr1bSgozFDNa/za/AdrRooO+Vq 3nKs+S6kDXly7s1CSrqxCVxyNwJPsLXnDCy8O4N/M8E0k7YZSZW+462Od+A2Wg6GlUH+ H+/dyN42o+jLGGwwIr6M3Diz5E81VxqpRmEm4z+OiLiyEaZxlkOdqryEqM9RigNjze6P 9GQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="bLBR8k/f"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo8-20020a0564020b2800b005021f0d574esi877197edb.661.2023.04.06.03.22.29; Thu, 06 Apr 2023 03:22:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="bLBR8k/f"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236734AbjDFKNq (ORCPT + 99 others); Thu, 6 Apr 2023 06:13:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjDFKNn (ORCPT ); Thu, 6 Apr 2023 06:13:43 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34EA1BEE; Thu, 6 Apr 2023 03:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CkCmdI68hl7tqOYPVxzlTuZiemQmaaXkA5K7G5Zo23g=; b=bLBR8k/fiimH18GdvAK15UFk2n RdbZtfnnmrpjkx3/efwT2ilztUUfLNu7O05bZEkagyZ7dm43Daqk1db6i9NxH7qqc+9jmuyW4LBWI u8EOPfr0ht52oBOwc0MncaH2CmcA5YYHdfH+9uuFONUoSViH6Zf/sYRg0I23vn8TPdzMocULRxivE oIh0CJauUv/acqC6Jo+Ww2/2sn1wkeFvvv6kbTRU8PzApzUNiNCfQPW6q5EK8CNAX1xaX2MPxuAeV yzygMk1HuHFY4+rojbbqGz9p40RUwPF1u6hDjA37hYoJj96Ib9ftqJaBJ174AAmptbOhUkSfl9iQD PlSr+s+g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pkMby-00AUhW-0c; Thu, 06 Apr 2023 10:12:58 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C919C300194; Thu, 6 Apr 2023 12:12:54 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4E4D720B6A7D6; Thu, 6 Apr 2023 12:12:54 +0200 (CEST) Date: Thu, 6 Apr 2023 12:12:54 +0200 From: Peter Zijlstra To: Paolo Bonzini Cc: Lai Jiangshan , Dave Hansen , linux-kernel@vger.kernel.org, Lai Jiangshan , "H. Peter Anvin" , Andi Kleen , Andrew Cooper , Andy Lutomirski , Asit Mallick , Cfir Cohen , Dan Williams , David Kaplan , David Rientjes , Erdem Aktas , Jan Kiszka , Jiri Slaby , Joerg Roedel , Juergen Gross , Kees Cook , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Linus Torvalds , Mike Stunes , Raj Ashok , Sean Christopherson , Thomas Gleixner , Tom Lendacky , Tony Luck , kvm@vger.kernel.org, linux-coco@lists.linux.dev, x86@kernel.org Subject: Re: [RFC PATCH 0/7] x86/entry: Atomic statck switching for IST Message-ID: <20230406101254.GI386572@hirez.programming.kicks-ass.net> References: <20230403140605.540512-1-jiangshanlai@gmail.com> <19035c40-e756-6efd-1c02-b09109fb44c1@intel.com> <3591487f-96ae-3ab7-6ce7-e524a070c9e7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3591487f-96ae-3ab7-6ce7-e524a070c9e7@redhat.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2023 at 07:03:45PM +0200, Paolo Bonzini wrote: > On 4/4/23 05:17, Lai Jiangshan wrote: > > The cover letter has 800+ lines of comments. About 100-300 lines > > of comments will be moved into the code which would make the diffstat > > not so appealing. > > Removing assembly from arch/x86/entry/ and adding English to Documentation/? > That's _even more_ appealing. :) I *much* prefer in-code comments to random gibberish that's instantly out of date squirreled away somewhere in an unreadable format in Documentation/