Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ccc179f9-1279-9b3a-04ef-0107ad0592d0@ti.com>
Date:   Thu, 6 Apr 2023 15:15:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104
 speed mode
To:     Bhavya Kapoor <b-kapoor@ti.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <nm@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>, <d-dhyani@ti.com>
References: <20230404091245.336732-1-b-kapoor@ti.com>
Content-Language: en-US
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20230404091245.336732-1-b-kapoor@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/04/23 14:42, Bhavya Kapoor wrote:
> Remove sdhci-caps-mask to enable support for SDR104 speed mode for
> SD card in J721S2 SoC.
> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---

Your commit message doesn't explain why?
Why was this disabled initalially and why is it okay to enable this now?

If disabling SDR104 was a bug, please add Fixes:

>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 8915132efcc1..95c6151ed10c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
>  		ti,clkbuf-sel = <0x7>;
>  		ti,trm-icp = <0x8>;
>  		dma-coherent;
> -		/* Masking support for SDR104 capability */
> -		sdhci-caps-mask = <0x00000003 0x00000000>;
>  	};
>  
>  	main_navss: bus@30000000 {

-- 
Regards
Vignesh