Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762809AbXIXTa1 (ORCPT ); Mon, 24 Sep 2007 15:30:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753331AbXIXTaQ (ORCPT ); Mon, 24 Sep 2007 15:30:16 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:34438 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756604AbXIXTaO (ORCPT ); Mon, 24 Sep 2007 15:30:14 -0400 Message-ID: <46F8101E.1050000@freescale.com> Date: Mon, 24 Sep 2007 14:29:34 -0500 From: Scott Wood User-Agent: Mozilla-Thunderbird 2.0.0.4 (X11/20070828) MIME-Version: 1.0 To: Dan Malek CC: Jochen Friedrich , linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org Subject: Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver References: <46F6C9DC.90008@scram.de> <46F7DE85.7000401@freescale.com> <46F7EE95.1040509@scram.de> <46F80049.2030509@freescale.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 19 Dan Malek wrote: > > On Sep 24, 2007, at 11:22 AM, Scott Wood wrote: > >> cpmp is a physical address on arch/ppc? > > No, it's a well known ioremaped() address into the IMMR space. Maybe that's how it was, but the current code initializes it (more or less) directly with IMAP_ADDR, which also gets fed into ioremap. One of the two has got to be wrong. -Scott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/