Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <ZC6OHBjdwBdT4sSb@xpf.sh.intel.com>
In-Reply-To: <ZC6OHBjdwBdT4sSb@xpf.sh.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 6 Apr 2023 13:26:36 +0300
Message-ID: <CAHp75VebjkJZkC=0ubGSVYm75M6sFAHt3kq=WqqfDmtBJrvVDQ@mail.gmail.com>
Subject: Re: [gpio kself-test & bisect] gpio-mockup.sh kslef-test failed in v6.3-rc5
To:     Pengfei Xu <pengfei.xu@intel.com>
Cc:     christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org,
        heng.su@intel.com, linux-kselftest@vger.kernel.org, lkp@intel.com,
        linux-gpio@vger.kernel.org, john.fastabend@gmail.com,
        edumazet@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 6, 2023 at 12:15=E2=80=AFPM Pengfei Xu <pengfei.xu@intel.com> w=
rote:
>
> Hi Christophe Leroy and gpio experts,
>
> Greeting!
>
> Platform: Tigerlake-H and so on x86 platforms
>
> All detailed info is in link: https://github.com/xupengfe/syzkaller_logs/=
tree/main/issue_bisect/230406_gpio-mockup_kselftest_failed_bisect_v63rc5
> Bisect info: https://github.com/xupengfe/syzkaller_logs/blob/main/issue_b=
isect/230406_gpio-mockup_kselftest_failed_bisect_v63rc5/bisect_info.txt
>
> gpio-mockup.sh kslef-test failed in v6.3-rc5 kernel.
> gpio-mockup.sh(gpio overflow test) in kself-test could reproduce this iss=
ue:
> cd linux/tools/testing/selftests
>  1.  ./kselftest_install.sh
>  2.  cd  linux/tools/testing/selftests/kselftest_install/gpio
>  # ./gpio-mockup.sh
>  1.  Module load tests
>  1.1.  dynamic allocation of gpio
>  2.  Module load error tests
>  2.1 gpio overflow
>  test failed: unexpected chip - gpiochip1
>  GPIO gpio-mockup test FAIL
>
> And the simplified steps to reproduce this issue are as follow:
> "
> # Load gpio_mockup with overflow ranges -1,1024:
> modprobe -q gpio_mockup gpio_mockup_ranges=3D"-1,1024"
>
> # Check is there some Call Trace generated in dmesg
> dmesg | grep -C 5 Call
>
> # Should not generate any gpiochip folder like /sys/kernel/debug/gpio-moc=
kup/gpiochip1
> # Because load gpio_mockup with overflow ranges -1,1024
> find "/sys/kernel/debug/gpio-mockup/" -name gpiochip* -type d | sort
>
> # Unload the gpio_mockup module
> modprobe -r gpio_mockup
> # Check is there "Call Trace" generated in dmesg
> dmesg | grep -C 5 Call
> "
>
> Actually the judgement "gpio-mockup.sh" test/bisect judgement point is th=
at:
> Should not generate any gpiochip folder like
> /sys/kernel/debug/gpio-mockup/gpiochip1 after load gpio_mockup with overf=
low
> ranges -1,1024.
>
> I met gpio-mockup.sh test failed but there is no any "Call Trace" dmesg i=
nfo
> sometimes.
>
> So the shortest check steps are as follow:
> "
> 1. modprobe -q gpio_mockup gpio_mockup_ranges=3D"-1,1024"
> After above gpio_mockup module loaded with overflow range "-1,1024":
> Correct behavior as previous v6.1 or older kernel:"gpio should not load "=
gpiochip1" due to overflow range -1,1024";
> Wrong behavior in v6.3-rc5 kernel: "gpio *load* "gpiochip1" with overflow=
 range -1,1024 and "gpiochip1" should not be loaded".
> The underlying problem was already buried here.
>
> 2. Could use below command to check if "gpiochip1" generated:
> As before v6.1,  there was no "/sys/kernel/debug/gpio-mockup/gpiochip1" s=
ysfs folder due to overflow range -1,1024";
> Wrong behavior in v6.3-rc5 kernel: "/sys/kernel/debug/gpio-mockup/gpiochi=
p1" sysfs folder generated as follow command check:
> # find "/sys/kernel/debug/gpio-mockup/" -name gpiochip* -type d | sort
> /sys/kernel/debug/gpio-mockup/gpiochip1
> If there is gpiochip* generated, gpio-mockup.sh kself-test would be faile=
d also.
> "
>
> Bisected and found the bad commit was:
> "
> 7b61212f2a07a5afd213c8876e52b5c9946441e2
> gpiolib: Get rid of ARCH_NR_GPIOS
> "
> And after reverted the above commit on top of v6.3-rc5 kernel, above
> gpio-mockup.sh kself-test could pass and this issue was gone.
>
> Now gpio-mockup.sh kself-test is failed on almost all x86 platform from
> v6.2 cycle mainline kernel.
>
> I hope above info is helpful to solve the "gpio-mockup.sh kself-test fail=
ed"
> problem.

Thank you for the report and full analysis of the root cause. I think
we may fix the test script however the gpio-mockup is obsoleted and
should be actually replaced with tests again gpio-sim.

--=20
With Best Regards,
Andy Shevchenko