Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c12fcff3-d9aa-2d8d-7053-224207defc26@redhat.com>
Date:   Thu, 6 Apr 2023 12:44:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] platform/x86: think-lmi: Remove unnecessary casts for
 attributes
Content-Language: en-US, nl
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Mark Pearson <markpearson@lenovo.com>,
        Mark Gross <markgross@kernel.org>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230329-think-lmi-attrs-v1-1-5794f2367cc2@weissschuh.net>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230329-think-lmi-attrs-v1-1-5794f2367cc2@weissschuh.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 3/29/23 06:50, Thomas Weißschuh wrote:
> These casts are unnecessary and could break if structure layouts are
> randomized or implementation details change.
> Use the proper syntax that works without casts.
> 
> Also remove some unnecessary braces that checkpatch complains about.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/think-lmi.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
> index c816646eb661..02bfd6e3fed2 100644
> --- a/drivers/platform/x86/think-lmi.c
> +++ b/drivers/platform/x86/think-lmi.c
> @@ -862,19 +862,18 @@ static umode_t auth_attr_is_visible(struct kobject *kobj,
>  	struct tlmi_pwd_setting *setting = to_tlmi_pwd_setting(kobj);
>  
>  	/* We only want to display level and index settings on HDD/NVMe */
> -	if ((attr == (struct attribute *)&auth_index) ||
> -			(attr == (struct attribute *)&auth_level)) {
> +	if (attr == &auth_index.attr || attr == &auth_level.attr) {
>  		if ((setting == tlmi_priv.pwd_hdd) || (setting == tlmi_priv.pwd_nvme))
>  			return attr->mode;
>  		return 0;
>  	}
>  
>  	/* We only display certificates on Admin account, if supported */
> -	if ((attr == (struct attribute *)&auth_certificate) ||
> -			(attr == (struct attribute *)&auth_signature) ||
> -			(attr == (struct attribute *)&auth_save_signature) ||
> -			(attr == (struct attribute *)&auth_cert_thumb) ||
> -			(attr == (struct attribute *)&auth_cert_to_password)) {
> +	if (attr == &auth_certificate.attr ||
> +	    attr == &auth_signature.attr ||
> +	    attr == &auth_save_signature.attr ||
> +	    attr == &auth_cert_thumb.attr ||
> +	    attr == &auth_cert_to_password.attr) {
>  		if ((setting == tlmi_priv.pwd_admin) && tlmi_priv.certificate_support)
>  			return attr->mode;
>  		return 0;
> 
> ---
> base-commit: fcd476ea6a888ef6e6627f4c21a2ea8cca3e9312
> change-id: 20230329-think-lmi-attrs-994abb757e98
> 
> Best regards,