Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "Bjorn Helgaas" <bhelgaas@google.com>
CC:     Linus Torvalds <torvalds@linux-foundation.org>,
        Christoph Hellwig <hch@infradead.org>
Subject: revert bab65e48cb064 PCI/MSI Sanitize MSI-X checks
Thread-Topic: revert bab65e48cb064 PCI/MSI Sanitize MSI-X checks
Thread-Index: AdlodgFkFYa3Wd45RlGJwWEgKJXFDw==
Date:   Thu, 6 Apr 2023 11:05:14 +0000
Message-ID: <caca6879210940428e0aa2a1496907ab@AcuMS.aculab.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

The change in bab65e48cb064 breaks pci_enable_msix_range().
The intent is to optimise the sanity checks, but it is
somewhat overenthusiastic.

The interface allows you to ask for a lot of vectors and
returns the number that were allocated.
However, after the change, you can't request a vector
that is higher than the largest the hardware supports.
Which makes that rather pointless.

So code like:
	for (i = 0; i < 16; i++)
		msix_tbl[i].entry = i;
	nvec = pci_enable_msix_range(dev, msix_tbl, 1, 16);
Now returns -22 if the hardware only supports 8 interrupts.

Previously it returned 8.

I can fix my driver, but I suspect that any code that relies
on a smaller number of vectors being returned is now broken.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)