Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 19:32:34 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>
CC:     Len Brown <len.brown@intel.com>, Ye Bin <yebin10@huawei.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Yifan Li <yifan2.li@intel.com>,
        Pavan Kondeti <quic_pkondeti@quicinc.com>
Subject: Re: [PATCH] PM: hibernate: Do not get block device exclusively in
 test_resume mode
Message-ID: <ZC6t0ubwcNekbBr1@chenyu5-mobl1>
References: <20230401165540.322665-1-yu.c.chen@intel.com>
 <CAJZ5v0j704JoCPTrDO1jTHwP1+8NVdLk7hym5036uFcfo7YHXQ@mail.gmail.com>
 <ZC4zMv1SCiUMbcqs@chenyu5-mobl1>
 <CAJZ5v0j5PWsF6zCCVMRW59WevYLvWiBk82U4MpxqWdFnAcrqrQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJZ5v0j5PWsF6zCCVMRW59WevYLvWiBk82U4MpxqWdFnAcrqrQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eng4L2hIWmJVUHBPZUg2TDJ2WTJYd29DYmVHSFNJZm1iUU9ZY2FneGRTdW9X?=
 =?utf-8?B?TFBGVWdDQ1Rvb2dURlllTW9JT0UrbUFNVWdoeDc0cmFWT2trTzFtM2hnbFRI?=
 =?utf-8?B?RWhrSkVDMmNwQW9zVU1CSFVudjd4bWo4RHRyWjE1dDBtV2V2SGkvQzljMWNH?=
 =?utf-8?B?aTF2U2E2S2lrNzQyVmw2L0ZMZ1NrQ096bUZpczk0ekNOakFCdlluUkNOSGZM?=
 =?utf-8?B?MXRnS2NvRFlnUjI4MnRQN2t6bXA1MVRFTGpxUExSUUZaS1J1TCtDV1VrZ1hV?=
 =?utf-8?B?SGtsVWp1dDFiRGFiR3NKRVIrR1A0VEhVRDlkNnltbmo5cEtid1lDU2VicW9m?=
 =?utf-8?B?TGpQQUN4VjNDalB3emxJNEl1NUNuSUp5OStCWUpZcDU3TVdYOXZxOC9EVFMz?=
 =?utf-8?B?WUcwQTFEclcwZ1poVVRwMWJaQmp0dEo0OE1RbnlVRHZ3TnlWNDFOdDd5NGMx?=
 =?utf-8?B?ZHE5MUsxK2k5eU1MTWtxNkxQZjBvNlptTjV4S2t0TmsrelVuRngyMmxJcklz?=
 =?utf-8?B?Y2szeTB5OWVnWDJrZ084TmhYanhIWjdNcUZoY3poejN1bW0ra3FwT0tWZVdr?=
 =?utf-8?B?WXpZdFJJb25LK29aVUdMTnZIV0NNbElzd0xnZWp5L2hTbmMwd3Y0ZEpKcG0y?=
 =?utf-8?B?RG1iTUlweXJabDFaOXI2VU44Vko1V3FKQjNHaVI1ZlZYT2VLcUJyd0hTZVlV?=
 =?utf-8?B?M2FRUmxvTVBJT2c5SXhrWFFmWVV4dDhleFdyaGZhd0FEb2N1WCsxNjdnUlQ4?=
 =?utf-8?B?ZjBBNW1sQ005elFqV2FleXZSY3laaUJZUTdmSUl4QUVqa016eVBMOEtFbmxV?=
 =?utf-8?B?SytmQm9OSmdxU2c2NllJb1FBQTJJbTFlVHU0ZnFhQUJiNjM1Y0pPbVUrNXpN?=
 =?utf-8?B?VXJkRFozRXgwSHNOWmZTRTljRlFZSGludGVhREc1aUw2WXVGWmcray9VU0xI?=
 =?utf-8?B?TWk0ZFM0Q0Y0aGUzTlRaTzZncXVOUm9lUHZ1dGlBS3lKMEJmK3l2SkhwNzRk?=
 =?utf-8?B?ZlF5c0J5d2QvajNROWlHTVpyMmw5aUxmNm5yTzRXcXhoc3hpZ3Z4SUx4b0lR?=
 =?utf-8?B?ODYvRlRMM0ZiZnJwYVhZbVBOcisvTzhMa09VbktwYkdDU1FPWDZnZDhLZTdP?=
 =?utf-8?B?eFZKdVFvTUxta0ZUNFFZeHB1RGJCY2VmbTNjb2JrM2dlajRUTkVHT0JaaDNO?=
 =?utf-8?B?MlNhVHhoUzE1c0hqb1hoQW9jZ2NUT1dTNk5uQi9WYVVjeDlDbUhoRlVBK0xL?=
 =?utf-8?B?REJucFNQNC83dXpOejgvOCtqNEVjdmNXS3NScTY3djY1aDZoQjlpdkI3Q3Zi?=
 =?utf-8?B?UlFPRGg2MjNHZUcrQjcvTlJQcmhZMksxOE9IRUY3OVBNS2ZreE1Eb3hYQS96?=
 =?utf-8?B?TGhldC8vLzdRM0lIR2FBOHpiR0Vxdi8za2k2VWtxZ2o1UTBlaCtKNHY1UG1Y?=
 =?utf-8?B?c3NUUlRtNERqMkkvM0U2bjlpQU9Sbk9VUFcxZDEyRUVHUDlKQjZ5K1F4TWcr?=
 =?utf-8?B?TEdEdGw4Vmllc3Ard21rZG1oWWVxYXl5ZWs1WnIxTENuejZUL3NxdUlXeTha?=
 =?utf-8?B?QTk1MGEwUzBlRmFMYURwY1hrc01VaExhYzEwcUcvN2dEL0oyNk1zQWJMSnVt?=
 =?utf-8?B?QnhHZlVVek5DcXZQL2RnNUNmbmp3QWR0S3YxbGxja1g4WXFmeWM3ZTl4WHdj?=
 =?utf-8?B?dmlyRUxCTjZIdk9xbHlHMDMvWU1MaE9aNDh2TUFZUmZBSm12ang0TGwrSXA0?=
 =?utf-8?B?QlRoYUZzSXhTZVhEVVpWMU41Tjc4a1dKZVl5Mndqci9obzh2ZWkvRzc5YTBK?=
 =?utf-8?B?V1hpUjhhMm4yeWdYbGlNR25udmVaU0RpdWpRRmdJYzBKcGxySEZVRUt3RldS?=
 =?utf-8?B?VXJ1dUxGTTI1SENlNm1XaFJaL0ZOWE1SQjNkL0dOMmVsRi9yM2FmNzR4ejlm?=
 =?utf-8?B?SHhBWEtpdmVuY05WQjkxbG1aSFRHSk1NYThsNnJDaXJGT0N3NFBSNmpWaUt2?=
 =?utf-8?B?R2RiYm9zUmdnVXUwc0hNb0RwNkE2cHRiWnc1WG5TdVYxVWxkL1JtV0pjMWFt?=
 =?utf-8?B?MFFjdHZlNzg0VEtIWWRpQkRZQkNSVlJ4SVQ2dHBVYldyWUtPMmQyZmxNSHFG?=
 =?utf-8?Q?HDG5DYoHcTw5h6ev1A8lpEzad?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70bc3931-e611-46cd-ae73-08db3692a526
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 11:32:46.8878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yYlhE4uZBeI6S/bQZ0opd6ZMPlM/MyhLFovjObgbxY4o62YeeSJ7qVae4IxK4pVCzwRxw+ZyKobxl0Io2hFauQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6552
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-04-06 at 12:02:01 +0200, Rafael J. Wysocki wrote:
> On Thu, Apr 6, 2023 at 4:49 AM Chen Yu <yu.c.chen@intel.com> wrote:
> >
> > Hi Rafael,
> > On 2023-04-05 at 20:37:32 +0200, Rafael J. Wysocki wrote:
> > > On Sat, Apr 1, 2023 at 10:59 AM Chen Yu <yu.c.chen@intel.com> wrote:
> > > >
> > > > The system refused to do a test_resume because it found that the
> > > > swap device has already been taken by someone else. Specificly,
> > > > the swsusp_check()->blkdev_get_by_dev(FMODE_EXCL) is supposed to
> > > > do this check.
> > > >
> > > > Steps to reproduce:
> > > >  dd if=/dev/zero of=/swapfile bs=$(cat /proc/meminfo |
> > > >        awk '/MemTotal/ {print $2}') count=1024 conv=notrunc
> > > >  mkswap /swapfile
> > > >  swapon /swapfile
> > > >  swap-offset /swapfile
> > > >  echo 34816 > /sys/power/resume_offset
> > > >  echo test_resume > /sys/power/disk
> > > >  echo disk > /sys/power/state
> > > >
> > > >  PM: Using 3 thread(s) for compression
> > > >  PM: Compressing and saving image data (293150 pages)...
> > > >  PM: Image saving progress:   0%
> > > >  PM: Image saving progress:  10%
> > > >  ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
> > > >  ata1.00: configured for UDMA/100
> > > >  ata2: SATA link down (SStatus 0 SControl 300)
> > > >  ata5: SATA link down (SStatus 0 SControl 300)
> > > >  ata6: SATA link down (SStatus 0 SControl 300)
> > > >  ata3: SATA link down (SStatus 0 SControl 300)
> > > >  ata4: SATA link down (SStatus 0 SControl 300)
> > > >  PM: Image saving progress:  20%
> > > >  PM: Image saving progress:  30%
> > > >  PM: Image saving progress:  40%
> > > >  PM: Image saving progress:  50%
> > > >  pcieport 0000:00:02.5: pciehp: Slot(0-5): No device found
> > > >  PM: Image saving progress:  60%
> > > >  PM: Image saving progress:  70%
> > > >  PM: Image saving progress:  80%
> > > >  PM: Image saving progress:  90%
> > > >  PM: Image saving done
> > > >  PM: hibernation: Wrote 1172600 kbytes in 2.70 seconds (434.29 MB/s)
> > > >  PM: S|
> > > >  PM: hibernation: Basic memory bitmaps freed
> > > >  PM: Image not found (code -16)
> > > >
> > > > This is because when using the swapfile as the hibernation storage,
> > > > the block device where the swapfile is located has already been mounted
> > > > by the OS distribution(usually been mounted as the rootfs). This is not
> > > > an issue for normal hibernation, because software_resume()->swsusp_check()
> > > > happens before the block device(rootfs) mount. But it is a problem for the
> > > > test_resume mode. Because when test_resume happens, the block device has
> > > > been mounted already.
> > > >
> > > > Thus remove the FMODE_EXCL for test_resume mode. This would not be a
> > > > problem because in test_resume stage, the processes have already been
> > > > frozen, and the race condition described in
> > > > Commit 39fbef4b0f77 ("PM: hibernate: Get block device exclusively in swsusp_check()")
> > > > is unlikely to happen.
> > > >
> > > > Fixes: 39fbef4b0f77 ("PM: hibernate: Get block device exclusively in swsusp_check()")
> > > > Reported-by: Yifan Li <yifan2.li@intel.com>
> > > > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > > > ---
> > > >  kernel/power/hibernate.c | 18 +++++++++++-------
> > > >  kernel/power/power.h     |  2 +-
> > > >  kernel/power/swap.c      | 10 +++++++---
> > > >  3 files changed, 19 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> > > > index 793c55a2becb..f50456e72f0a 100644
> > > > --- a/kernel/power/hibernate.c
> > > > +++ b/kernel/power/hibernate.c
> > > > @@ -683,22 +683,26 @@ static void power_down(void)
> > > >                 cpu_relax();
> > > >  }
> > > >
> > > > -static int load_image_and_restore(void)
> > > > +static int load_image_and_restore(bool safe)
> > >
> > > It is not very clear why the argument is called "safe".
> > >
> > > Either this needs to be explained in a comment, or I would just call
> > > it "exclusive" and rework the checks accordingly.
> > >
> > OK, I can change it to "exclusive". Pavan proposed to add a global
> > variable snapshot_testing to indicate that the system is in test_resume mode,
> > and we can check this flag to decide whether to open the block device
> > exclusively or not. Then we don't have to add parameter for load_image_and_restore()
> > nor swsusp_check(). Could you please give advice whether this is applicable?
> 
> Well, in that case, why don't you simply check pm_test_level?
>
Sorry I overlooked the code, the snapshot_testing is already there.
I'll change the code accordingly.

thanks,
Chenyu 
> > If yes I can change the code accordingly, otherwise I can change the "safe"
> > to "exclusive" and add some comments.