Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 13:43:14 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        hns@goldelico.com
Subject: Re: [PATCH 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c
 LED driver
Message-ID: <20230406134314.25f8d3a0@aktux>
In-Reply-To: <7d8c558f-0d21-91ed-ecd0-cac079d366ee@gmail.com>
References: <20230406060825.103187-1-andreas@kemnade.info>
        <20230406060825.103187-3-andreas@kemnade.info>
        <7d8c558f-0d21-91ed-ecd0-cac079d366ee@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Matti,

thanks for the review:

On Thu, 6 Apr 2023 11:57:15 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> > +	priv->regmap = devm_regmap_init_i2c(client, &bd2606mvv_regmap);
> > +	if (IS_ERR(priv->regmap)) {
> > +		err = PTR_ERR(priv->regmap);
> > +		dev_err(dev, "Failed to allocate register map: %d\n", err);
> > +		return err;
> > +	}
> > +
> > +	i2c_set_clientdata(client, priv);
> > +  
> 
> The IC seems to have an enable pin. I think you might add the 
> enable-gpio in dt-bindings and try to (optionally) get and enable it here.

It has an enable pin. I would prefer to just have the binding as complete as
possible and have it added later in the driver by someone needing it
since I cannot test that.

Regards,
Andreas