Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     gregkh@linuxfoundation.org
Cc:     chao@kernel.org, damien.lemoal@opensource.wdc.com,
        frank.li@vivo.com, huyue2@coolpad.com, jefflexu@linux.alibaba.com,
        jth@kernel.org, linux-erofs@lists.ozlabs.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        naohiro.aota@wdc.com, rafael@kernel.org, xiang@kernel.org
Subject: Re: [PATCH 2/3] erofs: convert to use kobject_is_added()
Date:   Thu,  6 Apr 2023 20:07:16 +0800
Message-Id: <20230406120716.80980-1-frank.li@vivo.com>
In-Reply-To: <2023040635-duty-overblown-7b4d@gregkh>
References: <2023040635-duty-overblown-7b4d@gregkh>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I5fmB+06wjRU5CDcW8wHymm8YwX+fhTdIcaUfflNi+olUk14sqfJuQoRCDwC?=
 =?us-ascii?Q?w0ndce3QylzEDR9I7jT1MuK+GZ93SGU0PoB2rpIQW9RZKjqAcST73dCPfHtP?=
 =?us-ascii?Q?749+Rmg9f+Ms1REu2VRXScKBehbB5caxZ431JSib5naRdJLhq+bW9aM+U7Br?=
 =?us-ascii?Q?xAbKfgugdG+BwCU0b5nRGwrs2GhOpwThrAu8rSKQZFeqn1BA/KkV6c79utHj?=
 =?us-ascii?Q?zbrR2GrZQt4uqsRgi1LKwFtdxJiblbUq+c3oqmPjQ/9+PRFfrfAx33ZJdm38?=
 =?us-ascii?Q?9XT6w04ERKjQGygvBmSiw2oxFWl1YJW5EQuLA1kDGnSrE2X3by+7+Vg6YjBW?=
 =?us-ascii?Q?HmbTOBur7uujZ6VeKUDJPSYk82leDn4LV40OvnqkGU+vFUuh4B/RfEcEzijA?=
 =?us-ascii?Q?6wPiA5ABlMm4nIKeKt3qL7pMoQ0UB+Ea7l+b2VCpC8mVk3uVPhsTITCrUC/z?=
 =?us-ascii?Q?kVOglGpxc09yZ81Fq9BBFSIjExIYh0HcqoTeylEStl3o+8bJ2ayHx4Z9SdGw?=
 =?us-ascii?Q?BHLw4RVx2VcwlsKGTwxCTKcu1m2mZM90g62VP6yS/lWwETCJ04a6/jIFWyXl?=
 =?us-ascii?Q?9fYHf2DIvkNjgeXp9hbvzdqFtAED6cTgOO/hnLuDxhOfiZr7ib8sg1veQ1lQ?=
 =?us-ascii?Q?cxDbOH+4cFJfNlwUE0CWubZeEvcl42v4iiHSU/nHrhbvfeLdh4Vn/t+os9Od?=
 =?us-ascii?Q?cus711/QBVzwSbja+M6L9ulfI/VTbrdtuf213T5yrIjAb0KPxV+tAk/+CnIP?=
 =?us-ascii?Q?cjRQwpJIHdwH5VkyJFj9B+sQZqN2JaJXLjxKwMTUt/uRoqV8Dmw9dZ2j5ZrT?=
 =?us-ascii?Q?MsqlJW37RFEIbqR/qnxcMCqKgyxq2IsAFajXTDOEqzZSJPsiIEvrDi4L0ZKd?=
 =?us-ascii?Q?wn2bViVNU1rqJWwc4ON+h9VKNp4KqewfBxF0WdW0L6D4POqCpguFzxuVFV/h?=
 =?us-ascii?Q?C3H9v+X/2sRlhqQDWv+1NBktv5YuinRvD8oE1gf+LeTCerPesF850GNITbF+?=
 =?us-ascii?Q?mU8u+cqc/VP8jEGN6AN/yClKRek6cbOwjZ1O4OA0KcoK96o0qkk7YJJAG4Pa?=
 =?us-ascii?Q?8udeMQlX9VAQjtUdCajGq+KOr2HbGKUjyt2OawLmxNZ83Nsu+yMrqECYVBQY?=
 =?us-ascii?Q?WPU3aq2pEHLQEXH1QukdFAMpL1vpBX5bJ9OsDIL9Ys47C7xz3aKKvaExbjiu?=
 =?us-ascii?Q?y1i11A17F2+qd9DtoiaN5RMOF+9KZtr2sNbRDfQ0eVOerzcF4AolmeYmAZiL?=
 =?us-ascii?Q?yjV1BxMLauyu7oq1x4Pyip0Rl08+m1WHk6QtnRlsLDK/guUjcxv7IK4qqnms?=
 =?us-ascii?Q?ZrmCNYK9FPmMPxEbx9nRpn2ZkDMIPsidp1rMR8oGo9meFpGA7nJjkUcA2Ckf?=
 =?us-ascii?Q?eOxmNTjrsT/LnjNaV2d1lEf0YlnuGQKssJyN/ocFdXJ35oJhfC3v8OwmbfdQ?=
 =?us-ascii?Q?a3nZTscC9xOHdTKTkfFZzMbjr6PVsm8tEF3PAapRvfdZ8DB/gQv/IpcTnI3r?=
 =?us-ascii?Q?N9GYrYiKksLOACoPQaL5cmKiWILSr2NMJbFmVOqaHjCUXBzjKRmKGO07NDyc?=
 =?us-ascii?Q?JDidaJbPtCQLv0jd9VXttJna3TfvIIa/FBaseBP6?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9327f43-e919-4449-4969-08db36977cc3
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 12:07:26.6655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c4eGhBazu+NgFBmWG1cBIvQYIG8wdXJFszf2xXb/lIKQBst7Aj/uqqq6U+efaucV07L4mABU+BfcbuJz60fcLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5461
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Meta-comment, we need to come up with a "filesystem kobject type" to get
> rid of lots of the boilerplate filesystem kobject logic as it's
> duplicated in every filesystem in tiny different ways and lots of times
> (like here), it's wrong.

Can we add the following structure?

struct filesystem_kobject {
        struct kobject kobject;
        struct completion unregister;
};

w/ it, we can simplify something:

1. merge init_completion and kobject_init_and_add

2. merge kobject_put and wait_for_completion

3. we can have a common release func for kobj_type release

MBR,
Yangtao