Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b80921e2-9c77-a0dd-9b70-f2ad805f71ff@ieee.org>
Date:   Thu, 6 Apr 2023 07:12:17 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] staging: greybus: drop loopback test files
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
        Alex Elder <elder@kernel.org>,
        Jack Schofield <schofija@oregonstate.edu>,
        Vaibhav Nagare <vnagare@redhat.com>,
        greybus-dev@lists.linaro.org
References: <2023040613-huntsman-goldsmith-4a41@gregkh>
From:   Alex Elder <elder@ieee.org>
In-Reply-To: <2023040613-huntsman-goldsmith-4a41@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/23 3:18 AM, Greg Kroah-Hartman wrote:
> The greybus loopback test tool does not belong burried down in a
> driver-specific directory.  If it is needed, it should be somewhere
> else, like in the testing directory.  But as the loopback driver is
> probably never going to be merged out of the staging directory, let's
> just delete the test alltogether for now.  If it's needed in the future,
> it can be brought back with a revert.
> 
> Also, having an Android.mk file in the kernel source tree breaks some
> Android build systems when trying to build from a read-only source tree,
> the report of which prompted this being a good reason to remove it as
> well.
> 
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Jack Schofield <schofija@oregonstate.edu>
> Cc: Vaibhav Nagare <vnagare@redhat.com>
> Cc: greybus-dev@lists.linaro.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

That's a surprising amount of code.  And perhaps there
are better ways of exposing this type of information.
Anyway, no objection here.

Acked-by: Alex Elder <elder@linaro.org>

> ---
>   drivers/staging/greybus/tools/.gitignore      |   2 -
>   drivers/staging/greybus/tools/Android.mk      |  10 -
>   drivers/staging/greybus/tools/Makefile        |  33 -
>   drivers/staging/greybus/tools/README.loopback | 198 ----
>   drivers/staging/greybus/tools/lbtest          | 169 ---
>   drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
>   6 files changed, 1391 deletions(-)
>   delete mode 100644 drivers/staging/greybus/tools/.gitignore
>   delete mode 100644 drivers/staging/greybus/tools/Android.mk
>   delete mode 100644 drivers/staging/greybus/tools/Makefile
>   delete mode 100644 drivers/staging/greybus/tools/README.loopback
>   delete mode 100755 drivers/staging/greybus/tools/lbtest
>   delete mode 100644 drivers/staging/greybus/tools/loopback_test.c
>