Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17bc6dd1-956e-e90c-4028-8bd3044bcb90@gmail.com>
Date:   Thu, 6 Apr 2023 15:17:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c
 LED driver
Content-Language: en-US, en-GB
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        hns@goldelico.com
References: <20230406060825.103187-1-andreas@kemnade.info>
 <20230406060825.103187-3-andreas@kemnade.info>
 <7d8c558f-0d21-91ed-ecd0-cac079d366ee@gmail.com>
 <20230406134314.25f8d3a0@aktux>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <20230406134314.25f8d3a0@aktux>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/23 14:43, Andreas Kemnade wrote:
> Hi Matti,
> 
> thanks for the review:
> 
> On Thu, 6 Apr 2023 11:57:15 +0300
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> 
>>> +	priv->regmap = devm_regmap_init_i2c(client, &bd2606mvv_regmap);
>>> +	if (IS_ERR(priv->regmap)) {
>>> +		err = PTR_ERR(priv->regmap);
>>> +		dev_err(dev, "Failed to allocate register map: %d\n", err);
>>> +		return err;
>>> +	}
>>> +
>>> +	i2c_set_clientdata(client, priv);
>>> +
>>
>> The IC seems to have an enable pin. I think you might add the
>> enable-gpio in dt-bindings and try to (optionally) get and enable it here.
> 
> It has an enable pin. I would prefer to just have the binding as complete as
> possible and have it added later in the driver by someone needing it
> since I cannot test that.

Fair enough. Thanks for working with this!

Yours,
	-- Matti


-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~