Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2154834rwl; Thu, 6 Apr 2023 06:38:24 -0700 (PDT) X-Google-Smtp-Source: AKy350YJRrSoxqOqPlLVHOBt8fXtCKN4bmYReBR7uRFnsWaXnzfvyk8SHzygqUr8mM6wKtl661ox X-Received: by 2002:a05:6402:161a:b0:4aa:a280:55b5 with SMTP id f26-20020a056402161a00b004aaa28055b5mr4486998edv.20.1680788304521; Thu, 06 Apr 2023 06:38:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680788304; cv=none; d=google.com; s=arc-20160816; b=0wKQjhcM1t70g+s0W7OSjbcoFqEsTN07QVvG56L0fkmtFedqPKJsCRHXaRrLNKXYsZ DYv+QwaNMxjEDoMlrGDLhl3D5a6vmf0Z+LtAqxraWnymG8Z36bctnPHp/mT9hcyPhYve k9bgz/qCcezwbX82zG8WdrsDsrI6ZOK+xOfFhP6eWaT1MDYj8FQmz30OjXxBbNEJoKg7 53/qEy3L2a15TMZp7WBFL0COKSLthIVDXfrFPj1Ms6ijd+JaoYOyYwgnHXAGOOuFQ8h0 MhgeRNxGCtyPmtAhNZHPQTG/21HMf1ZEQLp8qQG+/AjUgKOo2S2SJTfzSoKZYQYa+uL3 9O7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Nd3XkTPolwnpqLUE3NgrOTALtPa5jjJD1/nKvlAaz2Y=; b=sBPMeZr/B+dPytgYVhBdmZ0Ejl77mIB3I3ENUxMcomPN2JKsoruT1xxnGOh1gfmCP2 JseVHSzVd3kgXI5ZyqkjpgtOJ8x+8t9toq3ob1a6ys7Yue6TNF5smYlHfErFUtKx1tpP k7hNqXLev6+X8xhU58W4zH6H2gsst/vvRodbX/EDi7PRCfD/S3M7Xc3bZaxCaZx5nGho O7BHWC47Wk/goQn6xad7GYNvavDj/zdT7bz95nod0fZ7tew7rOqDukJYOCb3lg0BXEyk Ik3zspEkIKxGQeSUZ7LggYS4/0AT1rPTFaopG0lFA7fJYRJ1EfAAGIwKzNgXWqIpg8mP rc3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vue8C2R2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020aa7cf03000000b00502961db46dsi1109364edy.268.2023.04.06.06.37.56; Thu, 06 Apr 2023 06:38:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vue8C2R2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238546AbjDFNbB (ORCPT + 99 others); Thu, 6 Apr 2023 09:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238128AbjDFNbA (ORCPT ); Thu, 6 Apr 2023 09:31:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53EF69768; Thu, 6 Apr 2023 06:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nd3XkTPolwnpqLUE3NgrOTALtPa5jjJD1/nKvlAaz2Y=; b=vue8C2R2wX38xDkBGmlwtFuwej Uh9YLsW/EhfXMh7OJlSlN4QIICEHntt5WzTJnGsnePbisoQVK9CJRIbgzILTTKcC9rMcoH5KSTnLC +BM4FSDOzNuPtj0pJezReU7JgYDtuX7kZBnGSJ5R6oJeKcNvAgEzHJ5cnyJl6vMuW/lwUcLdzsb+U jV4L2Sfce7s6V1mmzQ7Ujvs482g3uQ7SKnRijWGFfVXch9CHyJFxOeVVM6YM2Zd34fz6GBDK0qY8r kylhl+3KwiY5LKfmkEmzd8bEYUSWaULkGLEtIOsfwdZDai4Vh6S9T3AIUaj4NN1o1QFsneAz55xwe RYXZfkyg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkPgE-00HS2T-GH; Thu, 06 Apr 2023 13:29:34 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A336A300194; Thu, 6 Apr 2023 15:29:28 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7C90E212E36AC; Thu, 6 Apr 2023 15:29:28 +0200 (CEST) Date: Thu, 6 Apr 2023 15:29:28 +0200 From: Peter Zijlstra To: Marcelo Tosatti Cc: Frederic Weisbecker , Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode Message-ID: <20230406132928.GM386572@hirez.programming.kicks-ass.net> References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-4-ypodemsk@redhat.com> <20230405195226.GB365912@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2023 at 09:38:50AM -0300, Marcelo Tosatti wrote: > > To actually hit this path you're doing something really dodgy. > > Apparently khugepaged is using the same infrastructure: > > $ grep tlb_remove_table khugepaged.c > tlb_remove_table_sync_one(); > tlb_remove_table_sync_one(); > > So just enabling khugepaged will hit that path. Urgh, WTF.. Let me go read that stuff :/