Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     frank.li@vivo.com
Cc:     chao@kernel.org, damien.lemoal@opensource.wdc.com,
        gregkh@linuxfoundation.org, huyue2@coolpad.com,
        jefflexu@linux.alibaba.com, jth@kernel.org,
        linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, naohiro.aota@wdc.com,
        rafael@kernel.org, xiang@kernel.org
Subject: Re: [PATCH 2/3] erofs: convert to use kobject_is_added()
Date:   Thu,  6 Apr 2023 21:50:14 +0800
Message-Id: <20230406135014.75466-1-frank.li@vivo.com>
In-Reply-To: <20230406120716.80980-1-frank.li@vivo.com>
References: <20230406120716.80980-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H28vzIp2nlDLzogHG8hqqfpHwoWJU9pxwk1jbzqX7Sxu5j+m6ZzNVHKjR2Dc?=
 =?us-ascii?Q?TcvnPKkbA34SwLIbcvWVPrpd4GH+nc6GSLMjbaqtKmE/fTDEshIwjZ0OVHHQ?=
 =?us-ascii?Q?b9BUvjbSnYaYkuDC68zdcvRTykEKhzghPhVRp37WYa5yBsfb0jxFI13n69Ar?=
 =?us-ascii?Q?uwZDPHpxDD8XOc+OBVViR9S5bhTfjSM8bu/R23YbpheFDV/2y+HR39bLM+LH?=
 =?us-ascii?Q?G3d8d58UFB+1KmaPsapLWLLL691MHAv5xEPJVbK89baOdGT3Fn2b4fM/E8Qr?=
 =?us-ascii?Q?3BpDHxRiDkJgo8CKnaSfjFSaBUp5sE86KCoY3uKgvSkSryRAjBjr8QbVFIlY?=
 =?us-ascii?Q?8SiQjA2l3wdOU7VCugaKqXKMK6A7bBbNyXEi/d8saIlKUOz7NdKkYfhA9rww?=
 =?us-ascii?Q?o7cy4aDw9BC2v3fpJ+09IF7Z4FXSSdUNZYhvsitDePXqIWv584+BfbrrGVsL?=
 =?us-ascii?Q?Nohdmj/DTDbAwj2/yv1GvK5I8tGI7JconX6fqg/bU5dQRquxJJrevj9qHm1x?=
 =?us-ascii?Q?JtJ/Uh4rElFoMWXFnAh9R99cLvEsQ/rxQ6krtv5CSG0F6kHt1SmhvEYuHeye?=
 =?us-ascii?Q?gcWmU4sotbOo+gf3xwyM5GP830DBdOxugSgRNcrPi/+KerdQMBqxSYJWBWCE?=
 =?us-ascii?Q?M4wQXN5ltaceHI138eVDA1v4db61VYV8BAA8A0VzmbovM3TrnQlg5nPN0zRF?=
 =?us-ascii?Q?Tw6h5Z6MhJSIm2oq/Tpm1oCaUnqjX9VPFtLCg0822GWZPEQ1tOvCWcDz+Mh+?=
 =?us-ascii?Q?EvU7gmxxsAee113J/81Hc3laAiLAxdV8dI8/9sgXW3yTJy8VgUFsGvI7d8cG?=
 =?us-ascii?Q?EuJ6Gzg6qKGxuDIYkM0QqmdtvC5pDEzkEBl2YInnSK5Kdg7VI6N5gPRfAQ9W?=
 =?us-ascii?Q?99BORwn8DPzNuk56oQ/eYRP00AAoIs40I+3Xp8sq0mx5fgMEK+oiDCcWwAuG?=
 =?us-ascii?Q?2JCOWwyuKFe3e4ivmWjr/WGDaFsi4kGar5WC0hEJ9575aUrwoSDcafKWHok8?=
 =?us-ascii?Q?V4sPbz2u4IXvIa/QpDI0QtDF0mbVhIgxNU7lmDv3+eblj3oD5DpydfKskDMw?=
 =?us-ascii?Q?KdkciPr9KbaNNpxAuWWj3L73Fm8FuIrO8jUhH7z03WXUcIl1sci6dtK+dW9Q?=
 =?us-ascii?Q?1o4TG58kMNzU/GI3xiz+kMa2MMrbLHncJRIaO7VA+yrzd2uDr2xk6PyPrpW3?=
 =?us-ascii?Q?KaUZI9iaSgU4CMjjNy7i0tMqmwOzPiHiADAu9R9jbOvL7JXYWrT5AaT3fHMh?=
 =?us-ascii?Q?AD4i6vAMr3StXWQvl+USGY1w3CQ6/FTYQUkjtdm89fTIcTfUuLlY6tZoyUZh?=
 =?us-ascii?Q?oEzg1ULTI3krR0so4fIcrUmqzyjkxln5YZzO+87nGYDnmoaRkW/2+Tk7D0+b?=
 =?us-ascii?Q?Q2TVAdChFJx5qgeG1W1pzqgKlZgj6pfYEbxTkWpJDYyQuC7gVbHnccck4cvG?=
 =?us-ascii?Q?HqqTBQwYYnZOkf1xK7hp2tOCaDcra59dlZkco71RFagJAeYIbO1mlvXZ6L3c?=
 =?us-ascii?Q?P+gk2h7BipgxFcqNVEDi7vs7JjNtIdBXzhmiLkz9hHVOAICZx8QMcMSXmszR?=
 =?us-ascii?Q?OyImj4s1LosQhR3+knn7HISh8aB4Y6YnajyzCwmO?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85370b1a-e5a4-44ba-7ffc-08db36a5df64
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 13:50:25.0859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lPlX4ZSuGSsQcqJ3P0siIK7nXpkZInxgSNlQfjybFzkdkhdvtCWdJWsDozY1V+F3a0pOMKWLju7HUcMyt0Xohw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6245
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Meta-comment, we need to come up with a "filesystem kobject type" to get
> > rid of lots of the boilerplate filesystem kobject logic as it's
> > duplicated in every filesystem in tiny different ways and lots of times
> > (like here), it's wrong.
> 
> Can we add the following structure?
> 
> struct filesystem_kobject {
>         struct kobject kobject;
>         struct completion unregister;
> };
> 
> w/ it, we can simplify something:
> 
> 1. merge init_completion and kobject_init_and_add
>
> 2. merge kobject_put and wait_for_completion
>
> 3. we can have a common release func for kobj_type release

It seems that the above ideas are not crazy enough, maybe we should do more.
Any ideas and suggestions are very welcome.

MBR,
Yangtao