Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 16:30:13 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, kernel-janitors@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Leon Romanovsky <leon@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Rob Herring <robh@kernel.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] niu: Fix missing unwind goto in niu_alloc_channels()
Message-ID: <ZC7XdVnYWT+o0tLf@corigine.com>
References: <20230406063120.3626731-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230406063120.3626731-1-harshit.m.mogalapalli@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PdIYZGdv/fjsAR3SUFvb6N7oDZiDCyfTOogj1Ec2dZ8B7c/LyWSRQ6QZ9xrO?=
 =?us-ascii?Q?T/BZO+xCu77wVFVjE8NVWZxqE50uBdFwHQ3Y/RYTV07CuvMlW/jRDhbch1TT?=
 =?us-ascii?Q?EJhTIN7txjZPGKE5kq+AREoRqf6EkvdI26Er4oPGcRmSeUzSVUDqD0jwHtbj?=
 =?us-ascii?Q?FjVjsicui7XbsA11LcKg0MdNvPMtwLMAQrZEA/wS44/pFDAVCkL2+tAqK4lU?=
 =?us-ascii?Q?2VbM2VekxcnN1V+xgzShAtXfF/qcNE8x9h9fVD8UP/ZKeb+v89056q2vQOMO?=
 =?us-ascii?Q?Jr4M3kyBKmbMhnoY+T4vjJ9vVdxza5JSPM/pfcaggzDsiv6tJ8kylrhGoce/?=
 =?us-ascii?Q?dgVA4NadKDN+x75jyOgaUSNSV+lntuhZ5SKQxaNPhKsz/TRmo4H/uD1WtoIt?=
 =?us-ascii?Q?3v/Pk9p0qHQL9OkaWrRFg9XJ4y3isedctVyWAD3P6YyPkztIwrHxFSHtjceO?=
 =?us-ascii?Q?4jyLwOYw8rbIyCGF6hufFNg2kY6rplQ4kanIb07vtCKDI+3BXNMVreaZauOk?=
 =?us-ascii?Q?GqkNYugtHLKTZekqte1OjmBydn5DpxAe2jXNe2pYWTWlMqnoIcuGFXY54Y5B?=
 =?us-ascii?Q?8Jy8FwiZlLte80p7US+s+VQ6AOC8T39sSmIWAEsEQb9SzJZe/5BUlezOjGrh?=
 =?us-ascii?Q?LzG4qKDePFjawZo+ixVzCv/pOrDW7I8GR7Tlj9zbCaVxRkXnWQa30E2AyH/K?=
 =?us-ascii?Q?VCHnxJ7scc78/OfdmjMZKNsDy2Ugw/a92zGMEWl/O36oT5GrZwWzGAPTXbhS?=
 =?us-ascii?Q?D/HScRzhkRto6tCBubYT9BG3u+nn6Nx1yz0zdeAkSSutzOYE12kYUNK9DQw5?=
 =?us-ascii?Q?SkZVQjFJVzbTjc+c20cobnCv1Ql5b0yePNMaLS6U/vZQrMaWd6KlWApBy9Fp?=
 =?us-ascii?Q?zRu2X7euhqy5XVqxOj/zMFsSXYoekRD7pHWi1OClTzOygHjJaMRi0SNdeDdv?=
 =?us-ascii?Q?gUMzC4V3bqDSlOoeMMja4nK2Tlx40RKiyMikf9xPvT/BX9r9h+IB24lKJJIC?=
 =?us-ascii?Q?lt4LwuWmVQ3xAK++4ZKEZpSRWC6dZKXXvOBr1gwgMLwpHAYdf6loYdXsRw+O?=
 =?us-ascii?Q?GkfSq1owLw4La+9YxfekdZbYI6GwfJyXavpqKn5eaGV6xMrrcrvneuQM0wLp?=
 =?us-ascii?Q?FToLTfnz3uplYopPPWAKVxS96/kZBqOYHS8yMwRoiE0OuYyNQu7GVdP0Ne67?=
 =?us-ascii?Q?faNAASMJ5drbaNrQ6P84XaWqdA82JI6n39QyyRd0ec6h6CjYYeRRsP79lXSw?=
 =?us-ascii?Q?8GtQQvMIeKwtkMSOwKCk77ANEry+qm2nPVyc6Sdp2x/Jzegp/bEs15o170Qv?=
 =?us-ascii?Q?1Kqcu3Sg/Pl7YQGTszY/TfttGvB1aVARG6XntTvk3cvf0DjuIaltBBZZOHxo?=
 =?us-ascii?Q?LtPuK7/5edmAeMzzGT7V+WiGBrMZzbkj4qS/EHVmWEhJsre3ND/InFiNwXN2?=
 =?us-ascii?Q?RXLnQTiBAeBl+72qlpVLB/f6D4YE2LLZcMj8adqk0ch5iVahSKiXxnvPZNvh?=
 =?us-ascii?Q?cu/tncIjMLRN4R8+w7XFMC6DyqNQEZXyRU+U/ERPcToKeaPEaRmOJYMC/wfD?=
 =?us-ascii?Q?KgbtKe3wwNDAfaTlKivhjiVhW2o3o/qkr4yKXpT+W8rstiluhwcAY1goKrkx?=
 =?us-ascii?Q?znVo2S+DMz/XKOqtBy132f0JpjrghFwHEbJ8+Hwnz367tIxmDlG8/dS5bRmJ?=
 =?us-ascii?Q?cGrEzw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d366e155-59ac-4653-b779-08db36ab72c8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 14:30:19.8674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gf/vawIsYejNrZR6SdHLU+Pg2D3fLXDTR9ezOtHtSdgv9cAKVEqulBi54KKqwvObF1jb4CK1V9cQxwitc/9jEqipBIAjpxTc8tePxi2vJ9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3844
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 05, 2023 at 11:31:18PM -0700, Harshit Mogalapalli wrote:
> Smatch reports: drivers/net/ethernet/sun/niu.c:4525
> 	niu_alloc_channels() warn: missing unwind goto?
> 
> If niu_rbr_fill() fails, then we are directly returning 'err' without
> freeing the channels.
> 
> Fix this by changing direct return to a goto 'out_err'.
> 
> Fixes: a3138df9f20e ("[NIU]: Add Sun Neptune ethernet driver.")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is purely based on static analysis. Only compile tested.

Reviewed-by: Simon Horman <simon.horman@corigine.com>