Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2247030rwl; Thu, 6 Apr 2023 07:45:38 -0700 (PDT) X-Google-Smtp-Source: AKy350b1QKrxRfqydXK401k79WA7kR4Fw5kcqdheuFMi0G9fBkL4M3xCA1vCGMSET8TeJm+JWvO2 X-Received: by 2002:a17:906:3094:b0:948:ab25:aaeb with SMTP id 20-20020a170906309400b00948ab25aaebmr6863205ejv.15.1680792338055; Thu, 06 Apr 2023 07:45:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680792338; cv=none; d=google.com; s=arc-20160816; b=O5+J/79H1ys0mK+ekXpArLzw3usMyldIZayc/MCMiiqaxXF4ogwOcSAGySMrDHC0av GB4ocd+ZCUturwgWKImyqMT49sv+rau9PYwVg5ocdP7IMD4Az+4iAqQrI+dJSmBScw/t Qol6MUuB8PoTpGcpffwOCAsHFJxGkHR+YwTmDC6jVXxpAocfod8lx8anvV89Sfu74UIZ a0ZW/2e27qZU4hZl3NhxzbBGMA2ZP+yd0IPlGHWy44PwB5z7t67P+qab4jDiYGXXaDHs E51ZKWf2z1v1qfqylx4QKSyd3kGkc3fmHUEY1N3nk94QOyhlUrfygbq/7aDaZm4n49uw X5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QwrW8zLdNa13eS+GI7R48Yjhq4tM8k3jsY8GnpkuSw0=; b=ZuJkHQMH/Jo1PQPDsBhoW9dDmiWZWMMEqyQejB3gSnd5bSYQQ8rdlPGR+Q/PDzFWGY gkoLzFJaslvZvkOy4WIXahXeMnaH9chyBF0jKQ5MydpKMq+RWXbHKV280qcwldfdhPsF pi3f5ohrF3s01LETPcl1VP41ghDls9zq27JrTDg1TtlRZTmyh8y1TTBx4q2ZxjYiY1mV zBEqOjhHAxEDLaIr4Ot+rU73/IJLaXH5l2HjylebqUFuqeyDpnRJsslW47kfSV5NNDBU 1lQR/5wuRIU6c+Zz8L4Jgywrjqo9Eq8PmXeuEPNyzzoUONt1pxdBrH9aNYHHlqDeTRdx vc6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ET29C6Lp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne18-20020a1709077b9200b0093dfd2eab9dsi1782156ejc.2.2023.04.06.07.45.06; Thu, 06 Apr 2023 07:45:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ET29C6Lp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236627AbjDFOma (ORCPT + 99 others); Thu, 6 Apr 2023 10:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238541AbjDFOmH (ORCPT ); Thu, 6 Apr 2023 10:42:07 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 698EDBB82 for ; Thu, 6 Apr 2023 07:40:34 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id b19so29207662oib.7 for ; Thu, 06 Apr 2023 07:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680792033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QwrW8zLdNa13eS+GI7R48Yjhq4tM8k3jsY8GnpkuSw0=; b=ET29C6Lpq8H1bupcLWpddJ6+WJMTZH14dq8GvOLwp89jjim1Y3wOQbN1KqFe/QpqPy be/SeTJYazGAwS7ghu4jp7LrOVKD2d4AaCEbEbnVH9aC9Id6cSyePAk+O3pWcwkdtGP8 hX9A1/oeThB47yf06fReeoYujLwL7my+G/S3t/vAOcU1Pko10MoIJGQib395m8yK5eVv JwxDASIU3jjLNyC3fRyxpePBnqpQkss9KO3phn1JTpZXqrFxg6p5h6hc2Nb8FaBvel6A gDTkiNq38ls117KNKCBhztRm5K9vpZQg/Cb/tVj08vooFX9lr00x3FhUWE8llk50q2zc wqrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680792033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QwrW8zLdNa13eS+GI7R48Yjhq4tM8k3jsY8GnpkuSw0=; b=pLgE9Y5M1TwGziS8x64sjYeZCL506enBxKXJ2p3R5qpe7EpvQ4HWkP5XohD6MdgLGx 8C6z4+Fk6WfaI+R0f6q8KjrLOwoor3bbZ78S3WPV3u7L6TsFAdlxcMdu2w8LyoSHKxSw 5qrK8AeKxdRfyTPUzBx7lpXD43SYOQuPoHpoQkeMKLnjR/jYwyRaOY5fzVwHnixTXB2J QJ54NQEVjmhjRj2nLSyqOBCnEoutYtkGSplVZZ7XEWgbPZiIKyC4MDH8LkkoZtdyorSb /9LyrOESsDpY8vT2CdF8kXqpC0ZZ2aYZk2JiyjpUbCCHwia0rtqpA9faRIix8MaFJoOS 0FUg== X-Gm-Message-State: AAQBX9c/tlwi6CEfo6UwfTs0GOI4qQQO2xw5SOZnU/GeE/zCHSriCsn6 WLeXi/nJfF8bwMII2NFXuWjJDQ== X-Received: by 2002:a05:6808:614:b0:387:715e:56b8 with SMTP id y20-20020a056808061400b00387715e56b8mr4773349oih.56.1680792033707; Thu, 06 Apr 2023 07:40:33 -0700 (PDT) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id q7-20020acaf207000000b0037d7f4eb7e8sm726209oih.31.2023.04.06.07.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:40:33 -0700 (PDT) From: William Breathitt Gray To: Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , William Breathitt Gray Subject: [PATCH v5 1/6] iio: addac: stx104: Fix race condition for stx104_write_raw() Date: Thu, 6 Apr 2023 10:40:10 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The priv->chan_out_states array and actual DAC value can become mismatched if stx104_write_raw() is called concurrently. Prevent such a race condition by utilizing a mutex. Fixes: 97a445dad37a ("iio: Add IIO support for the DAC on the Apex Embedded Systems STX104") Signed-off-by: William Breathitt Gray --- Changes in v5: none drivers/iio/addac/stx104.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/iio/addac/stx104.c b/drivers/iio/addac/stx104.c index e45b70aa5bb7..4239aafe42fc 100644 --- a/drivers/iio/addac/stx104.c +++ b/drivers/iio/addac/stx104.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -69,10 +70,12 @@ struct stx104_reg { /** * struct stx104_iio - IIO device private data structure + * @lock: synchronization lock to prevent I/O race conditions * @chan_out_states: channels' output states * @reg: I/O address offset for the device registers */ struct stx104_iio { + struct mutex lock; unsigned int chan_out_states[STX104_NUM_OUT_CHAN]; struct stx104_reg __iomem *reg; }; @@ -178,9 +181,12 @@ static int stx104_write_raw(struct iio_dev *indio_dev, if ((unsigned int)val > 65535) return -EINVAL; + mutex_lock(&priv->lock); + priv->chan_out_states[chan->channel] = val; iowrite16(val, &priv->reg->dac[chan->channel]); + mutex_unlock(&priv->lock); return 0; } return -EINVAL; @@ -351,6 +357,8 @@ static int stx104_probe(struct device *dev, unsigned int id) indio_dev->name = dev_name(dev); + mutex_init(&priv->lock); + /* configure device for software trigger operation */ iowrite8(0, &priv->reg->acr); -- 2.39.2