Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f063cfc8-805e-4d73-4c62-ff1bac4b1ed3@oracle.com>
Date:   Thu, 6 Apr 2023 11:30:14 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v3] sched/numa: Fix divide by zero for
 sysctl_numa_balancing_scan_size.
Content-Language: en-US
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
        peterz@infradead.org, vincent.guittot@linaro.org
References: <20230404182915.2264557-1-chris.hyser@oracle.com>
 <ZC5tNK50QouEvX7Q@chenyu5-mobl1>
From:   chris hyser <chris.hyser@oracle.com>
In-Reply-To: <ZC5tNK50QouEvX7Q@chenyu5-mobl1>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzRsaCtRYm83WjdWdlJpMzk5eW00OGtQWnl5VmloNDU3UXVxamROeDRMSXRH?=
 =?utf-8?B?RmwzUTAzN3dHQURqbkREdUdNcmxvbU5SeXc1ZlVXWWFYOVRlcU5hcnRsVE9J?=
 =?utf-8?B?QlI0UURNcGx4VURnMFpXdmN4NHpqNTlTQjhVUVFRbUJRVU5rNXp3SFQyM1Ji?=
 =?utf-8?B?SGpSMzVZTmlvWDQvYTZRVzd5RHZVc1B4UWhTb05jc3ZpWEx5R1AzWlJvTnFM?=
 =?utf-8?B?cmxRZUZmZE8rTGdRQjI2Qlp1L0JtTTNmdlJXOTZGTkRRaml4YW5sak85T3dv?=
 =?utf-8?B?bFlrQ3VnRWZqcnYvUlVTL0FnK1pBakp6VjQyTEtWL0ZqS2dvSUdXUTltS1Bl?=
 =?utf-8?B?VW83NE5XcjBMaHh6d2FzYUpSRk95eDlXSEF0b05hNTQzM3NvUkRQNUgwOUc3?=
 =?utf-8?B?UTdXYml5ZzI2Q29mdWY1UVFULzhFd0NjVTBZaitmNDZvTnFXbUhNV1B5c3Zr?=
 =?utf-8?B?VVNlR2drVUl1bkZKSXgwU0hNSEpYOGE5QnVXeGZDK1pYaGxLLzNHQmorOGNz?=
 =?utf-8?B?UzFwcGJtNENWUkZvV29QRlJmL0pJelBuT2s1N2FxeW5aallvUVdvVUJVdk9E?=
 =?utf-8?B?ZGgrbGVHdjFTRzRrMVpWU1ErcXVGQ21jRjcyQTlkdmxiZk1GalpUZ3REYW5Y?=
 =?utf-8?B?SzRVU1V3bmU4b2dKZDZNc3ZYdGZ4RFhoRFozaGpzMGZkV1BYdG1XNTZ1elhi?=
 =?utf-8?B?aUhXczh6bVQwa3RvbWVId05RY2poMklPZ3I4elpvZkxwWGtiRkRUQ3FaS0Zw?=
 =?utf-8?B?MG9pYWZBTnVVZzJkWWlBbjZnT0JXcW1sckxlMmEzSkRlQjUza1paRVVzSHZI?=
 =?utf-8?B?L1RrNFpucDkzK1Fmd3RUWThPb2h5NUd4c2Z1UXI3VHlWMjV6Y2ErQVhtV2VW?=
 =?utf-8?B?Sm1la1RGeWliblNkTVRVU1ladkNDaGdEY3hqZkR3L3o2cWRkVEg4UmJ0WjJx?=
 =?utf-8?B?RVlJRFlqZThNN0lRdmVjUXJmL3l0anU4QzNEVGF0QVlzUnNnMGx2elQ1eFB1?=
 =?utf-8?B?WVFnZUhNN2QxL2xwZEhwSjhZTmZtNmVFNldDMmYyOE9QbUFRd1UwOW96VDRC?=
 =?utf-8?B?aFYycDM1UG8weFhPckZQNmNMYVBjS1g2WmNGcE45aURmWlF0YU9IT083aWow?=
 =?utf-8?B?T05IL1czQ3VRcWRVUUdrZUFwL1N4TTJSQmh4YXVkZkVHdmxqWWNGejZqb3Vs?=
 =?utf-8?B?Y0JtSzBVUHFLbEtHUFo4Rm9KMVY4NGRsU0x5UHpCbWlURTNndjhETlMxNURG?=
 =?utf-8?B?YzRRMWM0dS9URVNkT3RaQTYzdXo4S0JpZ3Bld1FQNTh1dDdwamhNZTkrNFlW?=
 =?utf-8?B?VG51dVdFdkphb0ZkOTZTdUtTTDFDVWg3RHVuSVFBTjFKL3MzYlNidVJ6Y0VP?=
 =?utf-8?B?eVM4aXFlUmVCY2lkajVXV1BTcU1iV0NubGJ5UGt0bzc1TDRTd2creVp2Y3J6?=
 =?utf-8?B?Y0dZV0c2b1FxSjllcVpDVFZGaWdpWkpxV1UyVEJwMTJDbDViZXRsRTNXSnl0?=
 =?utf-8?B?cGhGdWovbUxQSnlyWk9oMXpwZytxRWJZK2NLY01Za2FxdVhkQU9GUUpsaXd0?=
 =?utf-8?B?WTk1M2M3NUFTMWZSek4zaUR2QWJpcG1nUUR4RmJjWlNGZlA2S3puSE0zTjdS?=
 =?utf-8?B?YWJXRzJFQUtiNnFveG5DelRwUmQ0ZnRDR29YL09URjZpYXN3VXdHVEgwaHNt?=
 =?utf-8?B?QzRGaXVJbjBYTFQ4WWQ1WWZVU3luWnAvYnQxcGdEL3FwcTBBaldrdDROZFdW?=
 =?utf-8?B?RjFYYTJmM1FadGoydEZjNG9zZHdBellEdEpqOE5pYWhDSEhMTjYxZ1RjV3h3?=
 =?utf-8?B?SU9UTkRwMW1IL0l1TE0valJuSUFOZkM1dTNVYjcwMzhIWmxrTXduRmhiMFht?=
 =?utf-8?B?dVpnYjJIVmFGaDBncFpvY3B5WVU1ZGk3Z3Rad2lFeTh5TkZPWVVkWGZTZ0pv?=
 =?utf-8?B?KzRkVWFOQ1YwLytLOVdhWGZlT2xtdW0yRjVwZVg5Q3hWWXVlU3pTckNwTW9n?=
 =?utf-8?B?bDh2OFZvZWJpclRpTVJnRUh3dXpaUGFyOHpadWhHbUh0QUlLbzBlRzBvZXl3?=
 =?utf-8?B?blA2dmpJb1ZGYWQyR1FMZTY0UStGQUkwaXlrbW1JanpseWx1ZG1FMS9HbFA4?=
 =?utf-8?B?S3RFRkpETjFTb1FZZmtDaVl6RzZxb0pQZkZ0dXdjaUZnQXpocjV0WERHNUl1?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: va3MWOluo+V53IGVSWnDPgI2XTj7cqZobRU12LOiECx6lkRM46kQb2qgy0UZh3mR+WyVwExpZ56QkIC3uxLQOg8LBtdarnMz6yHRE2Sis7WBSgGFg7+PClla4/EnUCLc7ufrSPSVxJgTGsvdWKdDK6vTezIDQdniD1t5wkyxPrXc2NmnF+l0GPhlkQtHKeIJYlJZtMsTg4t4r1g/CMPzkMVDd3funxuXvfJ56JaWJeppioLs78VbB54JUu3apMiGSk8H1r4WbyN+fVbtYggnZ6SHcMNnxnPNbTP1GhDKzdWw1raz/CQlznrFlGzzLTvcT5YDrFxHWOBAoIahfhcJBjSPafPanuKU64iFvvMDIFCZvRONzfVYk3+QkgabuJ4n4n4Ncr9Q3gn7+tvwauW2WoioEKhAoxhYUAcA3GYt7leBdpXpgJehdIvlWhgqMWpJVeDOdSIlCneqonsAmHsbHePxKtDmTDj+yKFiorfPRkMFz84Uzt+OShLIH/6QyBcZWNFUKh1Pdu8SC+oXzdspVC2gh1SryrI3aZ3H0A7JgZc/nnYRE7J4vKiGO2/rzu1nDzAZIWdDFhwu3W1DZ/X2iFKu0dgZ+rpP0T7CcM/pza1/MSPmU+UphM71Z3zFutsB0xHGvLOj3Co24NM2Aa8mTUwtGl2KNbra1Z5RAT7yI7tnzaa5NUap2/yY7J7nhDzBzEAnQtcP6wSEGzlpwK7RuvEI5/ayElysFqv2AQgUmjUFfSJTCWFrO0WCJDNKGybTYY02w7lyeNsoiV40UNy0Wwal8dpL6ZTab+pKJZA+w2atkb+SyNFc8/ECRI7W/0EM4s7pyIfmYAcQkta2BMZVkWU31Ba3enqL4EMPRXPCrwiBbLRVUw5sKyEKFpcqx8WY
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aad2e1da-bdec-4837-a7a7-08db36b3d3af
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 15:30:18.3505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bV4SEbjQtxBqmAx4cOH1LfrMRG+UqRUADLvx2EnUzKwAqgk+NMCM4EAGZdlrab2HJD3Wq8Y3sVK5TjkhwbicLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4252
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-06_09,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304060138
X-Proofpoint-ORIG-GUID: 34RAs_hYKmUUu8mKrN_OLd61QsY0DhGl
X-Proofpoint-GUID: 34RAs_hYKmUUu8mKrN_OLd61QsY0DhGl
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/6/23 02:56, Chen Yu wrote:
> On 2023-04-04 at 14:29:15 -0400, chris hyser wrote:
>> Commit 6419265899d9 ("sched/fair: Fix division by zero
>> sysctl_numa_balancing_scan_size") prevented a divide by zero by using
>> sysctl mechanisms to return EINVAL for a sysctl_numa_balancing_scan_size
>> value of zero. When moved from a sysctl to a debugfs file, this checking
>> was lost.
>>
>> This patch puts zero checking back in place.
>>
> Maybe add a tag
> Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")

Yes, you are correct. I should have reviewed the patch submitter doc. 
Also seems like a Cc: to stable is appropriate.

>> Signed-off-by: Chris Hyser <chris.hyser@oracle.com>
> 
> Other than that,
> Tested-by: Chen Yu <yu.c.chen@intel.com>
> 
> thanks,
> Chenyu

Thank you. Changes made and sent as v4.

-chrish