Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <36b96b9c-d08a-e97c-05ff-152d671880e6@redhat.com>
Date:   Thu, 6 Apr 2023 11:53:27 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2] mm: oom: introduce cpuset oom
Content-Language: en-US
To:     Gang Li <ligang.bdlg@bytedance.com>
Cc:     rientjes@google.com, linux-kernel@vger.kernel.org,
        Zefan Li <lizefan.x@bytedance.com>, cgroups@vger.kernel.org
References: <20230404115509.14299-1-ligang.bdlg@bytedance.com>
 <ZCw0sR6IqYa5Es7Q@dhcp22.suse.cz>
 <342c1967-8a68-275c-042e-765d5993157c@redhat.com>
 <cc77d706-7baf-951b-13a5-3470c2b1bba9@bytedance.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <cc77d706-7baf-951b-13a5-3470c2b1bba9@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/6/23 09:02, Gang Li wrote:
> On 2023/4/5 01:24, Waiman Long wrote:
>>
>> You will also need to take cpuset_rwsem to make sure that cpusets are 
>> stable. BTW, the cpuset_cgroup_scan_tasks() name is kind of 
>> redundant. I will suggest you just name it as cpuset_scan_tasks(). 
>> Please also add a 
>
> mem cgroup oom use `mem_cgroup_scan_tasks`.
> How about keep `cpuset_cgroup_scan_tasks` for naming consistency?

The "memory cgroup" term is used to identify the code related to memory 
cgroup controller. Cpuset, on the other hand, is a well known cgroup 
controller. Cpuset cgroup is not a term that people will normally use.  
That is why this name is awkward.

Cheers,
Longman