Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14634180-aca9-a3e9-d1af-dfaca77b42ee@linaro.org>
Date:   Thu, 6 Apr 2023 18:50:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 2/2] dt-bindings: cisco: document the CrayAR
 compatibles
Content-Language: en-US
To:     "Daniel Walker (danielwa)" <danielwa@cisco.com>
Cc:     "xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
        "Marcin Wierzbicki -X (mawierzb - GLOBALLOGIC INC at Cisco)" 
        <mawierzb@cisco.com>, Rob Herring <robh+dt@kernel.org>,
        Daniel Walker <dwalker@fifo99.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230405223028.1268141-2-danielwa@cisco.com>
 <6a9f041b-1c35-4691-8451-7119cd05ed17@linaro.org>
 <20230406151512.GL40472@zorba>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230406151512.GL40472@zorba>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/04/2023 17:15, Daniel Walker (danielwa) wrote:
> On Thu, Apr 06, 2023 at 09:12:34AM +0200, Krzysztof Kozlowski wrote:
>> On 06/04/2023 00:30, Daniel Walker wrote:
>>> Describe the compatible properties for the Cisco CrayAR SoC.
>>>
>>> Cc: xe-linux-external@cisco.com
>>> Cc: Marcin Wierzbicki <mawierzb@cisco.com>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>
>> Please drop the autogenerated scripts/get_maintainer.pl CC-entries from
>> commit msg. There is no single need to store automated output of
>> get_maintainers.pl in the git log. It can be easily re-created at any
>> given time, thus its presence in the git history is redundant and
>> obfuscates the log.
>>
>> If you need it for your own patch management purposes, keep it under the
>> --- separator.
>  
> I added these, so it's not script output. I can move them under the separator.
> The reason for that was to make sure people who commented get Cc'd.

So read my message again. There is no reason to add these entries for
people who are listed as maintainers, because you are supposed to CC
maintainers always.

> 
>>> Signed-off-by: Daniel Walker <dwalker@fifo99.com>
>>> ---
>>>  .../devicetree/bindings/arm/cisco/crayar.yaml | 27 +++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/arm/cisco/crayar.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/cisco/crayar.yaml b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml
>>> new file mode 100644
>>> index 000000000000..0ee4e6313ab0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml
>>
>> How many (or not many) platforms do you expect from Cisco? We mostly
>> have one file per SoC manufacturer.
> 
> We have two SoC's one called CrayAR and another called Craw. I've submitted the
> Craw dts file before , but I've not resubmitted it. Under Craw I think we have
> at least two, but more likely five variations. CrayAR we have one variation with
> at least one more planned.
> 
> So we would plan over time to add two dtsi files and three to four dts files to
> this directory. Then more over time.

So just keep them in one file maybe.

Best regards,
Krzysztof