Received: by 2002:ac8:156:0:b0:3e0:cd10:60c8 with SMTP id f22csp15761qtg; Thu, 6 Apr 2023 10:46:12 -0700 (PDT) X-Google-Smtp-Source: AKy350aDCiRRvQk3i7WDd+ap2npiGStWIaDWhjA3hkPNrpwlALg7BzQToRKZoY6Bc6vhKkf7z7Xl X-Received: by 2002:a17:906:3c06:b0:947:f4e2:ad6d with SMTP id h6-20020a1709063c0600b00947f4e2ad6dmr6952595ejg.72.1680803172196; Thu, 06 Apr 2023 10:46:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680803172; cv=none; d=google.com; s=arc-20160816; b=mvPFnhtdwdsQdqUaYZQ8/vSj2hiM5mjAme9/eNlkhFj3DS2JMogLjtUXr04uxMysDf w7K7voZ/IQN5bT50Ds0qiou4XgO0FlY98Tqdz9jdOFIy6f3DjriwWyQqhUbxYvswLJ+2 n1tGjdGH+szNAKwdhs+W0MfCA5rRCoqQPeOF/nmwpBDaHvpz2mFz4PaV2X8c9C4q0kNP 7u8fyUHGYAtofthHkLcleftgVQ0LJabZxnClmB896xLwiZoegsmo8ZGkEaMknkQcTjI6 E3g3vHKtwT/QpcNkVsjNWmps8vYH5gmoBeMp+G1ltS3Uz8lSoMLzwX2yZQdGFOIn+ZK5 WZOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=3E/HNbT+FMDjEdoF0Uz/hFR3DfCxuCGsFI6t6nM4pnU=; b=VB6jCWThDpHaLyH4Wzhg/drPejWRtpFTW1pmb9UI/3o1HA3ajPc0S3mOw1NILf6CeP x8H83TayCSqo1kERVt0MFbYV+tTiAFGf5WC5IIHBlRGmZnkskl1l2f8JQ/bylk6esOdj gZr77jR5WX3m9yRHrMJdOB2uvPLD7wReJuGtS+QQt7kqFMmxsH84Yk3wRKc0UJuzcODX l4+m5lg7EEAk005fz80nO21IF7fYUpJLpa/HI63XTQYJN/o4SlK4/m8USPAYGng8Jy9S GJXvivxeoJRqXPdBuTw9YXRioep6cSmt/ifTOnnttGa2rX0MglR2skP1/3UboMHPjE4R 0rCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UY6dvpwS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz23-20020a17090777d700b0092fd27697ecsi1326978ejc.908.2023.04.06.10.45.46; Thu, 06 Apr 2023 10:46:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UY6dvpwS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240054AbjDFRpA (ORCPT + 99 others); Thu, 6 Apr 2023 13:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240009AbjDFRo5 (ORCPT ); Thu, 6 Apr 2023 13:44:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8658DE; Thu, 6 Apr 2023 10:44:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8534060ECD; Thu, 6 Apr 2023 17:44:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D6AC433D2; Thu, 6 Apr 2023 17:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680803095; bh=aNrAPQwpmtdG/zMW/r6ym9rY9Cxi3FIvvKxFl3ubfQo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UY6dvpwSBR3zKxgef3Y7P3aRpADw6Swi1Q+HdI9htshxM55ZtMuul7mxDtVcour83 4By4oAFJYBZ6eiEiY/7rHSFfwKrjaILBF9RZqpXBi7ctNB0wV4ztUETQ5LVUn8QXnN JoZehPzGz9qxq+Y1YhJYvHLpcSetrm2tVtdooFhKkl+7ZGsDt7sf2h85zk4vI2YHxd Mu4k1dPygywMNto9I+YzFGp307eqFZWSHlIoNLIPRH/i9LzLfzJHcPVs079FfOTjMR V0ap7DVtXlJbiFMG4oihl29jPY0Z7PH4RpB4NF94MMwmobpGYNvDQW0PLMEcvWxqHA kl5dpHo10qb5A== Date: Thu, 6 Apr 2023 10:44:53 -0700 From: Jakub Kicinski To: Simon Horman Cc: Paolo Abeni , "David S. Miller" , Eric Dumazet , Nathan Chancellor , Nick Desaulniers , Tom Rix , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH net-next 2/3] ksz884x: remove unused #defines Message-ID: <20230406104453.3bc86676@kernel.org> In-Reply-To: References: <20230405-ksz884x-unused-code-v1-0-a3349811d5ef@kernel.org> <20230405-ksz884x-unused-code-v1-2-a3349811d5ef@kernel.org> <454a61709e442f717fbde4b0ebb8b4c3fdfb515e.camel@redhat.com> <20230406090017.0fc0ae34@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Apr 2023 18:12:49 +0200 Simon Horman wrote: > I guess that it two down-votes for removing the #defines. > > Would it be acceptable if I reworked the series to only remove > the dead code - which would leave only subset of patch 3/3 ? No preference in either direction on my side :(