Received: by 2002:ac8:156:0:b0:3e0:cd10:60c8 with SMTP id f22csp16428qtg; Thu, 6 Apr 2023 10:47:44 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1O0qlkfUlyfhTPdIXK0uLoyW/+aSwh3i8L6KYr8mzgdTvHbKTBu7tgU9YBIXk3CbaRBAi X-Received: by 2002:aa7:c70a:0:b0:4fd:f0a7:e0a1 with SMTP id i10-20020aa7c70a000000b004fdf0a7e0a1mr345023edq.24.1680803264723; Thu, 06 Apr 2023 10:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680803264; cv=none; d=google.com; s=arc-20160816; b=V0Ct/vc6Ft9rufziW7oE7Phicqv+VEYLuY/ZitoYAeuCmpS20kTPaSAkNfXSrUxN/5 7tB/mo5Y6mO6dTIcHeBGn4rn4mHDKo7Jou9jP/UaZUtnYwduF83n0e2w6MHBi6JyTkO3 /RUwaHpY/z0QzueOh/HnG7F0X34/8xIjDE3+3yp2KPDVPSQCyweGzr7GnZ5A1R5qudfM Rwc5iFaqZ1mXvq4OgUMz443D6OVBgEAc7pTCFLDgyz46pnQC+Pg7vUcoG40RSNh3jegG T0Zx1fzyNKZjwtn77FQSmD6IYN866LVU04j+VrF4fCQKtV6+rIY8BSNG3Nbkvf/oucws rQzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:to:from:date :dkim-signature; bh=RAECb/3wNcHEoEDLKDANAykGZzZoDwXPK2wrIHEQ2M4=; b=H0EGnS11NpOtNBFFD9zy3p4ECt3SusV0vjpHx/RJLXEW9WjBpbKn1BG2UXAGhwdF1W QliedTHdtDYvN11ihAh/WGo0wyetMKAAoYRNTzcS0/w0V40oYwqE27COem2PjXf9ohus T91McZVG+tTjkCV2WKXl5996sz0q098w8adEkpl2LxTRO4OMCqxNnJSXhvNTQFMHqpDD PEVGBVB2O1ZNjmRskHR6spknB5TRvYv5boke3ElYAXZX71rV3ccK9NcJRNBewL2kcc2/ gj0Mu3pOA8VrhnHdUa6VpQDMK/G4NrjK6o4uesWityUD5EPYxVyBMj3aDOWMPjRZ6yN4 /HFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=VuuDK66X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a056402051000b0050470a9fe37si867963edv.77.2023.04.06.10.47.18; Thu, 06 Apr 2023 10:47:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=VuuDK66X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240069AbjDFRqk (ORCPT + 99 others); Thu, 6 Apr 2023 13:46:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240062AbjDFRqj (ORCPT ); Thu, 6 Apr 2023 13:46:39 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68E55DE for ; Thu, 6 Apr 2023 10:46:38 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-93b8c095335so12476166b.0 for ; Thu, 06 Apr 2023 10:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1680803197; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=RAECb/3wNcHEoEDLKDANAykGZzZoDwXPK2wrIHEQ2M4=; b=VuuDK66XzIMzwP6ttaCqfnUgY9nG0smMaIRc2nItlYvdgub/p6Y5Aa/2Li187iMw48 FSSOONefopbdzJ9NJLaAgo+pTjRJ+YPqXb3OGyMqG5pyauXQCCsJvkWAv86EwxejwnHR ZRjXXsO6i2UWS8m+V4FYPkXIk+0oncskp5Vgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680803197; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RAECb/3wNcHEoEDLKDANAykGZzZoDwXPK2wrIHEQ2M4=; b=izIrvxu4zbSSx7ZqCkQC/xrJYae+jccKOCYOEw3zSd9gIUifo/jMsuiZfF9jifpgAQ cKEDkATWCJ5PgPcFYlU75dnwMJVOaqW2rxuMGJJPh8iNIUHg/b7onR/CpfkNCVA2K+Rt phiRN9WG6F0Jlw1iVi1KYuMb1r7ZjkdesQT5yGJ6nnVKW9PK/gQn7DHqJ58h/da5U8BX opuVf7QL/kw0y9e2pFeK0xUJWHASHipvxvpD/Md7+QifIwn0DyF29/baMxaJr01dRG7G 1Aec7BYlAS1pNk6/MsSx3RBjV2lH31CrcO30PzPba1/yFJsrjREwzgw42Ov91kLMckn7 RhGw== X-Gm-Message-State: AAQBX9fW3RILICD7dDHjA6XDr92Hp3Yk0uMuS+HSwlAafqmpNjGGBYC5 5LFS/9I4xC779B6Z0ufDP6KuMA== X-Received: by 2002:a17:906:3f12:b0:947:8734:a058 with SMTP id c18-20020a1709063f1200b009478734a058mr5629604ejj.4.1680803196956; Thu, 06 Apr 2023 10:46:36 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id kg13-20020a17090776ed00b008bc8ad41646sm1067618ejc.157.2023.04.06.10.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 10:46:36 -0700 (PDT) Date: Thu, 6 Apr 2023 19:46:34 +0200 From: Daniel Vetter To: Asahi Lina , Christian =?iso-8859-1?Q?K=F6nig?= , Luben Tuikov , Danilo Krummrich , Lucas Stach , Dave Airlie , Bagas Sanjaya , andrey.grodzovsky@amd.com, tvrtko.ursulin@linux.intel.com, Matthew Brost , yuq825@gmail.com, Boris Brezillon , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [Regression] drm/scheduler: track GPU active time per entity Message-ID: Mail-Followup-To: Asahi Lina , Christian =?iso-8859-1?Q?K=F6nig?= , Luben Tuikov , Danilo Krummrich , Lucas Stach , Dave Airlie , Bagas Sanjaya , andrey.grodzovsky@amd.com, tvrtko.ursulin@linux.intel.com, Matthew Brost , yuq825@gmail.com, Boris Brezillon , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <28d10733-b217-7ccc-4b8c-54bdc8249234@amd.com> <24fe6e14-0d0a-f874-766d-e8d045d1e80e@asahilina.net> <9500edc9-4e9d-9d64-b444-ea9523779700@asahilina.net> <30534307-24af-b6f8-ea9f-e4264997bf9d@asahilina.net> <2416c870-d069-defc-d14e-514e7db7d2fd@asahilina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 6.1.0-7-amd64 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2023 at 07:42:44PM +0200, Daniel Vetter wrote: > But I think there's tools to make sure we don't dig a complete hole with > these it sounds like. I guess another topic for pestering the rust folks. Or to put it very bluntly: Could we make Arc at least runtime enforce (with the usual lockdep annotation trick like fs_reclaim) that and Drop is the final one? If that's the rust Arc linux semantics then I think my worries are 100% covered. And we'll sort out the trickier type based enforcement for special cases when they hit us. The downside is that this is substantially stricter than kref on the C side, but I think that's a Good Thing :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch