Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230405201416.395840-1-daniel.almeida@collabora.com>
 <20230405201416.395840-3-daniel.almeida@collabora.com> <c2ebdc61-6aff-ab64-a0cb-e2170edfa689@gmail.com>
In-Reply-To: <c2ebdc61-6aff-ab64-a0cb-e2170edfa689@gmail.com>
From:   Wedson Almeida Filho <wedsonaf@gmail.com>
Date:   Thu, 6 Apr 2023 15:26:48 -0300
Message-ID: <CANeycqrG-t56KHJta1UTc9d8OHGvRnmjdW1g2swfkX5feaXoQw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] rust: virtio: add virtio support
To:     Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Cc:     Daniel Almeida <daniel.almeida@collabora.com>, ojeda@kernel.org,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 6 Apr 2023 at 11:22, Martin Rodriguez Reboredo
<yakoyoku@gmail.com> wrote:
>
> On 4/5/23 17:14, Daniel Almeida wrote:
> > This patch adds virtIO support to the rust crate. This includes the
> > capability to create a virtIO driver (through the module_virtio_driver
> > macro and the respective Driver trait) as well as initial virtqueue
> > support.
> >
> > A sample virtIO module is included for conveninence.
> >
> > Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
> > ---
> >  rust/bindings/bindings_helper.h |   3 +
> >  rust/helpers.c                  |  25 +++
> >  rust/kernel/lib.rs              |   2 +
> >  rust/kernel/virtio.rs           | 261 ++++++++++++++++++++++++++++++++
> >  rust/kernel/virtio/virtqueue.rs | 126 +++++++++++++++
> >  samples/rust/Kconfig            |  10 ++
> >  samples/rust/Makefile           |   1 +
> >  samples/rust/rust_virtio.rs     | 195 ++++++++++++++++++++++++
> >  8 files changed, 623 insertions(+)
> >  create mode 100644 rust/kernel/virtio.rs
> >  create mode 100644 rust/kernel/virtio/virtqueue.rs
> >  create mode 100644 samples/rust/rust_virtio.rs
>
> IMO this should be split further. If I were to suggest I'd say to do it
> as following.
>
> - virtio bindings
> - virtqueue bindings
> - sample virtio module
>
> This way the size of each commit would be more amenable to reviews.

Yes, I agree with Martin's suggestion.

Daniel, please split this further.

Cheers,
-Wedson