Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37d04794-d790-fd7c-9f34-901955083874@linaro.org>
Date:   Thu, 6 Apr 2023 20:46:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v6 1/2] dt-bindings: omap: Convert omap.txt to yaml
Content-Language: en-US
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        tony@atomide.com, afd@ti.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
References: <20230405161908.4312-1-andreas@kemnade.info>
 <20230405161908.4312-2-andreas@kemnade.info>
 <eb4cf82d-f523-d5af-be18-25c37678a95a@linaro.org>
 <7f43953c-d326-f517-d896-cbb060d8092a@linaro.org>
 <20230406203548.152ae065@aktux>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230406203548.152ae065@aktux>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/04/2023 20:35, Andreas Kemnade wrote:
> On Thu, 6 Apr 2023 10:36:36 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 06/04/2023 10:32, Krzysztof Kozlowski wrote:
>>> On 05/04/2023 18:19, Andreas Kemnade wrote:  
>>>> From: Andrew Davis <afd@ti.com>
>>>>
>>>> Convert omap.txt to yaml.
>>>>  
>>>
>>>   
>>>> +      - description: TI AM43 SoC based platforms
>>>> +        items:
>>>> +          - enum:
>>>> +              - compulab,am437x-cm-t43
>>>> +              - ti,am437x-gp-evm
>>>> +              - ti,am437x-idk-evm
>>>> +              - ti,am437x-sk-evm
>>>> +          - pattern: '^ti,am4372[26789]$'
>>>> +          - const: ti,am43
>>>> +
>>>> +      - description: TI AM57 SoC based platforms
>>>> +        items:
>>>> +          - enum:
>>>> +              - beagle,am5729-beagleboneai
>>>> +              - compulab,cl-som-am57x
>>>> +              - ti,am5718-idk
>>>> +              - ti,am5728-idk
>>>> +              - ti,am5748-idk
>>>> +          - pattern: '^ti,am57[0124][689]$'  
>>>
>>> I don't think my comments were resolved. I asked if it is possible to
>>> make a board called "ti,am5718-idk" with "ti,am5749" or with "ti,am5708"?  
>>
>> Hm, I cannot find my concern, so maybe it never left my outbox. Anyway,
>> it looks like you allow here many incorrect patterns and combinations.
>>
> You had concerns about the "dra" stuff for the same valid reasons.

Yes, but also about this. So again:
is "ti,am5718-idk" with "ti,am5749" correct?

> 
>>>
>>> What's more, you dropped several variations and compatibles against
>>> original binding (all the "dra") and it is not explained in commit msg
>>> at all.  
>>
>> All changes against original bindings should be explained.
>>
> ... which I then just decided not to convert but keep as is in the text file
> because there were no comments hints about it more than a month since the first
> version was sent so thought that it has to be resolved later.

But you partially remove them - see AM5728 IDK.

Best regards,
Krzysztof