Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0746dd23-5dcf-e858-e15b-159673266f2f@oracle.com>
Date:   Thu, 6 Apr 2023 12:30:26 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: Semantics of blktrace with lockdown (integrity) enabled kernel.
Content-Language: en-US
To:     Paul Moore <paul@paul-moore.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org, jmorris@namei.org,
        serge@hallyn.com, nathanl@linux.ibm.com, joe.jin@oracle.com,
        Eric <eric.snowberg@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>, axboe@kernel.dk
References: <ZC8Dbux56HbJjpTy@char.us.oracle.com>
 <CAHC9VhQ2rLpjczvb4993fQiMau7ZXLe8aTLtMZO_iF42w=1frg@mail.gmail.com>
From:   Junxiao Bi <junxiao.bi@oracle.com>
In-Reply-To: <CAHC9VhQ2rLpjczvb4993fQiMau7ZXLe8aTLtMZO_iF42w=1frg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aC84dVk2ZTFpclN3RDVPeFZDZWwrdnU0bVVib3ZCRTBqbStTbGIrR2c5VHJr?=
 =?utf-8?B?SnBZVjVjNkJjeEdROEU2RUZlTmFtbVlSVkJwZWpMY1lyeDZ5enhsWS8vK1Y4?=
 =?utf-8?B?MXJKM0tRUXEyYnhCS24yK21IQitsQkxETmhUTzhzWmR5bFg3UXNiSVViR0Jk?=
 =?utf-8?B?WkFaN1Nqa0h6QlFxT2lsZnlzWU1CQjlNMGtlSFp0WU5xOXFRT1RWcnVhOTdi?=
 =?utf-8?B?eTRHQnlNRWJpakpyUFFQZVFSbFZYUjFzVVlBYXJmY0FxTEcwNEhQcnVtMjVW?=
 =?utf-8?B?eWxUeEFBdDE3NWdWd3ExQ3NVUTB2RFRFUXlsMmtzS1U4czg2R24yUnBzd3Q1?=
 =?utf-8?B?Y0MwMlMvVzRLWUhFNE1iQWt3N25maGFoSG9lbXl6YnA5M01hVWFHeWwvUHQ5?=
 =?utf-8?B?WUNKWmFFZG9YZUFDZzNnL3MvUUU3OFB2S1VWN3dEWERLZGVaZGlETTVrOUhl?=
 =?utf-8?B?M0w2Mm1tL1RBYndaZkU3SWhRMGhsL3NhbTZhTXIyRS9aQTI5dmR2cXFZTFQ2?=
 =?utf-8?B?VXlQOElUUVVLcDEvbWN5V1NrWmt2V1JLVDdRcGhlaUNialVaZ2Fpb0hGLzFr?=
 =?utf-8?B?RGZwbldwdG0ycGhhNFB5RWgxeDJIRU9aNFlkSTdhd3lsTGFRaWhQTjBjbktq?=
 =?utf-8?B?dFVyOVFxTjlQam8rdWY2QXQ4MHF5eUxEeXFTK3hCZHRpL0NsTjVuenhWVVJR?=
 =?utf-8?B?VWN2V2ViYm9GamowQ2RBNWFpODZKVnB1b1gyRTQ2WDl0dHVMaWlQVkJIU21M?=
 =?utf-8?B?dmkrd0pENVZ3RktvbU1jTVpvNUtFQk82dFFCS1pOSHpuUW9BRXE0dXNUQ0Ns?=
 =?utf-8?B?WGRQUFRINHFoWTRyelZWbTBYSDcxbVJUa2diOEJYVVVEbWE2dzZXMTVJQ3pi?=
 =?utf-8?B?RER1VVFDL0dMWThsTDRwcjlON3cvSUo0T0VEYUVqaEJ1d0ltRTBsN2JuSlZC?=
 =?utf-8?B?Tk1vdGxoaStJOEFVZEdVVU02R3hVY3dmbXVlaUkzSGZaK0Y3UXZ4Yk5mRjhY?=
 =?utf-8?B?NzJvQVlRZk9ZbkptY1FUQnd2c3BERHUvcGRZN1liRm41Q3JENGtmQ0lIa2ZB?=
 =?utf-8?B?aHVzdjNLVDFBb24weURjdjFUTTlxV2VyUVZKbFVQWmhRV1Znbml2Tjljdys0?=
 =?utf-8?B?L2E3V0lXZXhHcWlNWGlweTY4d2RPaUkxV2ZIcWdrNS9ZRVNiK0JaV1k1bXpE?=
 =?utf-8?B?VzRSbXhuRnBFYml4YmFYU3Avb21EUzNVV21RTVV3ZmFYRkUxeFRUL2VaUXcy?=
 =?utf-8?B?eC91ZU9NVTIwNk5FVFo5b2lFdE16UVc3RURTaE50QlliVy9ZQnJQT1d4bzhn?=
 =?utf-8?B?SEJvK2cvc3VObXpHd05zMXBDNzhBbmFkOWpkVDNyS0Q4WW1uaEVCT2hHQVIx?=
 =?utf-8?B?ZTlMTEs5N3cwaDFBMjNBeUUxbFUreFV1V3NGSVcwbGlEeXNQVW01OWlra1Iv?=
 =?utf-8?B?dXc4L2VxRkNKN1czZXBLOFBDdzBEd2dDSnNDRmpYOS9BRGJTZXJBZUdoalBu?=
 =?utf-8?B?Sk9NL1JPYVVUZkZQZ0pXUW5iZ0hsSys1NFo3eUlzdDZGRnJCWlZWZXhPSTkr?=
 =?utf-8?B?MTZWcXJScTZNR3hmMHdOa09TYVZrcG5ub0hIYjlxaWJpNjQwd0xsd1ZJNXlM?=
 =?utf-8?B?WExhVlJzbkFUa25XL3hWNSswYUQ2a1dNS2NJelR1VHhhT21BTHRwVFZSdVow?=
 =?utf-8?B?OTh6NzZ3OFBjeXkwZElRNXlVOWtXbFhPemJha1BjSW5LNnhxdUdNUERpQW9q?=
 =?utf-8?B?UDVZMTRMVTdvTGVqejhSdXc3ZGRtV1BRVjdEa2tCRmF0ZWhiK2srL1hkcGsy?=
 =?utf-8?B?ZEFaWUh0SWJIa0xTdEZrQWtuUzdYL3FCbE1KT3h3ZVA5Q1Z5Mm1PUXUwOUZL?=
 =?utf-8?B?R0ZIMmdRWDhMTGFXVm43bE5qalVYQ2dPMVhHUWk4ZVRia3hJeHZzSXdmYVd0?=
 =?utf-8?B?TFd6YVlNaXc5MmN6NjJyb2swS3h0NFBVQzI1TzVqaVROYWcrUGF4eExjNGc2?=
 =?utf-8?B?VGpGTTNuR0pvdHNhQkV6RFcrcVMxQVFYTXp1RXVSK1RLOW9UdjZOV0VDVlJk?=
 =?utf-8?B?eGxJNG01bGpHUEg5Z1BKVEtFVXdLcThJKzg1dlBjYWVicGdsK3l6L1J1ZFR3?=
 =?utf-8?Q?e9258dZeE8BaCIQ+xcw1nVSa1?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EPgbzBRmd/jR0b/vn8x977M+p04w0kLRVElQvxLWjwivQW11t5cBKVWA0ld9oXeSq0oKCzZURPAPzm+4gJ/07XVgPPxhinvqjva9f5tTpNlR2er5A7/VyAYYkA2rvZK/yIs3W7vDaAIihdYuomM0SYg/bXlMGE15KshpJI0NJ9Imi4KFjR7nPqoqv2YHgUINeBIakzvgE4BFBVJRB/EyVKf9bITXQ+//xhVGvY/tfv4lyX6WI7/0y9taEv6K6qYSa1wkoZ/4nvLRDdvcMyTJrNGKa/bflwnvzSifDHQC58E4Qc1dKrwwIH19W818casZw1UPkp+iW+ePsvWVN0BWRypQ8s85yaWm4Tocv/8zEQNTlSt2qMend3Tfny4e1ctRkWxcBdeOkjB+32lTK/WPYyhXhwkLkL/uQ1wbowFcaCYi1cKBBPzKCVS5osQsUE+2Vn9y4e8OcID6H8Vs6ohSBv+SGiAFJPXnK76j79iG6G9SvldN8PoyGy6fCVIouveydpTOR2ftEiN72750/rLMPseq0KlS9tL3VDuy2Cavi9r67j3PixOvjkgLi7eArOr1+u/04WeyBpMyO2MvdL3HVjcBJzQI9CTBRsmbWgjxCW0Fe34h1f9L0wy35dzut/u+kARxOKQtiNP5FIs5+6T6pXA6rCUrIFr50OgE/2nThQ83Mv3Roteglo5fwTlZ475ApT2D6Q2eKl83f9TLRFtvYohPLw7Vsp/n5UnKyGwFE3tipQaQE9vgMOxGvVars22/vDDveGEfM2QOZmFL4LhKxkHoyjfd46qEHv1228y5Oaiy79sOBwezu0vK6xEV94+f26Yc+RGgTpPXGD6MX+6IQ4AeqmyXcpjJiW7bfEQbMva+HKCSOT51mylRKU1FYZ7LSMfYe8osbg3g6UeACj19HcLAUuHZa1NUCoFcJun6NfA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 555d1bf6-ea5b-4cd3-7d63-08db36d561ed
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 19:30:30.3819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SG02+nCMdcTGBx5IdFr3e+akuaGayzcly9A00aIRyZ+YqUqx87+68hESMtFqCPkhx5I7L9A4+lR2MVeX051F6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-06_11,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304060172
X-Proofpoint-ORIG-GUID: aNSHPlesCLFCzQcKuPCh0xJ_On4b9qh7
X-Proofpoint-GUID: aNSHPlesCLFCzQcKuPCh0xJ_On4b9qh7
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/6/23 11:39 AM, Paul Moore wrote:

> On Thu, Apr 6, 2023 at 1:38 PM Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
>> Hey Jens, Paul, James, Nathan,
>>
>> We are trying to use blktrace with a kernel that has lockdown enabled and find that it cannot run.
>>
>> Specifically the issue is that we are trying to do is pretty simple:
>>
>> strace -f blktrace -d /dev/sda -w 60
>>
>> [pid 148882] <... mprotect resumed>)    = 0
>> [pid 148881] openat(AT_FDCWD, "/sys/kernel/debug/block/sda/trace0", O_RDONLY|O_NONBLOCK <unfinished ...>
>> [pid 148882] sched_setaffinity(0, 8, [1]) = 0
>> [pid 148881] <... openat resumed>)      = -1 EPERM (Operation not permitted)
>>
>> which fails. The analysis from Eric (CCed) is that
>>
>> All debugfs entries do not exist until blktrace is run.  It is opening
>> /sys/kernel/debug/block/sda/trace0 which isn’t there normally. While running the utility,
>> to place something in it, it must have the write permission set.  When exiting out of
>> blktrace, the entry is gone, both on a machine running with secure boot enabled
>> and one with it disabled.  Which also indicates the write permission was set,
>> otherwise the entry would still be there.
>>
>> The fix is simple enough (see attachment) but we are not sure about the semantics of what
>> lockdown has in mind.
>>
>> Looking at the include/linux/security.h the LOCKDOWN_TRACEFS exists which would
>> imply that it is expected that operations with tracefs *should* work with lockdown (integrity mode).
>>
>> But at the same point, debugfs writable attributes are a nono with lockdown.
>>
>> So what is the right way forward?
> What did you use as a basis for your changes?  I'm looking at the
> patch you sent and it appears to be making a change to a
> debugfs_lockdown_whitelisted() function defined in
> fs/debugfs/internal.h which does not exist in Linus' tree.  If I
> search through all of the archives on lore.kernel.org the only hit I
> get is your email, so it seems doubtful it is in a subsystem tree
> which hasn't made its way to Linus yet.
>
> Before we go any further, can you please verify that your issue is
> reproducible on a supported, upstream tree (preferably Linus')?

The patch attached is applied to oracle kernel which is just used to 
demo the idea of a possible fix.

Upstream will have the same issue because blktrace uses relay files from 
debugfs to transfer trace information from kernel to userspace. Those 
relay files are having permission 0400 which are good, but they support 
mmap (struct file_operations relay_file_operations), which are against 
the rule of lock down. Is there any security concern to whitelist these 
files in lockdown mode? Any idea how to fix this for upstream?

static int debugfs_locked_down(struct inode *inode,
                    struct file *filp,
                    const struct file_operations *real_fops)
{
     if ((inode->i_mode & 07777 & ~0444) == 0 &&
         !(filp->f_mode & FMODE_WRITE) &&
         !real_fops->unlocked_ioctl &&
         !real_fops->compat_ioctl &&
         !real_fops->mmap)
         return 0;

     if (security_locked_down(LOCKDOWN_DEBUGFS))
         return -EPERM;

     return 0;
}

Thanks,

Junxiao.

>